Clear historical conversation when disabling ai feature

Historical conversations are now cleared immediately when the "AI Assistance" feature is disabled in settings. This provides a more predictable user experience. A corresponding test has been added to verify this behavior.

Change-Id: I145d05c55c5388c5fbd8d012e7b9d02713c605a5
Fixed: 419212081
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6712173
Reviewed-by: Alex Rudenko <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Natallia Harshunova <[email protected]>

Author: Natallia Harshunova

front_end/models/ai_assistance/AiHistoryStorage.test.ts

@@ -334,6 +334,7 @@ describe('AiHistoryStorage', () => {
     await storage.upsertImage(serializedImage1);
     await storage.upsertImage(serializedImage2);
     await storage.upsertHistoryEntry(agent4);
+    const historyDeletedPromise = storage.once('AiHistoryDeleted' as AiAssistance.Events.HISTORY_DELETED);
     await storage.deleteAll();
     assert.deepEqual(
         storage.getHistory(),
@@ -343,6 +344,7 @@ describe('AiHistoryStorage', () => {
         storage.getImageHistory(),
         [],
     );
+    await historyDeletedPromise;
   });
 
   it('should limit the amount of stored images', async () => {

front_end/models/ai_assistance/AiHistoryStorage.ts

@@ -129,13 +129,22 @@ let instance: AiHistoryStorage|null = null;
 
 const DEFAULT_MAX_STORAGE_SIZE = 50 * 1024 * 1024;
 
-export class AiHistoryStorage {
+export const enum Events {
+  HISTORY_DELETED = 'AiHistoryDeleted',
+}
+
+export interface EventTypes {
+  [Events.HISTORY_DELETED]: void;
+}
+
+export class AiHistoryStorage extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   #historySetting: Common.Settings.Setting<SerializedConversation[]>;
   #imageHistorySettings: Common.Settings.Setting<SerializedImage[]>;
   #mutex = new Common.Mutex.Mutex();
   #maxStorageSize: number;
 
   constructor(maxStorageSize = DEFAULT_MAX_STORAGE_SIZE) {
+    super();
     this.#historySetting = Common.Settings.Settings.instance().createSetting('ai-assistance-history-entries', []);
     this.#imageHistorySettings = Common.Settings.Settings.instance().createSetting(
         'ai-assistance-history-images',
@@ -229,6 +238,7 @@ export class AiHistoryStorage {
       this.#imageHistorySettings.set([]);
     } finally {
       release();
+      this.dispatchEventToListeners(Events.HISTORY_DELETED);
     }
   }
 

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -716,6 +716,30 @@ describeWithMockConnection('AI Assistance Panel', () => {
       const menuAfterDelete = openHistoryContextMenu(view.input, 'User question to Freestyler?');
       assert.isUndefined(menuAfterDelete.id);
     });
+
+    it('should clear the list of previous conversations when all history is deleted', async () => {
+      const {panel, view} = await createAiAssistancePanel({aidaClient: mockAidaClient([[{explanation: 'test'}]])});
+      panel.handleAction('freestyler.elements-floating-button');
+      (await view.nextInput).onTextSubmit('test');
+      await view.nextInput;
+
+      let {contextMenu} = openHistoryContextMenu(view.input, 'test');
+      assert.isDefined(findMenuItemWithLabel(contextMenu.defaultSection(), 'test'));
+      contextMenu.discard();
+
+      await AiAssistanceModel.AiHistoryStorage.instance().deleteAll();
+
+      const newViewInput = await view.nextInput;
+      ({contextMenu} = openHistoryContextMenu(newViewInput, 'test'));
+
+      const defaultSectionItems = contextMenu.defaultSection().items;
+      assert.lengthOf(defaultSectionItems, 1, 'Default section should have one item');
+
+      const placeholderItem = defaultSectionItems[0];
+      assert.strictEqual(placeholderItem.buildDescriptor().label, 'No past conversations');
+      assert.isFalse(placeholderItem.isEnabled(), 'Placeholder item should be disabled');
+    });
+
   });
 
   describe('empty state', () => {

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -533,6 +533,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       this.#toggleSearchElementAction =
           UI.ActionRegistry.ActionRegistry.instance().getAction('elements.toggle-element-search');
     }
+    AiAssistanceModel.AiHistoryStorage.instance().addEventListener(
+        AiAssistanceModel.Events.HISTORY_DELETED, this.#onHistoryDeleted, this);
   }
 
   #getChatUiState(): ChatViewState {
@@ -1247,17 +1249,16 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     contextMenu.footerSection().appendItem(
         i18nString(UIStrings.clearChatHistory),
         () => {
-          this.#clearHistory();
+          void AiAssistanceModel.AiHistoryStorage.instance().deleteAll();
         },
         {
           disabled: historyEmpty,
         },
     );
   }
 
-  #clearHistory(): void {
+  #onHistoryDeleted(): void {
     this.#historicalConversations = [];
-    void AiAssistanceModel.AiHistoryStorage.instance().deleteAll();
     this.#updateConversationState();
   }