Skip to content

Commit eeae7f5

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
authored andcommitted
Roll browser-protocol
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8709370143606857425 [email protected] Bug: none Change-Id: I49dd55f86fe556b8ef54da11edbc3ebc35097c0e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6731642 Commit-Queue: Philip Pfaffe <[email protected]> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Philip Pfaffe <[email protected]>
1 parent b9daca3 commit eeae7f5

File tree

4 files changed

+23
-26
lines changed

4 files changed

+23
-26
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ vars = {
2424
'inspector_protocol_revision': '6d1ae0f13aae6ad381ca31b17b88a0f5af29ca94',
2525

2626
# Keeping track of the last time we rolled the browser protocol files.
27-
'chromium_browser_protocol_revision' : 'b5b53c1e399d6f13e84f19e13bbbbc68d2dc137c',
27+
'chromium_browser_protocol_revision' : 'ae5eaf9de9cf28bd4ab1217daa569902baeaad73',
2828

2929
'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
3030
'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',

front_end/generated/SupportedCSSProperties.js

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2804,7 +2804,8 @@ export const generatedProperties = [
28042804
},
28052805
{
28062806
"keywords": [
2807-
"normal"
2807+
"normal",
2808+
"infinite"
28082809
],
28092810
"name": "item-tolerance"
28102811
},
@@ -3843,11 +3844,6 @@ export const generatedProperties = [
38433844
"name": "scroll-margin-top"
38443845
},
38453846
{
3846-
"keywords": [
3847-
"none",
3848-
"after",
3849-
"before"
3850-
],
38513847
"name": "scroll-marker-group"
38523848
},
38533849
{
@@ -5954,7 +5950,8 @@ export const generatedPropertyValues = {
59545950
},
59555951
"item-tolerance": {
59565952
"values": [
5957-
"normal"
5953+
"normal",
5954+
"infinite"
59585955
]
59595956
},
59605957
"left": {
@@ -6488,13 +6485,6 @@ export const generatedPropertyValues = {
64886485
"nearest"
64896486
]
64906487
},
6491-
"scroll-marker-group": {
6492-
"values": [
6493-
"none",
6494-
"after",
6495-
"before"
6496-
]
6497-
},
64986488
"scroll-padding-block-end": {
64996489
"values": [
65006490
"auto"

front_end/third_party/chromium/README.chromium

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Name: Dependencies sourced from the upstream `chromium` repository
22
URL: https://source.chromium.org/chromium/chromium/src/+/main:components/variations/proto/devtools/
33
Version: N/A
4-
Revision: b5b53c1e399d6f13e84f19e13bbbbc68d2dc137c
4+
Revision: ae5eaf9de9cf28bd4ab1217daa569902baeaad73
55
Update Mechanism: Manual (https://crbug.com/428069060)
66
License: BSD-3-Clause
77
License File: LICENSE

third_party/blink/renderer/core/css/css_properties.json5

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4144,14 +4144,15 @@
41444144
// TODO(crbug.com/343257585): We might need to alter the spec's grammar to accept
41454145
// normal | <length-percentage>. With normal, we use `1em` for tolerance size.
41464146
name: "item-tolerance",
4147+
include_paths: ["third_party/blink/renderer/core/style/item_tolerance.h"],
41474148
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
41484149
field_group: "*",
41494150
field_template: "external",
4150-
default_value: "std::nullopt",
4151-
type_name: "std::optional<Length>",
4151+
default_value: "ItemTolerance(CSSValueID::kNormal)",
4152+
type_name: "ItemTolerance",
41524153
converter: "ConvertItemTolerance",
4153-
typedom_types: ["Length", "Percentage"],
4154-
keywords: ["normal"],
4154+
typedom_types: ["Length", "Percentage", "Keyword"],
4155+
keywords: ["normal", "infinite"],
41554156
invalidate: ["layout", "paint"],
41564157
runtime_flag: "CSSMasonryLayout",
41574158
},
@@ -5058,13 +5059,17 @@
50585059
},
50595060
{
50605061
name: "scroll-marker-group",
5061-
property_methods: ["CSSValueFromComputedStyleInternal"],
5062+
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
50625063
field_group: "*",
5063-
field_template: "keyword",
5064-
keywords: ["none", "after", "before"],
5064+
field_template: "pointer",
50655065
typedom_types: ["Keyword"],
5066-
default_value: "none",
5066+
default_value: "nullptr",
50675067
runtime_flag: "CSSPseudoScrollMarkers",
5068+
include_paths: ["third_party/blink/renderer/core/style/scroll_marker_group.h"],
5069+
wrapper_pointer_name: "Member",
5070+
type_name: "ScrollMarkerGroup",
5071+
converter: "ConvertScrollMarkerGroup",
5072+
typedom_types: ["Keyword"],
50685073
},
50695074
{
50705075
interpolable: true,
@@ -5581,8 +5586,8 @@
55815586
field_template: "pointer",
55825587
type_name: "SVGDashArray",
55835588
include_paths: ["third_party/blink/renderer/core/style/svg_dash_array.h"],
5584-
wrapper_pointer_name: "scoped_refptr",
5585-
default_value: "EmptyDashArray()",
5589+
wrapper_pointer_name: "Member",
5590+
default_value: "nullptr",
55865591
name_for_methods: "StrokeDashArray",
55875592
converter: "ConvertStrokeDasharray",
55885593
keywords: ["none"],
@@ -6579,6 +6584,7 @@
65796584
{
65806585
name: "column-rule-outset",
65816586
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
6587+
interpolable: true,
65826588
inherited: false,
65836589
field_group: "*",
65846590
field_template: "<length>",
@@ -6591,6 +6597,7 @@
65916597
{
65926598
name: "row-rule-outset",
65936599
property_methods: ["ParseSingleValue", "CSSValueFromComputedStyleInternal"],
6600+
interpolable: true,
65946601
inherited: false,
65956602
field_group: "*",
65966603
field_template: "<length>",

0 commit comments

Comments
 (0)