Skip to content

Commit efa7bb8

Browse files
wolfibDevtools-frontend LUCI CQ
authored andcommitted
[Dr Jones] No-agent state: add strings for file and performance agent
Bug: 353441061 Change-Id: I7525b231081ef9e4b2d24c0f9e796ad371cc7b99 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5938190 Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Wolfgang Beyer <[email protected]>
1 parent 3140d11 commit efa7bb8

File tree

2 files changed

+35
-3
lines changed

2 files changed

+35
-3
lines changed

front_end/panels/freestyler/components/FreestylerChatUi.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,12 @@ css
129129
devToolsExplainThisResourceDogfood: {
130130
enabled: true,
131131
},
132+
devToolsAiAssistanceFileAgentDogfood: {
133+
enabled: true,
134+
},
135+
devToolsAiAssistancePerformanceAgentDogfood: {
136+
enabled: true,
137+
},
132138
});
133139
const props = getProp({
134140
agentType: undefined,
@@ -137,9 +143,11 @@ css
137143
renderElementIntoDOM(chat);
138144
const instructions = chat.shadowRoot?.querySelectorAll('.instructions strong');
139145
assert.isDefined(instructions);
140-
assert.strictEqual(instructions?.length, 2);
146+
assert.strictEqual(instructions?.length, 4);
141147
assert.strictEqual(instructions[0].textContent, 'CSS help:');
142-
assert.strictEqual(instructions[1].textContent, 'Network request insights:');
148+
assert.strictEqual(instructions[1].textContent, 'File insights:');
149+
assert.strictEqual(instructions[2].textContent, 'Network request insights:');
150+
assert.strictEqual(instructions[3].textContent, 'Performance analysis:');
143151

144152
stub.restore();
145153
});

front_end/panels/freestyler/components/FreestylerChatUi.ts

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,15 @@ const UIStringsNotTranslate = {
202202
*/
203203
cssHelpExplainer:
204204
'Navigate to the Elements panel, right-click a DOM element, and select "Ask AI assistant". I’ll be happy to explain its styles or behavior.',
205+
/**
206+
* @description AI assistance for files.
207+
*/
208+
fileHelp: 'File insights:',
209+
/**
210+
* @description Explanation on how to use AI assistance for files in the Sources panel.
211+
*/
212+
fileHelpExplainer:
213+
'Open the Sources panel, right-click a file, and select "Ask AI". I can provide insights into its purpose or origin.',
205214
/**
206215
* @description AI assistance for network requests.
207216
*/
@@ -211,6 +220,15 @@ const UIStringsNotTranslate = {
211220
*/
212221
networkHelpExplainer:
213222
'In the Network panel, right-click any request and select "Ask AI assistant". I’ll help break down what’s happening with each request.',
223+
/**
224+
* @description AI assistance for performance traces.
225+
*/
226+
performanceHelp: 'Performance analysis:',
227+
/**
228+
* @description Explanation on how to use AI assistance for performance traces.
229+
*/
230+
performanceHelpExplainer:
231+
'In the Performance panel, run a trace. Then, right-click any function in the timeline and select "Ask AI". I’ll help you analyze its performance impact and suggest improvements.',
214232
};
215233

216234
const str_ = i18n.i18n.registerUIStrings('panels/freestyler/components/FreestylerChatUi.ts', UIStrings);
@@ -1096,8 +1114,14 @@ export class FreestylerChatUi extends HTMLElement {
10961114
${config.devToolsFreestyler?.enabled ? html`
10971115
<p><strong>${lockedString(UIStringsNotTranslate.cssHelp)}</strong> ${lockedString(UIStringsNotTranslate.cssHelpExplainer)}</p>
10981116
` : LitHtml.nothing}
1117+
${config.devToolsAiAssistanceFileAgentDogfood?.enabled ? html`
1118+
<p><strong>${lockedString(UIStringsNotTranslate.fileHelp)}</strong> ${lockedString(UIStringsNotTranslate.fileHelpExplainer)}</p>
1119+
` : LitHtml.nothing}
10991120
${config.devToolsExplainThisResourceDogfood?.enabled ? html`
1100-
<p><strong>${lockedString(UIStringsNotTranslate.networkHelp)}</strong> ${lockedString(UIStringsNotTranslate.networkHelpExplainer)}<p>
1121+
<p><strong>${lockedString(UIStringsNotTranslate.networkHelp)}</strong> ${lockedString(UIStringsNotTranslate.networkHelpExplainer)}</p>
1122+
` : LitHtml.nothing}
1123+
${config.devToolsAiAssistancePerformanceAgentDogfood?.enabled ? html`
1124+
<p><strong>${lockedString(UIStringsNotTranslate.performanceHelp)}</strong> ${lockedString(UIStringsNotTranslate.performanceHelpExplainer)}</p>
11011125
` : LitHtml.nothing}
11021126
</div>
11031127
</section>

0 commit comments

Comments
 (0)