Skip to content

Commit efcc7b9

Browse files
hanselfmu-chromiumDevtools-frontend LUCI CQ
authored andcommitted
Enable the full accessibility tree experiment by default
Based on DevTools + Chrome Accessibility + Blink>DOM team's discussions, we have decidede to turn on the experiment by default first, since there is no critical bugs in this experiment, and we want to collect more user feedback before moving it out of the experimental status. Context: https://docs.google.com/document/d/1wRSaHV88zLoK_acQJD4O4auOkq-9FmpoAN-cjTStYO0/edit?tab=t.0#heading=h.lwx7tsz9x51w Bug: 40808541 Change-Id: I76f548e53bf2a6b5d97911347e247e6b3d2d958b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6233912 Auto-Submit: Changhao Han <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
1 parent 9c4d11c commit efcc7b9

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

front_end/entrypoints/main/MainImpl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,6 +412,7 @@ export class MainImpl {
412412
Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
413413
Root.Runtime.ExperimentName.TIMELINE_THIRD_PARTY_DEPENDENCIES,
414414
Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
415+
Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
415416
...(Root.Runtime.Runtime.queryParam('isChromeForTesting') ? ['protocol-monitor'] : []),
416417
]);
417418

front_end/panels/elements/AccessibilityTreeView.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ describeWithMockConnection('AccessibilityTreeView', () => {
2626

2727
const updatesUiOnEvent = (inScope: boolean) => async () => {
2828
SDK.TargetManager.TargetManager.instance().setScopeTarget(inScope ? target : null);
29-
new Elements.AccessibilityTreeView.AccessibilityTreeView(toggleButoon, treeComponent);
29+
const view = new Elements.AccessibilityTreeView.AccessibilityTreeView(toggleButoon, treeComponent);
30+
view.markAsRoot();
31+
view.show(document.body);
3032

3133
const model = target.model(SDK.AccessibilityModel.AccessibilityModel);
3234
const treeComponentDataSet = sinon.spy(treeComponent, 'data', ['set']);

front_end/panels/elements/AccessibilityTreeView.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,9 @@ export class AccessibilityTreeView extends UI.Widget.VBox implements
147147
treeUpdated({data}: Common.EventTarget
148148
.EventTargetEvent<SDK.AccessibilityModel.EventTypes[SDK.AccessibilityModel.Events.TREE_UPDATED]>):
149149
void {
150+
if (!this.isShowing()) {
151+
return;
152+
}
150153
if (!data.root) {
151154
void this.renderTree();
152155
return;

test/e2e/helpers/elements-helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,6 @@ function veImpressionForAccessibilityPane() {
962962
'Section', 'accessibility-tree',
963963
[
964964
veImpression('Toggle', 'full-accessibility-tree'),
965-
veImpression('TreeItem', undefined, [veImpression('Expand'), veImpression('TreeItem')]),
966965
]),
967966
veImpression('SectionHeader', 'aria-attributes'),
968967
veImpression('Section', 'aria-attributes'),

0 commit comments

Comments
 (0)