[eslint] Support no used for NotTranslated

Bug: none
Change-Id: Ia1dec1d28bbbd63e2e192ff2d8f7556fc743ffd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367218
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: Lightning00Blade

front_end/models/issues_manager/CookieIssue.ts

@@ -26,14 +26,6 @@ const UIStrings = {
    *@description Label for the link for Schemeful Same-Site Issues
    */
   howSchemefulSamesiteWorks: 'How Schemeful Same-Site Works',
-  /**
-   *@description Phrase used to describe the security of a context. Substitued like 'a secure context' or 'a secure origin'.
-   */
-  aSecure: 'a secure',  // eslint-disable-line rulesdir/l10n-no-unused-message
-  /**
-   * @description Phrase used to describe the security of a context. Substitued like 'an insecure context' or 'an insecure origin'.
-   */
-  anInsecure: 'an insecure',  // eslint-disable-line rulesdir/l10n-no-unused-message
   /**
    * @description Label for a link for SameParty Issues. 'Attribute' refers to a cookie attribute.
    */

front_end/panels/ai_assistance/PatchWidget.ts

@@ -44,26 +44,22 @@ const UIStringsNotTranslate = {
    *@description Button text for staging changes to workspace.
    */
   applyToWorkspace: 'Apply to workspace',
-  /*
+  /**
    *@description Button text to change the selected workspace
    */
   change: 'Change',
-  /*
+  /**
    *@description Button text to cancel applying to workspace
    */
   cancel: 'Cancel',
-  /*
+  /**
    *@description Button text to discard the suggested changes and not save them to file system
    */
   discard: 'Discard',
-  /*
+  /**
    *@description Button text to save all the suggested changes to file system
    */
   saveAll: 'Save all',
-  /**
-   *@description Button text while data is being loaded
-   */
-  loading: 'Loading...',
   /**
    *@description Header text after the user saved the changes to the disk.
    */

front_end/panels/ai_assistance/agents/NetworkAgent.ts

@@ -77,18 +77,10 @@ const UIStringsNotTranslate = {
    *@description Prefix text for request URL.
    */
   requestUrl: 'Request URL',
-  /**
-   *@description Title text for request headers.
-   */
-  requestHeaders: 'Request Headers',
   /**
    *@description Title text for request timing details.
    */
   timing: 'Timing',
-  /**
-   *@description Title text for response headers.
-   */
-  responseHeaders: 'Response Headers',
   /**
    *@description Prefix text for response status.
    */

front_end/panels/ai_assistance/components/ChatView.ts

@@ -158,10 +158,6 @@ const UIStringsNotTranslate = {
    *@description Aria label for the check mark icon to be read by screen reader
    */
   completed: 'Completed',
-  /**
-   *@description Aria label for the loading icon to be read by screen reader
-   */
-  inProgress: 'In progress',
   /**
    *@description Aria label for the cancel icon to be read by screen reader
    */
@@ -170,14 +166,6 @@ const UIStringsNotTranslate = {
    *@description Text displayed when the chat input is disabled due to reading past conversation.
    */
   pastConversation: 'You\'re viewing a past conversation.',
-  /**
-   *@description Text displayed for showing change summary view.
-   */
-  changeSummary: 'Changes summary',
-  /**
-   *@description Button text for staging changes to workspace.
-   */
-  applyToWorkspace: 'Apply to workspace',
   /**
    *@description Title for the take screenshot button.
    */
@@ -202,18 +190,6 @@ const UIStringsNotTranslate = {
    *@description Alt text for image when it is not available.
    */
   imageUnavailable: 'Image unavailable',
-  /**
-   *@description Button text to change the selected workspace
-   */
-  change: 'Change',
-  /**
-   *@description Button text while data is being loaded
-   */
-  loading: 'Loading...',
-  /**
-   *@description Label for the selected workspace/folder
-   */
-  selectedFolder: 'Selected folder:'
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('panels/ai_assistance/components/ChatView.ts', UIStrings);

scripts/eslint_rules/lib/l10n-helper.js

@@ -5,7 +5,7 @@
 'use strict';
 
 function isUIStringsIdentifier(node) {
-  return node.type === 'Identifier' && node.name === 'UIStrings';
+  return node.type === 'Identifier' && node.name.startsWith('UIStrings');
 }
 
 function isModuleScope(context, node) {

scripts/eslint_rules/lib/l10n-no-unused-message.js

@@ -13,7 +13,7 @@ const TRACE_INSIGHTS_UI_STRINGS_FILENAME_REGEX = /models\/trace\/insights\/.*\.(
  * Returns true iff the passed expression is of the form `UIStrings.bar`.
  */
 function isStandardUIStringsMemberExpression(expr) {
-  if (expr.object.type !== 'Identifier' || expr.object.name !== 'UIStrings') {
+  if (expr.object.type !== 'Identifier' || !expr.object.name.startsWith('UIStrings')) {
     return false;
   }
 
@@ -31,10 +31,13 @@ module.exports = {
       category: 'Possible Errors',
     },
     fixable: 'code',
-    schema: []  // no options
+    schema: [], // no options
   },
-  create: function(context) {
-    const filename = (context.filename ?? context.getFilename()).replaceAll('\\', '/');
+  create: function (context) {
+    const filename = (context.filename ?? context.getFilename()).replaceAll(
+      '\\',
+      '/',
+    );
     const sourceCode = context.sourceCode ?? context.getSourceCode();
     const declaredUIStringsKeys = new Map();
     const usedUIStringsKeys = new Set();
@@ -46,7 +49,8 @@ module.exports = {
       // some standard formatting. Otherwise we would have to fiddle a lot
       // with tokens and whitespace.
       let lineToRemoveStart = source.getLocFromIndex(property.range[0]).line;
-      const lineToRemoveEnd = source.getLocFromIndex(property.range[1]).line + 1;
+      const lineToRemoveEnd =
+        source.getLocFromIndex(property.range[1]).line + 1;
 
       // Are there comments in front of the property?
       // Move the line we want to remove to the line of the first comment.
@@ -55,8 +59,14 @@ module.exports = {
         lineToRemoveStart = source.getLocFromIndex(comments[0].range[0]).line;
       }
 
-      const removeStart = source.getIndexFromLoc({line: lineToRemoveStart, column: 0});
-      const removeEnd = source.getIndexFromLoc({line: Math.min(lineToRemoveEnd, source.lines.length), column: 0});
+      const removeStart = source.getIndexFromLoc({
+        line: lineToRemoveStart,
+        column: 0,
+      });
+      const removeEnd = source.getIndexFromLoc({
+        line: Math.min(lineToRemoveEnd, source.lines.length),
+        column: 0,
+      });
       return fixer.removeRange([removeStart, removeEnd]);
     }
 
@@ -70,12 +80,17 @@ module.exports = {
           return;
         }
 
-        if (!l10nHelper.isUIStringsVariableDeclarator(context, variableDeclarator)) {
+        if (
+          !l10nHelper.isUIStringsVariableDeclarator(context, variableDeclarator)
+        ) {
           return;
         }
 
         for (const property of variableDeclarator.init.expression.properties) {
-          if (property.type !== 'Property' || property.key.type !== 'Identifier') {
+          if (
+            property.type !== 'Property' ||
+            property.key.type !== 'Identifier'
+          ) {
             continue;
           }
           declaredUIStringsKeys.set(property.key.name, property);
@@ -87,7 +102,7 @@ module.exports = {
         }
         usedUIStringsKeys.add(memberExpression.property.name);
       },
-      'Program:exit': function() {
+      'Program:exit': function () {
         for (const usedKey of usedUIStringsKeys) {
           declaredUIStringsKeys.delete(usedKey);
         }
@@ -101,5 +116,5 @@ module.exports = {
         }
       },
     };
-  }
+  },
 };