[testing] Remove 'describeWithLocale' in favor of 'setupLocaleHooks'

Having various setup*Hooks functions is much more composable then
our current describe* approach.

[email protected]

Bug: 458180550
Change-Id: I0299b36872594bb40249418b3a15924137d3bb58
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7201547
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Auto-Submit: Simon Zünd <[email protected]>

Author: szuend

front_end/core/common/ResourceType.test.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 import * as Platform from '../platform/platform.js';
 
 import * as Common from './common.js';
@@ -25,7 +25,8 @@ describe('ResourceCategory class', () => {
   });
 });
 
-describeWithLocale('ResourceType class', () => {
+describe('ResourceType class', () => {
+  setupLocaleHooks();
   it('is able to be instantiated successfully', () => {
     const testResourceCategory = new ResourceCategory('category name', categoryTestTitle, categoryTestShortTitle);
     const resourceType = new ResourceType('Type Test Name', typeTestTitle, testResourceCategory, true);

front_end/core/i18n/ByteUtilities.test.ts

@@ -2,11 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 
 import * as i18n from './i18n.js';
 
-describeWithLocale('ByteUtilities', () => {
+describe('ByteUtilities', () => {
+  setupLocaleHooks();
   describe('bytesToString', () => {
     it('formats for < 1000 bytes', () => {
       assert.deepEqual(i18n.ByteUtilities.bytesToString(50), '50\xA0B');

front_end/core/i18n/NumberFormatter.test.ts

@@ -2,11 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 
 import * as i18n from './i18n.js';
 
-describeWithLocale('NumberFormatter', () => {
+describe('NumberFormatter', () => {
+  setupLocaleHooks();
   const identity = (locale: string) => locale;
   after(() => {
     // Reset the singleton after the test suite for other tests.

front_end/core/i18n/time-utilities.test.ts

@@ -2,12 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 import type * as Platform from '../platform/platform.js';
 
 import * as i18n from './i18n.js';
 
-describeWithLocale('preciseMillisToString', () => {
+describe('preciseMillisToString', () => {
+  setupLocaleHooks();
   it('formats without a given precision', () => {
     const inputNumber = 7.84;
     const outputString = i18n.TimeUtilities.preciseMillisToString(inputNumber);
@@ -40,7 +41,8 @@ describeWithLocale('preciseMillisToString', () => {
   });
 });
 
-describeWithLocale('formatMicroSecondsTime', () => {
+describe('formatMicroSecondsTime', () => {
+  setupLocaleHooks();
   const {formatMicroSecondsTime} = i18n.TimeUtilities;
 
   it('formats small microsecond values', async () => {
@@ -70,7 +72,8 @@ describeWithLocale('formatMicroSecondsTime', () => {
   });
 });
 
-describeWithLocale('formatMicroSecondsAsSeconds', () => {
+describe('formatMicroSecondsAsSeconds', () => {
+  setupLocaleHooks();
   const {formatMicroSecondsAsSeconds} = i18n.TimeUtilities;
   it('formats smaller second values', async () => {
     const time = 0.03 * 1_000 * 1_000 as Platform.Timing.MicroSeconds;
@@ -83,7 +86,8 @@ describeWithLocale('formatMicroSecondsAsSeconds', () => {
   });
 });
 
-describeWithLocale('millisToString', () => {
+describe('millisToString', () => {
+  setupLocaleHooks();
   it('formats when number is infinite', () => {
     const inputNumber = Infinity;
     const outputString = i18n.TimeUtilities.millisToString(inputNumber);
@@ -149,7 +153,8 @@ describeWithLocale('millisToString', () => {
   });
 });
 
-describeWithLocale('secondsToString', () => {
+describe('secondsToString', () => {
+  setupLocaleHooks();
   it('formats infinte numbers correctly', () => {
     const inputNumber = Infinity;
     const outputString = i18n.TimeUtilities.secondsToString(inputNumber);

front_end/core/platform/NumberUtilities.test.ts

@@ -2,11 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 
 import * as Platform from './platform.js';
 
-describeWithLocale('NumberUtilities', () => {
+describe('NumberUtilities', () => {
+  setupLocaleHooks();
   describe('clamp', () => {
     it('takes the lower bound if the number is smaller', () => {
       assert.strictEqual(5, Platform.NumberUtilities.clamp(1, 5, 10));

front_end/core/sdk/DebuggerModel.test.ts

@@ -6,7 +6,7 @@ import * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import {createTarget} from '../../testing/EnvironmentHelpers.js';
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 import {MockCDPConnection} from '../../testing/MockCDPConnection.js';
 import {setupRuntimeHooks} from '../../testing/RuntimeHelpers.js';
 import {setupSettingsHooks} from '../../testing/SettingsHelpers.js';
@@ -218,7 +218,9 @@ describe('DebuggerModel', () => {
     });
   });
 
-  describeWithLocale('Scope', () => {
+  describe('Scope', () => {
+    setupLocaleHooks();
+
     it('Scope.typeName covers every enum value', async () => {
       const target = createTarget();
       const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel) as SDK.DebuggerModel.DebuggerModel;

front_end/core/sdk/PageResourceLoader.test.ts

@@ -6,7 +6,7 @@ import type * as Protocol from '../../generated/protocol.js';
 import {
   createTarget,
 } from '../../testing/EnvironmentHelpers.js';
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 import {MockCDPConnection} from '../../testing/MockCDPConnection.js';
 import {mockResourceTree} from '../../testing/ResourceTreeHelpers.js';
 import {setupRuntimeHooks} from '../../testing/RuntimeHelpers.js';
@@ -32,7 +32,7 @@ const initiator = {
   initiatorUrl: Platform.DevToolsPath.EmptyUrlString,
 };
 
-describeWithLocale('PageResourceLoader', () => {
+describe('PageResourceLoader', () => {
   const foo1Url = urlString`foo1`;
   const foo2Url = urlString`foo2`;
   const foo3Url = urlString`foo3`;
@@ -51,6 +51,7 @@ describeWithLocale('PageResourceLoader', () => {
     loads.length = 0;
   });
 
+  setupLocaleHooks();
   setupSettingsHooks();
 
   it('registers extension loads', async () => {
@@ -280,12 +281,13 @@ describe('PageResourceLoader', () => {
   });
 });
 
-describeWithLocale('PageResourceLoader', () => {
+describe('PageResourceLoader', () => {
   const initiatorUrl = urlString`htp://example.com`;
   const foo1Url = urlString`foo1`;
   const foo2Url = urlString`foo2`;
   const foo3Url = urlString`foo3`;
 
+  setupLocaleHooks();
   setupSettingsHooks();
   setupRuntimeHooks();
 

front_end/core/sdk/ServerTiming.test.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {describeWithLocale} from '../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
 
 import * as SDK from './sdk.js';
 
@@ -15,7 +15,8 @@ describe('ServerTiming', () => {
   });
 });
 
-describeWithLocale('SDK.ServerTiming.ServerTiming.createFromHeaderValue', () => {
+describe('SDK.ServerTiming.ServerTiming.createFromHeaderValue', () => {
+  setupLocaleHooks();
   it('parses headers correctly', () => {
     // A real-world-like example with some edge cases.
     const actual = SDK.ServerTiming.ServerTiming.createFromHeaderValue(

front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.test.ts

@@ -3,15 +3,16 @@
 // found in the LICENSE file.
 
 import {getFirstOrError, getInsightOrError} from '../../../testing/InsightHelpers.js';
-import {describeWithLocale} from '../../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../../testing/LocaleHelpers.js';
 import {setupRuntimeHooks} from '../../../testing/RuntimeHelpers.js';
 import {setupSettingsHooks} from '../../../testing/SettingsHelpers.js';
 import {SnapshotTester} from '../../../testing/SnapshotTester.js';
 import {TraceLoader} from '../../../testing/TraceLoader.js';
 import type * as Trace from '../../trace/trace.js';
 import {AIContext, PerformanceInsightFormatter} from '../ai_assistance.js';
 
-describeWithLocale('PerformanceInsightFormatter', function() {
+describe('PerformanceInsightFormatter', function() {
+  setupLocaleHooks();
   const snapshotTester = new SnapshotTester(this, import.meta);
 
   setupRuntimeHooks();

front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.test.ts

@@ -4,7 +4,7 @@
 
 import * as CrUXManager from '../../../models/crux-manager/crux-manager.js';
 import * as Trace from '../../../models/trace/trace.js';
-import {describeWithLocale} from '../../../testing/LocaleHelpers.js';
+import {setupLocaleHooks} from '../../../testing/LocaleHelpers.js';
 import {setupRuntimeHooks} from '../../../testing/RuntimeHelpers.js';
 import {setupSettingsHooks} from '../../../testing/SettingsHelpers.js';
 import {SnapshotTester} from '../../../testing/SnapshotTester.js';
@@ -22,7 +22,8 @@ async function createFormatter(context: Mocha.Context|Mocha.Suite|null, name: st
   return {formatter, parsedTrace};
 }
 
-describeWithLocale('PerformanceTraceFormatter', function() {
+describe('PerformanceTraceFormatter', function() {
+  setupLocaleHooks();
   const snapshotTester = new SnapshotTester(this, import.meta);
 
   setupRuntimeHooks();