Skip to content

Commit f2ba871

Browse files
Adam RaineDevtools-frontend LUCI CQ
authored andcommitted
Revert "[NetworkRequestDetails] Fix initiator row styling"
This reverts commit 6333612. Reason for revert: Obsolete with https://crrev.com/6404821 Original change's description: > [NetworkRequestDetails] Fix initiator row styling > > The initiator row was separated because the link can be very long. This > CL groups the initiator with everything else but applies `ellipis` to > contain the size. > > Bug: 406864076 > Change-Id: I7088b64f7b3154e457a46f515b35908102c7cd5e > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404927 > Auto-Submit: Adam Raine <[email protected]> > Commit-Queue: Adam Raine <[email protected]> > Reviewed-by: Paul Irish <[email protected]> Bug: 406864076 Change-Id: I9fa423e170455f4235bb5feb7c77a35691f6b3a7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410873 Commit-Queue: Adam Raine <[email protected]> Reviewed-by: Paul Irish <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
1 parent 4eac8f8 commit f2ba871

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

front_end/panels/timeline/components/NetworkRequestDetails.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ describeWithMockConnection('NetworkRequestDetails', () => {
5757
},
5858
{title: 'From cache', value: 'Yes'},
5959
{title: '3rd party', value: 'GitHub'},
60+
{title: undefined, value: durationInnerText},
6061
{
6162
title: 'Initiated by',
6263
value: 'chromedevtools.github.io/performance-stories/lcp-web-font/index.html',
6364
},
64-
{title: undefined, value: durationInnerText},
6565
],
6666
);
6767
});

front_end/panels/timeline/components/NetworkRequestDetails.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,6 @@ export class NetworkRequestDetails extends HTMLElement {
396396
${this.#renderBlockingRow()}
397397
${this.#renderFromCache()}
398398
${this.#renderThirdPartyEntity()}
399-
${this.#renderInitiatedBy()}
400399
</div>
401400
<div class="column-divider"></div>
402401
<div class="network-request-details-col">
@@ -406,8 +405,9 @@ export class NetworkRequestDetails extends HTMLElement {
406405
</div>
407406
${this.#renderServerTimings()}
408407
</div>
408+
${this.#renderInitiatedBy()}
409409
</div>
410-
`;
410+
`; // The last items are outside the 2 column layout because InitiatedBy can be very wide
411411
// clang-format on
412412
Lit.render(output, this.#shadow, {host: this});
413413
}

front_end/panels/timeline/components/networkRequestDetails.css

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,21 +70,13 @@
7070
padding-right: 10px;
7171
display: inline-block;
7272
vertical-align: top;
73-
white-space: nowrap;
74-
min-width: min-content;
7573
}
7674

7775
.value {
7876
display: inline-block;
7977
user-select: text;
8078
text-overflow: ellipsis;
8179
overflow: hidden;
82-
83-
.text-button {
84-
text-overflow: ellipsis;
85-
max-width: 100%;
86-
overflow: hidden;
87-
}
8880
}
8981

9082
.devtools-link,

0 commit comments

Comments
 (0)