Skip to content

Commit f3e9646

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
Fix button margins in search bars
This CL makes sure that the margins for the find and replace search bars are equally big. Before: https://i.imgur.com/Fh9UXwq.png After: https://i.imgur.com/dHrADLD.png Bug: none Change-Id: I930f31014fc02cd1959a415cf2aaea015605079e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5969659 Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]>
1 parent 2f8db18 commit f3e9646

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

front_end/panels/search/searchView.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@
5353
height: var(--sys-size-8);
5454
margin-right: var(--sys-size-3);
5555
}
56+
57+
& > devtools-button:last-child {
58+
margin-right: var(--sys-size-4);
59+
}
5660
}
5761

5862
.search-toolbar-input {

front_end/ui/legacy/Toolbar.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -923,6 +923,7 @@ export class ToolbarFilter extends ToolbarInput {
923923

924924
const filterIcon = IconButton.Icon.create('filter');
925925
this.element.prepend(filterIcon);
926+
this.element.classList.add('toolbar-filter');
926927
}
927928
}
928929

front_end/ui/legacy/searchableView.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@
107107
& > devtools-button {
108108
width: var(--sys-size-11);
109109
justify-content: center;
110-
}
111-
112-
& devtools-button:last-child {
113110
margin-right: var(--sys-size-4);
114111
}
115112
}
@@ -141,6 +138,10 @@
141138
display: inline-flex;
142139
grid-row: 1/2;
143140
grid-column: 2/3;
141+
142+
& > devtools-button:last-child {
143+
margin-right: var(--sys-size-4);
144+
}
144145
}
145146

146147
.toolbar-search-buttons {

front_end/ui/legacy/toolbar.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,6 +416,10 @@ select.toolbar-item:focus-visible > * {
416416
}
417417
}
418418

419+
.toolbar-filter .toolbar-input-clear-button {
420+
margin-right: var(--sys-size-4);
421+
}
422+
419423
.toolbar-input-empty .toolbar-input-clear-button {
420424
display: none;
421425
}

0 commit comments

Comments
 (0)