[uikit] Allow named imports for ui kit

This updates the es-modules-import to allow for named imports when
it comes to the ui kit.

Bug: 464124289
Change-Id: Ie62913cd573dfad85855a24d96eb461f626c1de6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7204216
Commit-Queue: Simon Zünd <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>

Author: ktran

scripts/eslint_rules/lib/es-modules-import.ts

@@ -343,6 +343,13 @@ export default createRule<[], MessageIds>({
           return;
         }
 
+        const currentFileDirectory = path.dirname(filename);
+        const resolvedAbsoluteImportPath = path.resolve(currentFileDirectory, importPath);
+        // We explicitly allow destructuring imports from 'front_end/ui/kit/kit.js'.
+        if (resolvedAbsoluteImportPath.endsWith(path.join('front_end', 'ui', 'kit', 'kit.js'))) {
+          return;
+        }
+
         if (importPathForErrorMessage.endsWith('platform/platform.js') &&
             nodeSpecifiersSpecialImportsOnly(node.specifiers)) {
           /* We allow direct importing of the ls and assertNotNull utility as it's so frequently used. */

scripts/eslint_rules/tests/es-modules-import.test.ts

@@ -158,6 +158,11 @@ new RuleTester().run('es-modules-import', rule, {
       code: 'import { type Exporting } from \'../namespace/Exporting.js\';',
       filename: 'front_end/common/Importing.js',
     },
+    // Allow ui kit module named imports
+    {
+      code: 'import { Icon } from \'../ui/kit/kit.js\';',
+      filename: 'front_end/common/Importing.js',
+    },
   ],
 
   invalid: [