Skip to content

Commit f763f31

Browse files
committed
Deflake two other tests
Bug: 361078921 Change-Id: If4fd0677edcdc46c4f92d411c49e80932e55d62d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6257648 Auto-Submit: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 04b580f commit f763f31

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

test/e2e/extensions/debugger-language-plugins_test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {
1111
$$,
1212
assertNotNullOrUndefined,
1313
click,
14+
drainFrontendTaskQueue,
1415
getAllTextContents,
1516
getBrowserAndPages,
1617
getDevToolsFrontendHostname,
@@ -493,6 +494,8 @@ describe('The Debugger Language Plugins', () => {
493494
await goToResource('sources/wasm/unreachable.html');
494495
await addDummyExternalDWARFInfo('unreachable.wasm');
495496
await waitFor(RESUME_BUTTON);
497+
// TODO: it should actually wait for rendering to finish.
498+
await drainFrontendTaskQueue();
496499

497500
// Call stack shows inline function names and source locations.
498501
const funcNames = await getCallFrameNames();

test/e2e/helpers/changes-helpers.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import {$$, getBrowserAndPages, goToResource, waitFor, waitForFunction} from '../../shared/helper.js';
5+
import {
6+
$$,
7+
drainFrontendTaskQueue,
8+
getBrowserAndPages,
9+
goToResource,
10+
waitFor,
11+
waitForFunction
12+
} from '../../shared/helper.js';
613

714
import {openCommandMenu} from './quick_open-helpers.js';
815
import {
@@ -21,7 +28,11 @@ export async function openChangesPanelAndNavigateTo(testName: string) {
2128

2229
await openCommandMenu();
2330
await frontend.keyboard.type('changes');
31+
// TODO: it should actually wait for rendering to finish.
32+
await drainFrontendTaskQueue();
2433
await frontend.keyboard.press('Enter');
34+
// TODO: it should actually wait for rendering to finish.
35+
await drainFrontendTaskQueue();
2536

2637
await waitFor(COPY_CHANGES_SELECTOR);
2738
await expectVeEvents([

0 commit comments

Comments
 (0)