Do not append console timings with extension data in timings track

They are appended in their own track and having them in the timings
track only adds noise.

Took the chance to update a trace file to have it include extension console timestamps, to cover this behavior with the existing tests.

Bug: 390155157
Change-Id: I497b25eb42a59cd4b666144d40c1294ba6fd5002
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6417102
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>

Author: and-oli

front_end/panels/timeline/TimelineFlameChartDataProvider.test.ts

@@ -78,6 +78,7 @@ describeWithEnvironment('TimelineFlameChartDataProvider', function() {
           'A track group — Custom track',
           'Another Extension Track',
           'An Extension Track — Custom track',
+          'TimeStamp track — Custom track',
           'Main — http://localhost:3000/',
           'Thread pool',
           'Thread pool worker 1',

front_end/panels/timeline/TimingsTrackAppender.ts

@@ -75,7 +75,8 @@ export class TimingsTrackAppender implements TrackAppender {
         m => !Trace.Handlers.ModelHandlers.ExtensionTraceData.extensionDataInPerformanceTiming(m));
     const performanceMeasures = this.#parsedTrace.UserTimings.performanceMeasures.filter(
         m => !Trace.Handlers.ModelHandlers.ExtensionTraceData.extensionDataInPerformanceTiming(m));
-    const timestampEvents = this.#parsedTrace.UserTimings.timestampEvents;
+    const timestampEvents = this.#parsedTrace.UserTimings.timestampEvents.filter(
+        timeStamp => !Trace.Handlers.ModelHandlers.ExtensionTraceData.extensionDataInConsoleTimeStamp(timeStamp));
     const consoleTimings = this.#parsedTrace.UserTimings.consoleTimings;
     if (extensionMarkersAreEmpty && performanceMarks.length === 0 && performanceMeasures.length === 0 &&
         timestampEvents.length === 0 && consoleTimings.length === 0) {

front_end/panels/timeline/fixtures/traces/extension-tracks-and-marks.json.gz

@@ -50,7 +50,7 @@ describeWithEnvironment('ExtensionTrackAppender', function() {
 
   describe('appendTrackAtLevel', function() {
     it('creates flamechart groups for the Extension tracks properly', function() {
-      assert.lengthOf(flameChartData.groups, 3);
+      assert.lengthOf(flameChartData.groups, 4);
       assert.strictEqual(flameChartData.groups[0].name, 'A track group — Custom track');
       assert.strictEqual(flameChartData.groups[0].startLevel, 0);
       assert.strictEqual(flameChartData.groups[0].style.nestingLevel, 0);