Skip to content

Commit f913cc6

Browse files
bmeurerDevtools-frontend LUCI CQ
authored andcommitted
[cleanup] Remove obsolete DevTools.ManifestSectionSelected histogram.
We get much more precise data from Visual Logging here these days. Fixed: 379690922 Change-Id: I969319c5d8b9264824e35552bdd8cde82a60d381 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038335 Auto-Submit: Benedikt Meurer <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
1 parent 15caac2 commit f913cc6

File tree

4 files changed

+0
-10
lines changed

4 files changed

+0
-10
lines changed

front_end/core/host/InspectorFrontendHostAPI.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ export const enum EnumeratedHistogram {
479479
SourcesPanelFileOpened = 'DevTools.SourcesPanelFileOpened',
480480
NetworkPanelResponsePreviewOpened = 'DevTools.NetworkPanelResponsePreviewOpened',
481481
StyleTextCopied = 'DevTools.StyleTextCopied',
482-
ManifestSectionSelected = 'DevTools.ManifestSectionSelected',
483482
CSSHintShown = 'DevTools.CSSHintShown',
484483
LighthouseModeRun = 'DevTools.LighthouseModeRun',
485484
LighthouseCategoryUsed = 'DevTools.LighthouseCategoryUsed',

front_end/core/host/UserMetrics.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -290,13 +290,6 @@ export class UserMetrics {
290290
EnumeratedHistogram.StyleTextCopied, value, StyleTextCopied.MAX_VALUE);
291291
}
292292

293-
manifestSectionSelected(sectionTitle: string): void {
294-
const code =
295-
ManifestSectionCodes[sectionTitle as keyof typeof ManifestSectionCodes] || ManifestSectionCodes.OtherSection;
296-
InspectorFrontendHostInstance.recordEnumeratedHistogram(
297-
EnumeratedHistogram.ManifestSectionSelected, code, ManifestSectionCodes.MAX_VALUE);
298-
}
299-
300293
cssHintShown(type: CSSHintType): void {
301294
InspectorFrontendHostInstance.recordEnumeratedHistogram(
302295
EnumeratedHistogram.CSSHintShown, type, CSSHintType.MAX_VALUE);

front_end/devtools_compatibility.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,6 @@ const EnumeratedHistogram = {
423423
Language: 'DevTools.Language',
424424
LighthouseModeRun: 'DevTools.LighthouseModeRun',
425425
LighthouseCategoryUsed: 'DevTools.LighthouseCategoryUsed',
426-
ManifestSectionSelected: 'DevTools.ManifestSectionSelected',
427426
PanelShown: 'DevTools.PanelShown',
428427
PanelShownInLocation: 'DevTools.PanelShownInLocation',
429428
RecordingAssertion: 'DevTools.RecordingAssertion',

front_end/panels/application/ApplicationPanelSidebar.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1185,7 +1185,6 @@ export class ManifestChildTreeElement extends ApplicationPanelTreeElement {
11851185
(this.parent as AppManifestTreeElement)?.showManifestView();
11861186
this.#sectionElement.scrollIntoView();
11871187
UI.ARIAUtils.alert(i18nString(UIStrings.onInvokeAlert, {PH1: this.listItemElement.title}));
1188-
Host.userMetrics.manifestSectionSelected(this.listItemElement.title);
11891188
}
11901189
// direct focus to the corresponding element
11911190
onInvokeElementKeydown(event: KeyboardEvent): void {

0 commit comments

Comments
 (0)