Skip to content

Commit f976d00

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
Revert "Re-enable elements/styles-disable-inherited_test.ts"
This reverts commit 5a62b4b. Reason for revert: still flaky in CI Bug: 440335793 Original change's description: > Re-enable elements/styles-disable-inherited_test.ts > > Bug: 440335793 > Change-Id: I05908c930fe828e75d5c4c10f419bee4ac3a4a08 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6874622 > Reviewed-by: Simon Zünd <[email protected]> > Commit-Queue: Alex Rudenko <[email protected]> Bug: 440335793 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I1a530ecb59be0414d840a827ed2d4d1e83bd024d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6883610 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Alex Rudenko <[email protected]>
1 parent e044288 commit f976d00

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

front_end/ui/visual_logging/Debugging.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -767,16 +767,13 @@ function formatInteraction(e: TestLogEntry): string {
767767
return '';
768768
}
769769

770-
function formatVeEvents(events: Array<TestLogEntry|IntuitiveLogEntry|AdHocAnalysisLogEntry>): string {
770+
function formatVeEvents(events: TestLogEntry[]): string {
771771
return events
772772
.map(e => {
773773
if ('interaction' in e) {
774774
return formatInteraction(e);
775775
}
776-
if ('impressions' in e) {
777-
return formatImpressions(e.impressions);
778-
}
779-
return JSON.stringify(e);
776+
return formatImpressions(e.impressions);
780777
})
781778
.join('\n');
782779
}
@@ -796,7 +793,7 @@ export async function expectVeEvents(expectedEvents: TestLogEntry[]): Promise<vo
796793
pendingEventExpectation.fail(new Error(
797794
'\nMissing VE Events:\n' + formatVeEvents(pendingEventExpectation.missingEvents) +
798795
'\nUnmatched VE Events:\n' + formatVeEvents(pendingEventExpectation.unmatchingEvents) + '\nAll events:\n' +
799-
formatVeEvents(veDebugEventsLog)));
796+
JSON.stringify(veDebugEventsLog, null, 2)));
800797
}
801798
}, EVENT_EXPECTATION_TIMEOUT);
802799

test/e2e/helpers/elements-helpers.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,10 +1040,8 @@ export const toggleClassesPaneCheckbox =
10401040

10411041
export const uncheckStylesPaneCheckbox =
10421042
async (checkboxLabel: string, devToolsPage = getBrowserAndPagesWrappers().devToolsPage) => {
1043+
console.error('uncheckStylesPaneCheckbox', checkboxLabel);
10431044
const initialValue = await getContentOfSelectedNode(devToolsPage);
1044-
await devToolsPage.hover(`.enabled-button[aria-label="${checkboxLabel}"]`);
1045-
// To detect an impression, we need to hover for some time.
1046-
await new Promise(resolve => setTimeout(resolve, 250));
10471045
await devToolsPage.click(`.enabled-button[aria-label="${checkboxLabel}"]`);
10481046
await waitForSelectedNodeChange(initialValue, devToolsPage);
10491047
await expectVeEvents(

test/e2e_non_hosted/elements/styles-disable-inherited_test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ import {
1010
} from '../../e2e/helpers/elements-helpers.js';
1111

1212
describe('The Elements tab', function() {
13-
it(
14-
'does not break further style inspection if inherited style property was disabled',
13+
// Skip since this test seems to be consistently failing on mac and linux.
14+
it.skip(
15+
'[crbug.com/440335793] does not break further style inspection if inherited style property was disabled',
1516
async ({devToolsPage, inspectedPage}) => {
1617
await inspectedPage.goToResource('elements/styles-disable-inherited.html');
1718
await expandSelectedNodeRecursively(devToolsPage);

0 commit comments

Comments
 (0)