[RPP] Double trace record buffer to 400MB

Bug: 409086863
Change-Id: I830675c70abec47cd9b85261da9a30a8f1806ac5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6443722
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>

Author: Connor Clark

front_end/models/trace/TracingManager.test.ts

@@ -42,7 +42,7 @@ describeWithMockConnection('TracingManager', () => {
     const client = new FakeClient();
     const bufferUsageSpy = sinon.spy(client, 'tracingBufferUsage');
 
-    await manager.start(client, 'devtools-timeline', 'options');
+    await manager.start(client, 'devtools-timeline');
     manager.bufferUsage(10);
     assert.isTrue(bufferUsageSpy.calledWith(10));
   });
@@ -54,7 +54,7 @@ describeWithMockConnection('TracingManager', () => {
     const eventsRetrievalProgressSpy = sinon.spy(client, 'eventsRetrievalProgress');
     const eventsCollectedSpy = sinon.spy(client, 'traceEventsCollected');
 
-    await manager.start(client, 'devtools-timeline', 'options');
+    await manager.start(client, 'devtools-timeline');
     manager.bufferUsage(0, 0);
 
     manager.eventsCollected(fakeEvents);
@@ -67,7 +67,7 @@ describeWithMockConnection('TracingManager', () => {
     const manager = new Trace.TracingManager.TracingManager(target);
     const client = new FakeClient();
     const tracingCompleteSpy = sinon.spy(client, 'tracingComplete');
-    await manager.start(client, 'devtools-timeline', 'options');
+    await manager.start(client, 'devtools-timeline');
     manager.bufferUsage(0, 0);
     manager.eventsCollected(fakeEvents);
     manager.tracingComplete();
@@ -78,11 +78,11 @@ describeWithMockConnection('TracingManager', () => {
     const target = createTarget();
     const manager = new Trace.TracingManager.TracingManager(target);
     const client = new FakeClient();
-    await manager.start(client, 'devtools-timeline', 'options');
+    await manager.start(client, 'devtools-timeline');
     // The assert.throws() helper does not work with async/await, hence the manual try catch
     let didThrow = false;
     try {
-      await manager.start(client, 'devtools-timeline', 'options');
+      await manager.start(client, 'devtools-timeline');
     } catch (error) {
       didThrow = true;
       assert.strictEqual(error.message, 'Tracing is already started');

front_end/models/trace/TracingManager.ts

@@ -67,20 +67,20 @@ export class TracingManager extends SDK.SDKModel.SDKModel<void> {
     this.#finishing = false;
   }
 
-  // TODO(petermarshall): Use the traceConfig argument instead of deprecated
-  // categories + options.
-  async start(client: TracingManagerClient, categoryFilter: string, options: string):
-      Promise<Protocol.ProtocolResponseWithError> {
+  async start(client: TracingManagerClient, categoryFilter: string): Promise<Protocol.ProtocolResponseWithError> {
     if (this.#activeClient) {
       throw new Error('Tracing is already started');
     }
     const bufferUsageReportingIntervalMs = 500;
     this.#activeClient = client;
     const args = {
       bufferUsageReportingInterval: bufferUsageReportingIntervalMs,
-      categories: categoryFilter,
-      options,
       transferMode: Protocol.Tracing.StartRequestTransferMode.ReportEvents,
+      traceConfig: {
+        recordMode: Protocol.Tracing.TraceConfigRecordMode.RecordUntilFull,
+        traceBufferSizeInKb: 400 * 1000,
+        includedCategories: categoryFilter.split(','),
+      },
     };
     const response = await this.#tracingAgent.invoke_start(args);
     if (response.getError()) {

front_end/panels/network/NetworkPanel.ts

@@ -957,7 +957,7 @@ export class FilmStripRecorder implements Trace.TracingManager.TracingManagerCli
 
     this.tracingManager = tracingManager;
     this.resourceTreeModel = this.tracingManager.target().model(SDK.ResourceTreeModel.ResourceTreeModel);
-    void this.tracingManager.start(this, '-*,disabled-by-default-devtools.screenshot', '');
+    void this.tracingManager.start(this, '-*,disabled-by-default-devtools.screenshot');
 
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.FilmStripStartedRecording);
   }

front_end/panels/timeline/TimelineController.ts

@@ -236,7 +236,7 @@ export class TimelineController implements Trace.TracingManager.TracingManagerCl
     // all the functions data.
     await SDK.TargetManager.TargetManager.instance().suspendAllTargets('performance-timeline');
     this.tracingCompletePromise = Promise.withResolvers();
-    const response = await this.tracingManager.start(this, categories, '');
+    const response = await this.tracingManager.start(this, categories);
     await this.warmupJsProfiler();
     Extensions.ExtensionServer.ExtensionServer.instance().profilingStarted();
     return response;

front_end/services/tracing/PerformanceTracing.ts

@@ -45,7 +45,7 @@ export class PerformanceTracing implements Trace.TracingManager.TracingManagerCl
       'v8',
     ].join(',');
 
-    const started = await this.#tracingManager.start(this, categories, '');
+    const started = await this.#tracingManager.start(this, categories);
 
     if (!started) {
       throw new Error('Unable to start tracing.');