Skip to content

Commit f9daaf8

Browse files
Liviu RauDevtools-frontend LUCI CQ
authored andcommitted
Migrate test/e2e/issues/report-only_test.ts
Fixed: 416405432 Change-Id: Idb57a1218dc8660ea3c05a41503652d04c8720d5 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6725115 Commit-Queue: Liviu Rau <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Auto-Submit: Liviu Rau <[email protected]> Reviewed-by: Alex Rudenko <[email protected]>
1 parent 6310e78 commit f9daaf8

File tree

5 files changed

+25
-24
lines changed

5 files changed

+25
-24
lines changed

test/e2e/helpers/issues-helpers.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,10 @@ export async function getIssueHeaderByTitle(
143143
return undefined;
144144
}
145145

146-
export async function assertStatus(status: 'blocked'|'report-only') {
146+
export async function assertStatus(
147+
status: 'blocked'|'report-only', devToolsPage: DevToolsPage = getBrowserAndPagesWrappers().devToolsPage) {
147148
const classStatus = status === 'blocked' ? BLOCKED_STATUS : REPORT_ONLY_STATUS;
148-
const issueMessageElement = await waitFor(classStatus);
149+
const issueMessageElement = await devToolsPage.waitFor(classStatus);
149150
const selectedIssueMessage = await issueMessageElement.evaluate(node => node.textContent);
150151
assert.strictEqual(selectedIssueMessage, status);
151152
}

test/e2e/issues/BUILD.gn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ node_ts_library("issues") {
1111
"low-text-contrast-issues_test.ts",
1212
"partitioning-blob-url-issues_test.ts",
1313
"quota-issues_test.ts",
14-
"report-only_test.ts",
1514
"sab-issues_test.ts",
1615
"select-element-accessibility-issues_test.ts",
1716
"user-reidentification-issues_test.ts",

test/e2e/issues/report-only_test.ts

Lines changed: 0 additions & 21 deletions
This file was deleted.

test/e2e_non_hosted/issues/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ ts_e2e_library("issues") {
2323
"issue-view-reparent_test.ts",
2424
"privacy-sandbox-extensions-api_test.ts",
2525
"quirks-mode-issues_test.ts",
26+
"report-only_test.ts",
2627
]
2728
deps = [
2829
"../../e2e/helpers",
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
// Copyright 2020 The Chromium Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import {assertStatus, expandIssue, navigateToIssuesTab} from '../../e2e/helpers/issues-helpers.js';
6+
7+
describe('The Issues tab report-only issues', () => {
8+
it('should report the violation as blocked', async ({devToolsPage, inspectedPage}) => {
9+
await inspectedPage.goToResource('elements/element-reveal-inline-issue.html');
10+
await navigateToIssuesTab(devToolsPage);
11+
await expandIssue(devToolsPage);
12+
await assertStatus('blocked', devToolsPage);
13+
});
14+
15+
it('should report the violation as report-only', async ({devToolsPage, inspectedPage}) => {
16+
await inspectedPage.goToResource('network/csp-report-only.rawresponse');
17+
await navigateToIssuesTab(devToolsPage);
18+
await expandIssue(devToolsPage);
19+
await assertStatus('report-only', devToolsPage);
20+
});
21+
});

0 commit comments

Comments
 (0)