RPP: remove experimental insights experiment

We are not actively building out lots of new insights right now, and if
we were we should enable them with a Chromium feature flag which is the
latest guidance, so we can remove this experiment.

[email protected]

Bug: none
Change-Id: Ifbdafe7af44410074be30b5b2265d3b2ab2b58c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6788073
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>

Author: jackfranklin

front_end/core/host/UserMetrics.ts

@@ -826,7 +826,6 @@ export enum DevtoolsExperiments {
   'timeline-enhanced-traces' = 90,
   'timeline-compiled-sources' = 91,
   'timeline-debug-mode' = 93,
-  'timeline-experimental-insights' = 102,
   'vertical-drawer' = 107,
   /* eslint-enable @typescript-eslint/naming-convention */
 

front_end/core/root/Runtime.ts

@@ -322,7 +322,6 @@ export const enum ExperimentName {
   TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
   TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',
   TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
-  TIMELINE_EXPERIMENTAL_INSIGHTS = 'timeline-experimental-insights',
   VERTICAL_DRAWER = 'vertical-drawer',
   // Adding or removing an entry from this enum?
   // You will need to update:

front_end/entrypoints/main/MainImpl.ts

@@ -360,11 +360,6 @@ export class MainImpl {
         'Performance panel: show postMessage dispatch and handling flows',
     );
 
-    Root.Runtime.experiments.register(
-        Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
-        'Performance panel: enable experimental performance insights',
-    );
-
     Root.Runtime.experiments.enableExperimentsByDefault([
       Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
       Root.Runtime.ExperimentName.HIGHLIGHT_ERRORS_ELEMENTS_PANEL,

front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Root from '../../../core/root/root.js';
 import * as Trace from '../../../models/trace/trace.js';
 import {getCleanTextContentFromElements, renderElementIntoDOM} from '../../../testing/DOMHelpers.js';
 import {describeWithEnvironment} from '../../../testing/EnvironmentHelpers.js';
@@ -126,51 +125,6 @@ describeWithEnvironment('SidebarSingleInsightSet', () => {
     ]);
   });
 
-  it('renders experimental insights if the experiment is turned on', async function() {
-    const {parsedTrace, metadata, insights} = await TraceLoader.traceEngine(this, 'font-display.json.gz');
-    const component = new Components.SidebarSingleInsightSet.SidebarSingleInsightSet();
-    Root.Runtime.experiments.enableForTest(
-        Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
-    );
-    renderElementIntoDOM(component);
-    const firstNavigation = parsedTrace.Meta.mainFrameNavigations.at(0)?.args.data?.navigationId;
-    assert.isOk(firstNavigation);
-    component.data = {
-      insights,
-      insightSetKey: firstNavigation,
-      activeCategory: Trace.Insights.Types.InsightCategory.ALL,
-      activeInsight: null,
-      parsedTrace,
-      traceMetadata: metadata,
-    };
-    await RenderCoordinator.done();
-    const userVisibleTitles = getUserVisibleInsights(component);
-    assert.deepEqual(userVisibleTitles, [
-      'LCP breakdown',
-      'Layout shift culprits',
-      'Network dependency tree',
-      'Improve image delivery',
-      'Font display',
-      '3rd parties',
-      'Use efficient cache lifetimes',
-    ]);
-
-    const passedInsightTitles = getPassedInsights(component);
-    assert.deepEqual(passedInsightTitles, [
-      'INP breakdown',
-      'LCP request discovery',
-      'Render blocking requests',
-      'Document request latency',
-      'Optimize viewport for mobile',
-      'Optimize DOM size',
-      'Duplicated JavaScript',
-      'CSS Selector costs',
-      'Forced reflow',
-      'Modern HTTP',
-      'Legacy JavaScript',
-    ]);
-  });
-
   it('will render the active insight fully', async function() {
     const {insights, metadata, parsedTrace} = await TraceLoader.traceEngine(this, 'web-dev-with-commit.json.gz');
 

front_end/panels/timeline/components/SidebarSingleInsightSet.ts

@@ -5,7 +5,6 @@
 
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
-import * as Root from '../../../core/root/root.js';
 import * as CrUXManager from '../../../models/crux-manager/crux-manager.js';
 import * as Trace from '../../../models/trace/trace.js';
 import * as Buttons from '../../../ui/components/buttons/buttons.js';
@@ -82,13 +81,6 @@ export interface SidebarSingleInsightSetData {
   traceMetadata: Trace.Types.File.MetaData|null;
 }
 
-/**
- * These are WIP Insights that are only shown if the user has turned on the
- * "enable experimental performance insights" experiment. This is used to enable
- * us to ship incrementally without turning insights on by default for all
- * users. */
-const EXPERIMENTAL_INSIGHTS: ReadonlySet<string> = new Set([]);
-
 type InsightNameToComponentMapping =
     Record<string, typeof Insights.BaseInsightComponent.BaseInsightComponent<Trace.Insights.Types.InsightModel>>;
 
@@ -379,10 +371,6 @@ export class SidebarSingleInsightSet extends HTMLElement {
       insightSetKey: string,
       activeCategory: Trace.Insights.Types.InsightCategory,
       ): {shownInsights: CategorizedInsightData[], passedInsights: CategorizedInsightData[]} {
-    const includeExperimental = Root.Runtime.experiments.isEnabled(
-        Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
-    );
-
     const insightSet = insightSets?.get(insightSetKey);
     if (!insightSet) {
       return {shownInsights: [], passedInsights: []};
@@ -397,10 +385,6 @@ export class SidebarSingleInsightSet extends HTMLElement {
         continue;
       }
 
-      if (!includeExperimental && EXPERIMENTAL_INSIGHTS.has(name)) {
-        continue;
-      }
-
       if (!model || !shouldRenderForCategory({activeCategory, insightCategory: model.category})) {
         continue;
       }

front_end/testing/EnvironmentHelpers.ts

@@ -127,7 +127,6 @@ const REGISTERED_EXPERIMENTS = [
   Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE,
   Root.Runtime.ExperimentName.TIMELINE_SHOW_POST_MESSAGE_EVENTS,
   Root.Runtime.ExperimentName.TIMELINE_ENHANCED_TRACES,
-  Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
   Root.Runtime.ExperimentName.VERTICAL_DRAWER,
 ];