Remove UMA for Network resource type filter

Bug: 381876767
Change-Id: I3078e15bd3e2e97aeb14dbbb8e03df937e117bbf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070371
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>

Author: Kateryna Prokopenko

front_end/core/host/InspectorFrontendHostAPI.ts

@@ -486,9 +486,5 @@ export const enum EnumeratedHistogram {
   SwatchActivated = 'DevTools.SwatchActivated',
   AnimationPlaybackRateChanged = 'DevTools.AnimationPlaybackRateChanged',
   AnimationPointDragged = 'DevTools.AnimationPointDragged',
-  LegacyResourceTypeFilterNumberOfSelectedChanged = 'DevTools.LegacyResourceTypeFilterNumberOfSelectedChanged',
-  LegacyResourceTypeFilterItemSelected = 'DevTools.LegacyResourceTypeFilterItemSelected',
-  ResourceTypeFilterNumberOfSelectedChanged = 'DevTools.ResourceTypeFilterNumberOfSelectedChanged',
-  ResourceTypeFilterItemSelected = 'DevTools.ResourceTypeFilterItemSelected',
   /* eslint-disable @typescript-eslint/naming-convention -- Shadows a legacy enum */
 }

front_end/core/host/UserMetrics.ts

@@ -335,36 +335,6 @@ export class UserMetrics {
         'DevTools.VisualLogging.ProcessingTime', timeInMilliseconds);
   }
 
-  legacyResourceTypeFilterNumberOfSelectedChanged(itemCount: number): void {
-    const boundItemCount = Math.max(Math.min(itemCount, ResourceType.MAX_VALUE - 1), 1);
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.LegacyResourceTypeFilterNumberOfSelectedChanged, boundItemCount, ResourceType.MAX_VALUE);
-  }
-
-  legacyResourceTypeFilterItemSelected(resourceTypeName: string): void {
-    const resourceType = ResourceType[resourceTypeName as keyof typeof ResourceType];
-    if (resourceType === undefined) {
-      return;
-    }
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.LegacyResourceTypeFilterItemSelected, resourceType, ResourceType.MAX_VALUE);
-  }
-
-  resourceTypeFilterNumberOfSelectedChanged(itemCount: number): void {
-    const boundItemCount = Math.max(Math.min(itemCount, ResourceType.MAX_VALUE - 1), 1);
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.ResourceTypeFilterNumberOfSelectedChanged, boundItemCount, ResourceType.MAX_VALUE);
-  }
-
-  resourceTypeFilterItemSelected(resourceTypeName: string): void {
-    const resourceType = ResourceType[resourceTypeName as keyof typeof ResourceType];
-    if (resourceType === undefined) {
-      return;
-    }
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.ResourceTypeFilterItemSelected, resourceType, ResourceType.MAX_VALUE);
-  }
-
   freestylerQueryLength(numberOfCharacters: number): void {
     InspectorFrontendHostInstance.recordCountHistogram(
         'DevTools.Freestyler.QueryLength', numberOfCharacters, 0, 100_000, 100);
@@ -1179,24 +1149,6 @@ export const enum DeveloperResourceScheme {
   MAX_VALUE = 9,
 }
 
-export enum ResourceType {
-  /* eslint-disable @typescript-eslint/naming-convention -- Used by web_tests. */
-  all = 0,
-  Document = 1,
-  JavaScript = 2,
-  'Fetch and XHR' = 3,
-  CSS = 4,
-  Font = 5,
-  Image = 6,
-  Media = 7,
-  Manifest = 8,
-  WebSocket = 9,
-  WebAssembly = 10,
-  Other = 11,
-  /* eslint-enable @typescript-eslint/naming-convention */
-  MAX_VALUE = 12,
-}
-
 export enum Language {
   /* eslint-disable @typescript-eslint/naming-convention */
   'af' = 1,

front_end/devtools_compatibility.js

@@ -444,10 +444,6 @@ const EnumeratedHistogram = {
   SwatchActivated: 'DevTools.SwatchActivated',
   AnimationPlaybackRateChanged: 'DevTools.AnimationPlaybackRateChanged',
   AnimationPointDragged: 'DevTools.AnimationPointDragged',
-  LegacyResourceTypeFilterNumberOfSelectedChanged: 'DevTools.LegacyResourceTypeFilterNumberOfSelectedChanged',
-  LegacyResourceTypeFilterItemSelected: 'DevTools.LegacyResourceTypeFilterItemSelected',
-  ResourceTypeFilterNumberOfSelectedChanged: 'DevTools.ResourceTypeFilterNumberOfSelectedChanged',
-  ResourceTypeFilterItemSelected: 'DevTools.ResourceTypeFilterItemSelected',
 };
 
 /**

front_end/panels/network/NetworkLogView.ts

@@ -2648,7 +2648,6 @@ export class MoreFiltersDropDownUI extends
   private contextMenu?: UI.ContextMenu.ContextMenu;
   private activeFiltersCount: HTMLElement;
   private activeFiltersCountAdorner: Adorners.Adorner.Adorner;
-  private hasChanged = false;
 
   constructor() {
     super();
@@ -2688,13 +2687,11 @@ export class MoreFiltersDropDownUI extends
   }
 
   #onSettingChanged(): void {
-    this.hasChanged = true;
     this.dispatchEventToListeners(UI.FilterBar.FilterUIEvents.FILTER_CHANGED);
   }
 
   showMoreFiltersContextMenu(event: Common.EventTarget.EventTargetEvent<Event>): void {
     const mouseEvent = event.data;
-    this.hasChanged = false;
 
     this.networkHideDataURLSetting.addChangeListener(this.#onSettingChanged.bind(this));
     this.networkHideChromeExtensionsSetting.addChangeListener(this.#onSettingChanged.bind(this));

front_end/ui/legacy/FilterBar.ts

@@ -470,13 +470,11 @@ export class NamedBitSetFilterUI extends Common.ObjectWrapper.ObjectWrapper<Filt
       this.allowedTypes.delete(typeName);
     } else {
       this.allowedTypes.add(typeName);
-      Host.userMetrics.legacyResourceTypeFilterItemSelected(typeName);
     }
 
     if (this.allowedTypes.size === 0) {
       this.allowedTypes.add(NamedBitSetFilterUI.ALL_TYPES);
     }
-    Host.userMetrics.legacyResourceTypeFilterNumberOfSelectedChanged(this.allowedTypes.size);
 
     if (this.setting) {
       // Settings do not support `Sets` so convert it back to the Map-like object.