Skip to content

Fix return type of #description method for PerformanceInsightFormatter.ts #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luisrivas wants to merge 1 commit into from
Closed

Fix return type of #description method for PerformanceInsightFormatter.ts #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export class PerformanceInsightFormatter extends PerformanceTraceFormatter {
if (this.#insight instanceof Error) {
return false;
}
return this.#description().length > 0;
return typeof this.#description() === 'string';
}

getSuggestions(): ConversationSuggestions {
Expand Down Expand Up @@ -983,7 +983,7 @@ ${this.#links()}`;
}
}

#description(): string {
#description(): string | undefined {
switch (this.#insight.insightKey) {
case 'CLSCulprits':
return `Cumulative Layout Shifts (CLS) is a measure of the largest burst of layout shifts for every unexpected layout shift that occurs during the lifecycle of a page. This is a Core Web Vital and the thresholds for categorizing a score are:
Expand Down