Fix menu highlighting to show correct active page (#7724)

## What Changed
<!-- Short summary - what and why (not how) -->

- Improve isActive() to properly match URLs with query parameters
- Menu items with query params only match when params are present
- Menu items without query params only match when URL has no params
- Make openMenu() recursive for nested submenu support
- Change submenu container from div to li for proper AdminLTE styling
- Add active class to nav-link for proper visual highlighting

## Type
<!-- Check one -->
- [ ] ✨ Feature
- [x] 🐛 Bug fix
- [ ] ♻️ Refactor
- [ ] 🏗️ Build/Infrastructure
- [ ] 🔒 Security

## Screenshots
<!-- Only for UI changes - drag & drop images here -->

<img width="428" height="733" alt="image"
src="https://github.com/user-attachments/assets/86d83566-a7f9-4a23-9a68-e686f5af5670"
/>


## Security Check
<!-- Only check if applicable -->
- [ ] Introduces new input validation
- [ ] Modifies authentication/authorization
- [ ] Affects data privacy/GDPR

### Code Quality
- [ ] Database: Propel ORM only, no raw SQL
- [ ] No deprecated attributes (align, valign, nowrap, border,
cellpadding, cellspacing, bgcolor)
- [ ] Bootstrap CSS classes used
- [ ] All CSS bundled via webpack

## Pre-Merge
- [x] Tested locally
- [ ] No new warnings
- [ ] Build passes
- [ ] Backward compatible (or migration documented)

Author: DawoudIO

src/ChurchCRM/Config/Menu/MenuItem.php

@@ -118,9 +118,14 @@ public function isVisible(): bool
     public function openMenu(): bool
     {
         foreach ($this->subItems as $item) {
+            // Check if this child is active
             if ($item->isActive()) {
                 return true;
             }
+            // Recursively check if any nested submenu has an active item
+            if ($item->isMenu() && $item->openMenu()) {
+                return true;
+            }
         }
 
         return false;
@@ -132,6 +137,41 @@ public function isActive(): bool
             return false;
         }
 
-        return $_SERVER['REQUEST_URI'] == $this->getURI();
+        $menuUri = $this->getURI();
+        $currentUri = $_SERVER['REQUEST_URI'];
+
+        // Parse both URIs
+        $currentPath = parse_url($currentUri, PHP_URL_PATH);
+        $menuPath = parse_url($menuUri, PHP_URL_PATH);
+        $menuQuery = parse_url($menuUri, PHP_URL_QUERY);
+        $currentQuery = parse_url($currentUri, PHP_URL_QUERY);
+
+        // Paths must match first
+        if ($currentPath !== $menuPath) {
+            return false;
+        }
+
+        // If menu item has query params, check they all match
+        if (!empty($menuQuery)) {
+            if (empty($currentQuery)) {
+                return false;
+            }
+
+            parse_str($menuQuery, $menuParams);
+            parse_str($currentQuery, $currentParams);
+
+            // Check if all menu params exist in current params with same values
+            foreach ($menuParams as $key => $value) {
+                if (!isset($currentParams[$key]) || $currentParams[$key] !== $value) {
+                    return false;
+                }
+            }
+
+            return true;
+        }
+
+        // Menu item has NO query params - only match if current URL also has no query params
+        // This prevents "/v2/family" from matching "/v2/family?mode=inactive"
+        return empty($currentQuery);
     }
 }

src/ChurchCRM/view/MenuRenderer.php

@@ -25,7 +25,7 @@ private static function renderMenuItem(MenuItem $menuItem): void
     {
         ?>
         <li class="nav-item<?= $menuItem->isActive() ? " active" : ""?>">
-            <a href="<?= htmlspecialchars($menuItem->getURI(), ENT_QUOTES, 'UTF-8') ?>" <?= $menuItem->isExternal() ? "target='_blank'" : "" ?> class="nav-link">
+            <a href="<?= htmlspecialchars($menuItem->getURI(), ENT_QUOTES, 'UTF-8') ?>" <?= $menuItem->isExternal() ? "target='_blank'" : "" ?> class="nav-link<?= $menuItem->isActive() ? " active" : ""?>">
                 <i class='nav-icon fa <?= $menuItem->getIcon() ?>'></i>
                 <p>
                     <span><?= htmlspecialchars($menuItem->getName()) ?></span>
@@ -41,8 +41,8 @@ private static function renderMenuItem(MenuItem $menuItem): void
     private static function renderSubMenuItem(MenuItem $menuItem): void
     {
         ?>
-        <div class="nav-item<?= $menuItem->openMenu() ? " menu-open active" : "" ?>">
-            <a href="#" class="nav-link">
+        <li class="nav-item<?= $menuItem->openMenu() ? " menu-open" : "" ?>">
+            <a href="#" class="nav-link<?= $menuItem->openMenu() ? " active" : "" ?>">
                 <i class="nav-icon fa <?= $menuItem->getIcon() ?>"></i>
                 <p>
                     <span><?= htmlspecialchars($menuItem->getName()) ?></span>
@@ -63,7 +63,7 @@ private static function renderSubMenuItem(MenuItem $menuItem): void
                 }
             } ?>
             </ul>
-        </div>
+        </li>
         <?php
     }