Integrity Check Failed

[adamking904]

We have a shared server, PHP 8.2.16. ChurchCRM installed from softaculous. We were using version 5.3... and updated to 5.6.0 last night. I made changes to two files and now notifications say integrity check on the two files that were edited.

FileName

ChurchCRM/Config/Menu/Menu.php
private static function buildMenuItems(): array
{
return [

        'Dashboard'    => new MenuItem(gettext('Dashboard'), 'v2/dashboard', true, 'fa-tachometer-alt'),
       /* 'Calendar'     => self::getCalendarMenu(),*/
        'People'       => self::getPeopleMenu(),
        'Groups'       => self::getGroupMenu(),
        'SundaySchool' => self::getSundaySchoolMenu(),
       /* 'Email'        => new MenuItem(gettext('Email'), 'v2/email/dashboard', SystemConfig::getBooleanValue('bEnabledEmail'), 'fa-envelope'),
       */ 'Events'       => self::getEventsMenu(),
        'Deposits'     => self::getDepositsMenu(),
        'Fundraiser'   => self::getFundraisersMenu(),
        'Reports'      => self::getReportsMenu(),
        'Admin'        => self::getAdminMenu(),
        'Custom'       => self::getCustomMenu(),
    ];
}

PeopleDashboard.php

isEmailEnabled()) { // Does user have permission to email groups // Display link ?>

    <!--div class="btn-group">
      <a  class="btn btn-app" href="mailto:<?= mb_substr($sEmailLink, 0, -3) ?>"><i class="fas fa-mail-bulk"></i></i><?= gettext('Email All')?></a>
      <button type="button" class="btn btn-app dropdown-toggle" data-toggle="dropdown" >
        <span class="caret"></span>
        <span class="sr-only">Toggle Dropdown</span>
      </button>
      <ul class="dropdown-menu" role="menu">
            <?php generateGroupRoleEmailDropdown($roleEmails, 'mailto:') ?>
      </ul>
    </div>
   <div class="btn-group">
      <a class="btn btn-app" href="mailto:?bcc=<?= mb_substr($sEmailLink, 0, -3) ?>"><i class="fas fa-mail-bulk"></i><?=gettext('Email All (BCC)') ?></a>
       <button type="button" class="btn btn-app dropdown-toggle" data-toggle="dropdown" >
        <span class="caret"></span>
        <span class="sr-only">Toggle Dropdown</span>
      </button>
      <ul class="dropdown-menu" role="menu">
            <?php generateGroupRoleEmailDropdown($roleEmails, 'mailto:?bcc=') ?>
      </ul>
    </div-->

We were trying to make changes to the menu items to remove the calendar and email options since those items still don't work after the upgrade. The site after the changes still works fine.
I wanted to add a link back to the main church site to the menu but couldn't get that to work last night and came back to work on it more tonight to find the notifications.

My question is: Is the failed integrity check something we need to worry about? As in should we make these changes in another way or is this something we can ignore?

[grayeul]

I'm pretty sure the failed integrity check is something you can ignore -- as long as you know you have edited the source files. When a 'release' is built, checksums are taken of all the source code and saved in a json file. These are compared against at run time, so if you have changed them it will result in the failed integrity check. But you should still be fine.

[DawoudIO]

be aware every upgrade will rewrite any modifications and temp files...