feat(ui): add item list support to search categories (#888)

* feat(categories): add item list support to search categories

Search categories can now have both a search query and a manually-added
item list, allowing users to supplement query results with additional
items.

Changes:
- config/categorypane.lua:
  - Added item list UI section to CreateSearchDetailPanel (similar to
    manual categories)
  - Repositioned Save/Rename/Delete buttons to bottom with divider
  - Added drag-and-drop support for adding items to search categories
  - Updated ShowSearchCategoryDetail to load item list on display
  - Item list label clarifies these are "Additional Items" to supplement
    the search query

- data/categories.lua:
  - Removed blocking logic in AddItemToCategory that prevented items
    from being added to categories with searchCategory field (lines
    175-176 and 184-185)
  - Search categories can now accumulate items in their itemList just
    like manual categories

How it works:
1. Search query results are cached in items:RefreshSearchCache and
   looked up via searchCache[kind][slotkey]
2. Manually added items are stored in category.itemList and found via
   categories:GetCustomCategory
3. When an item matches both the search query AND is in the itemList,
   the priority system determines which takes precedence (both will
   return the same category name, so priority comparison is consistent)
4. The UI now exposes the item list for search categories, making the
   dual-matching behavior accessible to users

Technical details:
- The items module already supported this pattern - it checks both
  searchCache and GetCustomCategory, comparing priorities when both
  match
- SaveSearchCategory already preserved itemList via "itemList =
  filter.itemList or {}" (line 801)
- The blocking logic was the only thing preventing this feature from
  working

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix(config): display item list for search categories in Category Pane

The Category Pane's "Additional Items" list was not displaying for search
categories, even when items had been manually added. This was because the
LoadItemList function was hardcoded to only update the manualDetail.itemListFrame,
ignoring the searchDetail.itemListFrame that search categories use.

Changes made:

1. Modified LoadItemList() to detect which detail panel is currently active
   (searchDetail or manualDetail) and update the correct item list frame
   accordingly. This allows both manual categories and search categories to
   display their item lists properly.

2. Updated the bags/Draw event handler to refresh the item list when EITHER
   a manual category OR a search category is selected, ensuring that items
   added via drag-and-drop appear immediately in the UI for both category types.

The item list UI elements (frames, drag-and-drop handlers) were already present
in the searchDetail panel, and the ShowSearchCategoryDetail() function was
already calling LoadItemList(). The issue was purely that LoadItemList() was
not routing to the correct frame for search categories.

Fixes the "Additional Items" list display for search categories.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: Cidan

config/categorypane.lua

@@ -462,6 +462,9 @@ function categoryPaneProto:ShowSearchCategoryDetail(filter)
   else
     self.searchDetail.deleteButton:SetText("Delete Category")
   end
+
+  -- Load item list for the search category
+  self:LoadItemList(filter.name)
 end
 
 function categoryPaneProto:CreateSearchDetailPanel()
@@ -733,17 +736,24 @@ function categoryPaneProto:CreateSearchDetailPanel()
 
   yOffset = yOffset - 60
 
-  -- Save Button
+  -- Items Label
+  local itemsLabel = self.searchDetail:CreateFontString(nil, "OVERLAY", "GameFontNormal")
+  itemsLabel:SetPoint("TOPLEFT", 10, yOffset)
+  itemsLabel:SetText("Additional Items (drag items here to add)")
+
+  yOffset = yOffset - 20
+
+  -- Save Button (anchored to bottom)
   local saveButton = CreateFrame("Button", nil, self.searchDetail, "UIPanelButtonTemplate")
-  saveButton:SetPoint("TOPLEFT", 10, yOffset)
+  saveButton:SetPoint("BOTTOMLEFT", self.searchDetail, "BOTTOMLEFT", 10, 10)
   saveButton:SetSize(100, 25)
   saveButton:SetText("Save")
   saveButton:SetScript("OnClick", function()
     self:SaveSearchCategory()
   end)
   self.searchDetail.saveButton = saveButton
 
-  -- Rename Button
+  -- Rename Button (anchored to save button)
   local renameButton = CreateFrame("Button", nil, self.searchDetail, "UIPanelButtonTemplate")
   renameButton:SetPoint("LEFT", saveButton, "RIGHT", 10, 0)
   renameButton:SetSize(100, 25)
@@ -754,7 +764,7 @@ function categoryPaneProto:CreateSearchDetailPanel()
   end)
   self.searchDetail.renameButton = renameButton
 
-  -- Delete Button
+  -- Delete Button (anchored to rename button)
   local deleteButton = CreateFrame("Button", nil, self.searchDetail, "UIPanelButtonTemplate")
   deleteButton:SetPoint("LEFT", renameButton, "RIGHT", 10, 0)
   deleteButton:SetSize(120, 25)
@@ -770,6 +780,48 @@ function categoryPaneProto:CreateSearchDetailPanel()
     end, function() end)
   end)
   self.searchDetail.deleteButton = deleteButton
+
+  -- Divider 2 (anchored above buttons)
+  local divider2 = self.searchDetail:CreateTexture(nil, "ARTWORK")
+  divider2:SetPoint("BOTTOMLEFT", self.searchDetail, "BOTTOMLEFT", 10, 45)
+  divider2:SetPoint("RIGHT", self.searchDetail, "RIGHT", -10, 0)
+  divider2:SetHeight(1)
+  divider2:SetColorTexture(0.5, 0.5, 0.5, 0.5)
+
+  -- Item List Frame (expands to fill available space)
+  local itemListContainer = CreateFrame("Frame", nil, self.searchDetail)
+  itemListContainer:SetPoint("TOPLEFT", 10, yOffset)
+  itemListContainer:SetPoint("RIGHT", self.searchDetail, "RIGHT", -10, 0)
+  itemListContainer:SetPoint("BOTTOM", divider2, "TOP", 0, 20)
+
+  self.searchDetail.itemListFrame = list:Create(itemListContainer)
+  self.searchDetail.itemListFrame.frame:SetAllPoints()
+  self.searchDetail.itemListFrame:SetupDataSource("BetterBagsCategoryPaneItemFrame", function(f, data)
+    ---@cast f CategoryPaneItemFrame
+    self:initItemRow(f, data)
+  end, function(f, data)
+    ---@cast f CategoryPaneItemFrame
+    self:resetItemRow(f, data)
+  end)
+
+  -- Enable drag-and-drop to add items to the category
+  -- Set up handlers on both the container and the list frame's scroll box
+  local function onReceiveDrag()
+    self:OnItemListDrop()
+  end
+  local function onMouseUp(_, button)
+    if button == "LeftButton" and CursorHasItem() then
+      self:OnItemListDrop()
+    end
+  end
+
+  itemListContainer:EnableMouse(true)
+  itemListContainer:SetScript("OnReceiveDrag", onReceiveDrag)
+  itemListContainer:SetScript("OnMouseUp", onMouseUp)
+
+  -- Also set on the scroll box so drops work over the list area
+  self.searchDetail.itemListFrame.ScrollBox:SetScript("OnReceiveDrag", onReceiveDrag)
+  self.searchDetail.itemListFrame.ScrollBox:HookScript("OnMouseUp", onMouseUp)
 end
 
 function categoryPaneProto:SaveSearchCategory()
@@ -1078,15 +1130,23 @@ end
 
 ---@param categoryName string
 function categoryPaneProto:LoadItemList(categoryName)
-  if not self.manualDetail or not self.manualDetail.itemListFrame then return end
+  -- Determine which detail panel is currently active and update the correct item list frame
+  local itemListFrame
+  if self.detailContent == self.searchDetail and self.searchDetail and self.searchDetail.itemListFrame then
+    itemListFrame = self.searchDetail.itemListFrame
+  elseif self.detailContent == self.manualDetail and self.manualDetail and self.manualDetail.itemListFrame then
+    itemListFrame = self.manualDetail.itemListFrame
+  else
+    return
+  end
 
-  self.manualDetail.itemListFrame:Wipe()
+  itemListFrame:Wipe()
 
   local itemDataList = categories:GetMergedCategory(categoryName)
   if not itemDataList then return end
 
   for id in pairs(itemDataList.itemList) do
-    self.manualDetail.itemListFrame:AddToStart({id = id, category = categoryName})
+    itemListFrame:AddToStart({id = id, category = categoryName})
   end
 end
 
@@ -1376,8 +1436,8 @@ function categoryPane:Create(parent, kind)
   events:RegisterMessage(drawEvent, function()
     if pane.initialized then
       pane:RefreshList()
-      -- Also refresh the item list if a manual category is selected
-      if pane.selectedCategory and pane.detailContent == pane.manualDetail then
+      -- Also refresh the item list if a manual or search category is selected
+      if pane.selectedCategory and (pane.detailContent == pane.manualDetail or pane.detailContent == pane.searchDetail) then
         pane:LoadItemList(pane.selectedCategory)
       end
     end

data/categories.lua

@@ -172,18 +172,12 @@ function categories:AddItemToCategory(ctx, id, category)
   end
 
   if self.ephemeralCategories[category] then
-    if self.ephemeralCategories[category].searchCategory then
-      return
-    end
     self.ephemeralCategories[category].itemList[id] = true
     self.ephemeralCategoryByItemID[id] = self.ephemeralCategories[category]
     return
   end
 
   assert(database:ItemCategoryExists(category), format("Attempted to add item %d to category %s, but the category does not exist.", id, category))
-  if database:GetItemCategory(category).searchCategory then
-    return
-  end
   database:SaveItemToCategory(id, category)
 end