more decoupling and fixes

Author: Cidan

bags/bank.lua

@@ -80,7 +80,7 @@ function bank.proto:OnShow(ctx)
 			self.bag.tabs:SetTabByID(ctx, firstTabID)
 			ctx:Set("filterBagID", firstTabID) -- Set the filter for the initial tab
 		else
-			self.bag.bankTab = Enum.BagIndex.Bank
+			self.bag.bankTab = Enum.BagIndex.Characterbanktab
 			self.bag.tabs:SetTabByID(ctx, 1)
 		end
 		-- Set the active bank type for character bank
@@ -420,7 +420,7 @@ end
 
 ---@param ctx Context
 function bank.proto:SwitchToBank(ctx)
-	self.bag.bankTab = Enum.BagIndex.Bank
+	self.bag.bankTab = Enum.BagIndex.Characterbanktab
 	BankFrame.selectedTab = 1
 	self.bag:SetTitle(L:G("Bank"))
 	self.bag.currentItemCount = -1
@@ -505,14 +505,18 @@ end
 ---@param ctx Context
 function bank.proto:SwitchToBankAndWipe(ctx)
 	ctx:Set("wipe", true)
-	self.bag.tabs:SetTabByID(ctx, 1)
-	self.bag.bankTab = Enum.BagIndex.Bank
+	-- Set bankTab first to ensure it's always valid for refresh operations
+	-- Use Characterbanktab as Bank was removed in TWW 11.2
+	self.bag.bankTab = Enum.BagIndex.Characterbanktab
 	BankFrame.selectedTab = 1
 	BankFrame.activeTabIndex = 1
 	-- Set the active bank type so right-click item movement works correctly
 	if BankPanel and BankPanel.SetBankType then
 		BankPanel:SetBankType(Enum.BankType.Character)
 	end
+	if self.bag.tabs then
+		self.bag.tabs:SetTabByID(ctx, 1)
+	end
 	self.bag:SetTitle(L:G("Bank"))
 	items:ClearBankCache(ctx)
 	self.bag:Wipe(ctx)

data/items.lua

@@ -567,7 +567,8 @@ function items:RefreshBags(ctx, kind)
 		end
 
 		local filterBagID = ctx:Get("filterBagID")
-		local reagentBank = addon.isRetail and Enum.BagIndex.Reagentbank or const.BANK_TAB.REAGENT
+		-- Reagent bank was removed in TWW 11.2 for retail, only exists in classic/era
+		local reagentBank = not addon.isRetail and const.BANK_TAB.REAGENT or nil
 		local accountBankStart = addon.isRetail and Enum.BagIndex.AccountBankTab_1 or const.BANK_TAB.ACCOUNT_BANK_1
 
 		-- Determine which bank bags to show
@@ -748,13 +749,12 @@ function items:UpdateFreeSlots(ctx, kind)
 		else
 			name = C_Item.GetItemSubClassInfo(Enum.ItemClass.Container, 0)
 		end
-		if bagid == Enum.BagIndex.Bank or bagid == Enum.BagIndex.Reagentbank then
-			-- BugFix(https://github.com/Stanzilla/WoWUIBugs/issues/538):
-			-- There are 4 extra slots in the bank bag in Classic that should not
-			-- exist. This is a Blizzard bug.
-			if addon.isClassic then
-				freeSlots = freeSlots - 4
-			end
+		-- BugFix(https://github.com/Stanzilla/WoWUIBugs/issues/538):
+		-- There are 4 extra slots in the bank bag in Classic that should not
+		-- exist. This is a Blizzard bug.
+		-- Note: Enum.BagIndex.Bank and Reagentbank were removed in TWW 11.2
+		if addon.isClassic and (bagid == Enum.BagIndex.Bank or bagid == Enum.BagIndex.Reagentbank) then
+			freeSlots = freeSlots - 4
 		end
 
 		if bagid ~= Enum.BagIndex.Keyring then

data/refresh.lua

@@ -146,6 +146,11 @@ function refresh:ExecutePendingUpdates()
       refreshCtx:Set('filterBagID', addon.Bags.Bank.bankTab)
     else
       local currentTab = addon.Bags.Bank.bankTab
+      -- Guard against nil bankTab (can happen if refresh fires before OnShow completes)
+      -- Use hardcoded -1 as fallback (bank bag ID) since Enum.BagIndex.Bank may not exist in all contexts
+      if currentTab == nil then
+        currentTab = -1
+      end
       accountBankStart = addon.isRetail and Enum.BagIndex.AccountBankTab_1 or 13
 
       if currentTab >= accountBankStart then

frames/bag.lua

@@ -401,7 +401,7 @@ function bagFrame:Create(ctx, kind)
 	b.currentItemCount = 0
 	b.drawOnClose = false
 	b.drawAfterCombat = false
-	b.bankTab = addon.isRetail and Enum.BagIndex.Bank or Enum.BagIndex.Characterbanktab
+	b.bankTab = Enum.BagIndex.Characterbanktab
 	b.sections = {}
 	b.toRelease = {}
 	b.toReleaseSections = {}

util/movementflow.lua

@@ -31,7 +31,8 @@ end
 function movementFlow:GetMovementFlow()
   -- Fix for retail WoW: use Enum.BagIndex values directly
   local accountBankStart = addon.isRetail and Enum.BagIndex.AccountBankTab_1 or const.BANK_TAB.ACCOUNT_BANK_1
-  local reagentBank = addon.isRetail and Enum.BagIndex.Reagentbank or const.BANK_TAB.REAGENT
+  -- Reagent bank was removed in TWW 11.2 for retail, only exists in classic/era
+  local reagentBank = not addon.isRetail and const.BANK_TAB.REAGENT or nil
 
   -- Only check bank-specific flows if Bank bag is enabled
   if addon.Bags.Bank and addon.atBank and addon.Bags.Bank.bankTab then