fixed right clicking items not going to the right account type

Author: Cidan

core/init.lua

@@ -222,6 +222,31 @@ function addon:HideBlizzardBags()
   BankFrame:SetScript("OnHide", nil)
   BankFrame:SetScript("OnShow", nil)
   BankFrame:SetScript("OnEvent", nil)
+
+  -- Override BankFrame:GetActiveBankType() to return the correct bank type
+  -- based on BetterBags' current tab selection. This is necessary because
+  -- BetterBags hides the Blizzard BankPanel, causing the original function
+  -- to return nil.
+  if addon.isRetail and BankFrame.GetActiveBankType then
+    BankFrame.GetActiveBankType = function(self)
+      -- If BetterBags bank is not open, return nil
+      if not addon.Bags or not addon.Bags.Bank or not addon.Bags.Bank:IsShown() then
+        return nil
+      end
+
+      -- Return the bank type based on BetterBags' current bank tab
+      if addon.Bags.Bank.bankTab then
+        -- Account bank tabs are >= 13 (Enum.BagIndex.AccountBankTab_1)
+        if addon.Bags.Bank.bankTab >= (Enum.BagIndex.AccountBankTab_1 or 13) then
+          return Enum.BankType.Account
+        else
+          return Enum.BankType.Character
+        end
+      end
+
+      return Enum.BankType.Character
+    end
+  end
 end
 
 function addon:UpdateButtonHighlight()

frames/bag.lua

@@ -271,6 +271,10 @@ function bagFrame.bagProto:Show(ctx)
     if addon.atWarbank then
       self:HideBankAndReagentTabs()
       self.tabs:SetTabByID(ctx, 13)
+      -- Set the active bank type for warbank
+      if BankPanel then
+        BankPanel.bankType = Enum.BankType.Account
+      end
     else
       self:ShowBankAndReagentTabs()
       -- Set first tab when using multiple character bank tabs
@@ -283,6 +287,10 @@ function bagFrame.bagProto:Show(ctx)
         self.bankTab = addon.isRetail and Enum.BagIndex.Bank or Enum.BagIndex.Characterbanktab
         self.tabs:SetTabByID(ctx, 1)
       end
+      -- Set the active bank type for character bank
+      if BankPanel then
+        BankPanel.bankType = Enum.BankType.Character
+      end
     end
    self.moneyFrame:Update()
   end
@@ -467,6 +475,10 @@ function bagFrame.bagProto:SwitchToBank(ctx)
   self.currentItemCount = -1
   BankFrame.activeTabIndex = 1
   BankPanel.selectedTabID = nil
+  -- Set the active bank type so right-click item movement works correctly
+  if addon.isRetail and BankPanel then
+    BankPanel.bankType = Enum.BankType.Character
+  end
   -- Clear bank cache to ensure clean state
   items:ClearBankCache(ctx)
   self:Wipe(ctx)
@@ -486,6 +498,10 @@ function bagFrame.bagProto:SwitchToCharacterBankTab(ctx, tabID)
   BankFrame.selectedTab = 1
   BankFrame.activeTabIndex = 1
   BankPanel.selectedTabID = nil
+  -- Set the active bank type so right-click item movement works correctly
+  if addon.isRetail and BankPanel then
+    BankPanel.bankType = Enum.BankType.Character
+  end
   self:SetTitle(format(L:G("Bank Tab %d"), tabID - const.BANK_ONLY_BAGS_LIST[1] + 1))
   self.currentItemCount = -1
   -- Clear bank cache to ensure no items from other tabs remain
@@ -507,6 +523,10 @@ function bagFrame.bagProto:SwitchToAccountBank(ctx, tabIndex)
   self.bankTab = tabIndex
   BankFrame.selectedTab = 1
   BankFrame.activeTabIndex = 3
+  -- Set the active bank type so right-click item movement works correctly
+  if addon.isRetail and BankPanel then
+    BankPanel.bankType = Enum.BankType.Account
+  end
   local tabData = C_Bank.FetchPurchasedBankTabData(Enum.BankType.Account)
   for _, data in pairs(tabData) do
     if data.ID == tabIndex then
@@ -535,6 +555,10 @@ function bagFrame.bagProto:SwitchToBankAndWipe(ctx)
   self.bankTab = addon.isRetail and Enum.BagIndex.Bank or Enum.BagIndex.Characterbanktab
   BankFrame.selectedTab = 1
   BankFrame.activeTabIndex = 1
+  -- Set the active bank type so right-click item movement works correctly
+  if addon.isRetail and BankPanel then
+    BankPanel.bankType = Enum.BankType.Character
+  end
   self:SetTitle(L:G("Bank"))
   items:ClearBankCache(ctx)
   self:Wipe(ctx)