feat(config): add tooltip to category list items in options screen#891
Closed
feat(config): add tooltip to category list items in options screen#891
Conversation
When hovering over a category entry in the category options list, show a GameTooltip with the text: "Shift-click to move this category to the pinned category section" This re-adds the tooltip that was previously removed, ensuring users know about the shift-click pinning shortcut. The tooltip is shown via GameTooltip:SetOwner/SetText/Show in OnEnter, and hidden via GameTooltip:Hide in OnLeave. Header items are excluded (they already have no OnEnter/OnLeave handlers). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…list tooltip The tooltip was not displaying correctly because GameTooltip:SetText() has the signature SetText(text, r, g, b, alpha, textWrap), but the call was passing only 5 arguments with `true` as the 5th argument. This caused `true` to be interpreted as the alpha value instead of the textWrap flag, meaning textWrap was absent (defaulted to false). With long tooltip text and no wrapping, the tooltip text overflowed off-screen and was effectively invisible. Fix: add the missing alpha=1 argument so textWrap=true is correctly passed as the 6th argument: GameTooltip:SetText(text, 1, 1, 1, 1, true) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Fixed the tooltip not appearing. The root cause was a subtle API signature mismatch in Bug: The call was: GameTooltip:SetText(text, 1, 1, 1, true)The actual signature is: GameTooltip:SetText(text, r, g, b, alpha, textWrap)The Fix: GameTooltip:SetText(text, 1, 1, 1, 1, true) -- alpha=1, textWrap=trueNote: |
Cidan
added a commit
that referenced
this pull request
Feb 18, 2026
Automated commit generated by the Nanomite code tool. Prompt: The previous attempt to add a tooltip to the category list in BetterBags (PR #891) didn't work. The user reports no tooltip is appearing. Task: 1. Re-examine `config/categorypane.lua` and how the category list is implemented. 2. Check if the `OnEnter` and `OnLeave` handlers are actually being triggered on the correct frame. 3. Verify if `GameTooltip` is being used correctly in this context (e.g., is it being obscured, or is the frame not mouse-enabled?). 4. Fix the implementation so the toolt...
Cidan
added a commit
that referenced
this pull request
Feb 18, 2026
) * feat(config): add tooltip to category list items in options screen When hovering over a category entry in the category options list, show a GameTooltip with the text: "Shift-click to move this category to the pinned category section" This re-adds the tooltip that was previously removed, ensuring users know about the shift-click pinning shortcut. The tooltip is shown via GameTooltip:SetOwner/SetText/Show in OnEnter, and hidden via GameTooltip:Hide in OnLeave. Header items are excluded (they already have no OnEnter/OnLeave handlers). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(config): correct GameTooltip:SetText alpha parameter in category list tooltip The tooltip was not displaying correctly because GameTooltip:SetText() has the signature SetText(text, r, g, b, alpha, textWrap), but the call was passing only 5 arguments with `true` as the 5th argument. This caused `true` to be interpreted as the alpha value instead of the textWrap flag, meaning textWrap was absent (defaulted to false). With long tooltip text and no wrapping, the tooltip text overflowed off-screen and was effectively invisible. Fix: add the missing alpha=1 argument so textWrap=true is correctly passed as the 6th argument: GameTooltip:SetText(text, 1, 1, 1, 1, true) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: The previous attempt to add a tooltip to the category lis... Automated commit generated by the Nanomite code tool. Prompt: The previous attempt to add a tooltip to the category list in BetterBags (PR #891) didn't work. The user reports no tooltip is appearing. Task: 1. Re-examine `config/categorypane.lua` and how the category list is implemented. 2. Check if the `OnEnter` and `OnLeave` handlers are actually being triggered on the correct frame. 3. Verify if `GameTooltip` is being used correctly in this context (e.g., is it being obscured, or is the frame not mouse-enabled?). 4. Fix the implementation so the toolt... --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GameTooltipwith the text: "Shift-click to move this category to the pinned category section"OnEnterand hidden onOnLeaveOnEnter/OnLeavehandlers)Test plan
🤖 Generated with Claude Code