comments

Author: matus.hudec

src/httpClient/redisStorage.ts

@@ -3,17 +3,19 @@ import type { StorageValue } from 'axios-cache-interceptor';
 // eslint-disable-next-line import/no-extraneous-dependencies
 import { createClient } from 'redis';
 
+const keyPrefix = 'axios-cache-';
+
 export default function createRedisStorage(client: ReturnType<typeof createClient>) {
   // source https://axios-cache-interceptor.js.org/guide/storages#node-redis-storage
   return buildStorage({
     async find(key) {
-      const result = await client.get(`axios-cache-${key}`);
+      const result = await client.get(`${keyPrefix}${key}`);
       return result ? (JSON.parse(result) as StorageValue) : undefined;
     },
 
     // eslint-disable-next-line complexity
     async set(key, value, req) {
-      await client.set(`axios-cache-${key}`, JSON.stringify(value), {
+      await client.set(`${keyPrefix}${key}`, JSON.stringify(value), {
         PXAT:
           value.state === 'loading'
             ? Date.now() + (req?.cache && typeof req.cache.ttl === 'number' ? req.cache.ttl : 60000)
@@ -25,7 +27,7 @@ export default function createRedisStorage(client: ReturnType<typeof createClien
     },
 
     async remove(key) {
-      await client.del(`axios-cache-${key}`);
+      await client.del(`${keyPrefix}${key}`);
     },
   });
 }

src/logger/logger.ts

@@ -5,6 +5,10 @@ import stringify from 'fast-safe-stringify';
 import isError from 'is-error';
 import { redactSecret } from '../util';
 
+const defaultPayloadLimit = 32768;
+
+const minPayloadLimit = 10000;
+
 export default class Logger {
   public invocationId: string;
 
@@ -19,10 +23,11 @@ export default class Logger {
   constructor(configuration?: LoggerConfiguration) {
     this.logFunction = configuration?.logFunction ?? console.log;
     this.jsonSpace = configuration?.jsonSpace ?? 2;
-    this.payloadLimit =
-      !configuration?.payloadLimit || configuration?.payloadLimit < 10000
-        ? 32768
-        : configuration?.payloadLimit;
+    this.payloadLimit = !configuration?.payloadLimit
+      ? defaultPayloadLimit
+      : configuration?.payloadLimit < minPayloadLimit
+      ? minPayloadLimit
+      : configuration.payloadLimit;
 
     this.invocationId = 'none';
   }

src/util.ts

@@ -38,15 +38,15 @@ export function serializeObject(obj: unknown, redact?: boolean): object {
     : JSON.parse(JSON.stringify(modObj));
 }
 
-export function serializeAxiosError(error: AxiosError): SerializedAxiosError | undefined {
+export function serializeAxiosError(error: AxiosError<any>): SerializedAxiosError | undefined {
   if (!error.response) {
     return {
       status: 500,
       details: error,
     };
   }
 
-  const { status, data } = error.response as any;
+  const { status, data } = error.response;
   return {
     status: data.originalStatusCode ?? status, // Propagate original status code of ClientException
     details: data.details && Object.keys(data.details).length > 0 ? data.details : data, // Prevent wrapping of Exception