Skip to content

Commit 8d2aede

Browse files
author
Ying Wei
committed
Revert "FrameTimeline: Optimize tracing information about frame start time"
This reverts commit f24ce7c. Reason for revert: P0 Jank regression b/408126635 Change-Id: I73885769812d955a92f6d2e5011914c6714494d6
1 parent f24ce7c commit 8d2aede

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

services/surfaceflinger/FrameTimeline/FrameTimeline.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -801,9 +801,6 @@ void SurfaceFrame::traceActuals(int64_t displayFrameToken, nsecs_t monoBootOffse
801801
FrameTimelineDataSource::Trace([&](FrameTimelineDataSource::TraceContext ctx) {
802802
const auto timestamp = [&]() {
803803
std::scoped_lock lock(mMutex);
804-
if (mActuals.startTime != 0) {
805-
return mActuals.startTime;
806-
}
807804
// Actual start time is not yet available, so use expected start instead
808805
if (mPredictionState == PredictionState::Expired) {
809806
// If prediction is expired, we can't use the predicted start time. Instead, just
@@ -814,7 +811,7 @@ void SurfaceFrame::traceActuals(int64_t displayFrameToken, nsecs_t monoBootOffse
814811
return endTime - kPredictionExpiredStartTimeDelta;
815812
}
816813

817-
return mPredictions.startTime;
814+
return mActuals.startTime == 0 ? mPredictions.startTime : mActuals.startTime;
818815
}();
819816

820817
if (filterFramesBeforeTraceStarts && !shouldTraceForDataSource(ctx, timestamp)) {

0 commit comments

Comments
 (0)