Skip to content

Commit cb8b75a

Browse files
Treehugger RobotAndroid (Google) Code Review
authored andcommitted
Merge "Fix typo ("reachablilty" -> "reachability")" into main
2 parents f110207 + 2dfd42e commit cb8b75a

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

services/surfaceflinger/FrontEnd/LayerSnapshot.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ LayerSnapshot::LayerSnapshot(const RequestedLayerState& state,
134134
clientChanges = 0;
135135
mirrorRootPath =
136136
LayerHierarchy::isMirror(path.variant) ? path : LayerHierarchy::TraversalPath::ROOT;
137-
reachablilty = LayerSnapshot::Reachablilty::Unreachable;
137+
reachability = LayerSnapshot::Reachability::Unreachable;
138138
frameRateSelectionPriority = state.frameRateSelectionPriority;
139139
layerMetadata = state.metadata;
140140
}
@@ -223,7 +223,7 @@ bool LayerSnapshot::isHiddenByPolicy() const {
223223
}
224224

225225
bool LayerSnapshot::getIsVisible() const {
226-
if (reachablilty != LayerSnapshot::Reachablilty::Reachable) {
226+
if (reachability != LayerSnapshot::Reachability::Reachable) {
227227
return false;
228228
}
229229

@@ -244,9 +244,9 @@ bool LayerSnapshot::getIsVisible() const {
244244

245245
std::string LayerSnapshot::getIsVisibleReason() const {
246246
// not visible
247-
if (reachablilty == LayerSnapshot::Reachablilty::Unreachable)
247+
if (reachability == LayerSnapshot::Reachability::Unreachable)
248248
return "layer not reachable from root";
249-
if (reachablilty == LayerSnapshot::Reachablilty::ReachableByRelativeParent)
249+
if (reachability == LayerSnapshot::Reachability::ReachableByRelativeParent)
250250
return "layer only reachable via relative parent";
251251
if (isHiddenByPolicyFromParent) return "hidden by parent or layer flag";
252252
if (isHiddenByPolicyFromRelativeParent) return "hidden by relative parent";
@@ -283,7 +283,7 @@ bool LayerSnapshot::isTransformValid(const ui::Transform& t) {
283283
bool LayerSnapshot::hasInputInfo() const {
284284
return (inputInfo.token != nullptr ||
285285
inputInfo.inputConfig.test(gui::WindowInfo::InputConfig::NO_INPUT_CHANNEL)) &&
286-
reachablilty == Reachablilty::Reachable;
286+
reachability == Reachability::Reachable;
287287
}
288288

289289
std::string LayerSnapshot::getDebugString() const {

services/surfaceflinger/FrontEnd/LayerSnapshot.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ struct LayerSnapshot : public compositionengine::LayerFECompositionState {
109109
uint32_t touchCropId;
110110
gui::Uid uid = gui::Uid::INVALID;
111111
gui::Pid pid = gui::Pid::INVALID;
112-
enum class Reachablilty : uint32_t {
112+
enum class Reachability : uint32_t {
113113
// Can traverse the hierarchy from a root node and reach this snapshot
114114
Reachable,
115115
// Cannot traverse the hierarchy from a root node and reach this snapshot
@@ -135,7 +135,7 @@ struct LayerSnapshot : public compositionengine::LayerFECompositionState {
135135
// and input.
136136
ReachableByRelativeParent
137137
};
138-
Reachablilty reachablilty;
138+
Reachability reachability;
139139
// True when the surfaceDamage is recognized as a small area update.
140140
bool isSmallDirty = false;
141141

services/surfaceflinger/FrontEnd/LayerSnapshotBuilder.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,8 @@ void LayerSnapshotBuilder::updateSnapshots(const Args& args) {
438438
}
439439

440440
for (auto& snapshot : mSnapshots) {
441-
if (snapshot->reachablilty == LayerSnapshot::Reachablilty::Reachable) {
442-
snapshot->reachablilty = LayerSnapshot::Reachablilty::Unreachable;
441+
if (snapshot->reachability == LayerSnapshot::Reachability::Reachable) {
442+
snapshot->reachability = LayerSnapshot::Reachability::Unreachable;
443443
}
444444
}
445445

@@ -480,7 +480,7 @@ void LayerSnapshotBuilder::updateSnapshots(const Args& args) {
480480
while (it < mSnapshots.end()) {
481481
auto& traversalPath = it->get()->path;
482482
const bool unreachable =
483-
it->get()->reachablilty == LayerSnapshot::Reachablilty::Unreachable;
483+
it->get()->reachability == LayerSnapshot::Reachability::Unreachable;
484484
const bool isClone = traversalPath.isClone();
485485
const bool layerIsDestroyed =
486486
destroyedLayerIds.find(traversalPath.id) != destroyedLayerIds.end();
@@ -631,7 +631,7 @@ bool LayerSnapshotBuilder::sortSnapshotsByZ(const Args& args) {
631631
mSnapshots[globalZ]->globalZ = globalZ;
632632
/* mark unreachable snapshots as explicitly invisible */
633633
updateVisibility(*mSnapshots[globalZ], false);
634-
if (mSnapshots[globalZ]->reachablilty == LayerSnapshot::Reachablilty::Unreachable) {
634+
if (mSnapshots[globalZ]->reachability == LayerSnapshot::Reachability::Unreachable) {
635635
hasUnreachableSnapshots = true;
636636
}
637637
globalZ++;
@@ -655,8 +655,8 @@ void LayerSnapshotBuilder::updateRelativeState(LayerSnapshot& snapshot,
655655
snapshot.relativeLayerMetadata = parentSnapshot.relativeLayerMetadata;
656656
}
657657
}
658-
if (snapshot.reachablilty == LayerSnapshot::Reachablilty::Unreachable) {
659-
snapshot.reachablilty = LayerSnapshot::Reachablilty::ReachableByRelativeParent;
658+
if (snapshot.reachability == LayerSnapshot::Reachability::Unreachable) {
659+
snapshot.reachability = LayerSnapshot::Reachability::ReachableByRelativeParent;
660660
}
661661
}
662662

@@ -730,7 +730,7 @@ void LayerSnapshotBuilder::updateSnapshot(LayerSnapshot& snapshot, const Args& a
730730
RequestedLayerState::Changes::FrameRate | RequestedLayerState::Changes::GameMode);
731731
snapshot.changes |= parentChanges;
732732
if (args.displayChanges) snapshot.changes |= RequestedLayerState::Changes::Geometry;
733-
snapshot.reachablilty = LayerSnapshot::Reachablilty::Reachable;
733+
snapshot.reachability = LayerSnapshot::Reachability::Reachable;
734734
snapshot.clientChanges |= (parentSnapshot.clientChanges & layer_state_t::AFFECTS_CHILDREN);
735735
// mark the content as dirty if the parent state changes can dirty the child's content (for
736736
// example alpha)

0 commit comments

Comments
 (0)