Revert "Resolves issues with static credentials auth and add tests (#214)" (#216)

This reverts commit b59332d.

Author: marboledacci

.circleci/test-deploy.yml

@@ -195,17 +195,6 @@ jobs:
           cat ~/.aws/credentials
       - run: |
           aws sts get-caller-identity --profile integration-test-multiple-setups-env
-  integration-test-static-credentials:
-    parameters:
-      executor:
-        type: executor
-    executor: <<parameters.executor>>
-    steps:
-      - aws-cli/setup:
-          aws_access_key_id: $AWS_ACCESS_KEY_ID
-          aws_secret_access_key: $AWS_SECRET_ACCESS_KEY
-      - run: |
-          aws sts get-caller-identity
 workflows:
   test-deploy:
     jobs:
@@ -371,12 +360,6 @@ workflows:
           post-steps:
             - check_aws_version:
                 version: "2.15.57"
-      - integration-test-static-credentials:
-          context: [CPE_ORBS_AWS]
-          matrix:
-            alias: integration-test-static-credentials
-            parameters:
-              executor: ["linuxvm", "windows", "arm"]
       - integration-test-install:
           name: integration-test-skip-install-matched-version
           context: [CPE_ORBS_AWS]
@@ -418,7 +401,7 @@ workflows:
           pub_type: production
           enable_pr_comment: true
           context: orb-publisher
-          requires: [orb-tools/pack, integration-test-static-credentials, test-install, test-install-version, test-install-override-version, integration-test-web-identity-with-profile, integration test web identity command with white spaces,integration-test-role-arn-config, test-install-override-version-with-latest, integration-test-skip-install-matched-version, integration-test-brew-install, integration-test-multiple-setups, integration-test-multiple-setups-reverse]
+          requires: [orb-tools/pack, test-install, test-install-version, test-install-override-version, integration-test-web-identity-with-profile, integration test web identity command with white spaces,integration-test-role-arn-config, test-install-override-version-with-latest, integration-test-skip-install-matched-version, integration-test-brew-install, integration-test-multiple-setups, integration-test-multiple-setups-reverse]
           filters: *release-filters
 executors:
   terraform:

src/commands/setup.yml

@@ -44,14 +44,14 @@ parameters:
       AWS access key. By default this will be set to the $AWS_ACCESS_KEY_ID.
       If you don't have these variable in your context, update the value.
     type: string
-    default: $AWS_ACCESS_KEY_ID
+    default: AWS_ACCESS_KEY_ID
 
   aws_secret_access_key:
     description: |
       AWS secret key. By default this will be set to the $AWS_SECRET_ACCESS_KEY.
       If you don't have these variable in your context, update the value.
     type: string
-    default: $AWS_SECRET_ACCESS_KEY
+    default: AWS_SECRET_ACCESS_KEY
 
   region:
     description: |

src/scripts/configure.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 #shellcheck disable=SC1090
-AWS_CLI_STR_ACCESS_KEY_ID="$(echo "$AWS_CLI_STR_ACCESS_KEY_ID" | circleci env subst)"
-AWS_CLI_STR_SECRET_ACCESS_KEY="$(echo "$AWS_CLI_STR_SECRET_ACCESS_KEY" | circleci env subst)"
+AWS_CLI_STR_ACCESS_KEY_ID="$(echo "\$$AWS_CLI_STR_ACCESS_KEY_ID" | circleci env subst)"
+AWS_CLI_STR_SECRET_ACCESS_KEY="$(echo "\$$AWS_CLI_STR_SECRET_ACCESS_KEY" | circleci env subst)"
 AWS_CLI_STR_SESSION_TOKEN="$(echo "$AWS_CLI_STR_SESSION_TOKEN" | circleci env subst)"
 AWS_CLI_STR_REGION="$(echo "$AWS_CLI_STR_REGION" | circleci env subst)"
 AWS_CLI_STR_PROFILE_NAME="$(echo "$AWS_CLI_STR_PROFILE_NAME" | circleci env subst)"