fix: extra build arg expansion (#310)

* ci: add addtional flag to extra_build_args

* fix: separate and rebuild string to prevent single quoting

* fix: sha expansion

Author: brivu

.circleci/test-deploy.yml

@@ -184,7 +184,7 @@ workflows:
           context: [CPE-OIDC]
           dockerfile: sample/Dockerfile
           path: workspace
-          extra_build_args: --cache-to type=local,dest=/tmp
+          extra_build_args: --cache-to type=local,dest=/tmp --compress
           push_image: false
           executor: amd64
           filters: *filters
@@ -312,7 +312,7 @@ workflows:
           profile_name: "OIDC-User"
           context: [CPE-OIDC]
           workspace_root: workspace
-          repo: aws-ecr-orb-${CIRCLE_SHA1:0:7}-skip_when_tags_exist-<<matrix.executor>>
+          repo: aws-ecr-orb-${CIRCLE_SHA1}-skip_when_tags_exist-<<matrix.executor>>
           tag: integration,myECRRepoTag
           dockerfile: sample/Dockerfile
           path: workspace

src/scripts/docker_buildx.sh

@@ -14,6 +14,13 @@ ORB_STR_PROFILE_NAME="$(circleci env subst "${ORB_STR_PROFILE_NAME}")"
 ORB_STR_PLATFORM="$(circleci env subst "${ORB_STR_PLATFORM}")"
 ORB_STR_LIFECYCLE_POLICY_PATH="$(circleci env subst "${ORB_STR_LIFECYCLE_POLICY_PATH}")"
 
+
+if [ -n "${ORB_STR_EXTRA_BUILD_ARGS}" ]; then
+  IFS=" " read -a args -r <<< "${ORB_STR_EXTRA_BUILD_ARGS[@]}"
+  for arg in "${args[@]}"; do
+    set -- "$@" "$arg"
+  done
+fi
 ECR_COMMAND="ecr"
 number_of_tags_in_ecr=0
 
@@ -80,7 +87,6 @@ set -x
     ${docker_tag_args:+$docker_tag_args} \
     --platform "${ORB_STR_PLATFORM}" \
     --progress plain \
-    ${ORB_STR_EXTRA_BUILD_ARGS:+$ORB_STR_EXTRA_BUILD_ARGS} \
     "$@" \
     "${ORB_EVAL_BUILD_PATH}"
 set +x