Skip to content

Commit ec740b0

Browse files
authored
Fix examples (#369)
* Fix examplesW * Fix name of registry_login parameter
1 parent 94bd383 commit ec740b0

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/examples/build_and_push_image_w_registry_login.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ usage:
1212
orbs:
1313
aws-ecr: circleci/[email protected]
1414
# importing aws-cli orb is required for authentication
15-
aws-cli: circleci/aws-cli@4.0
15+
aws-cli: circleci/aws-cli@5.1
1616
workflows:
1717
build-and-push-image-with-container-registry-login:
1818
jobs:
1919
- aws-ecr/build_and_push_image:
2020
# must set container registry login to true
2121
container_registry_login: true
22-
container_registry_login_step:
22+
registry_login:
2323
# custom login step for heroku.
2424
- run: docker login -u ${HEROKU_USERNAME} -p ${HEROKU_API_KEY}
2525
# custom login step for GitHub Container Registry.

src/examples/build_test_then_push_image.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ usage:
1010
orbs:
1111
aws-ecr: circleci/[email protected]
1212
# importing aws-cli orb is required for authentication
13-
aws-cli: circleci/aws-cli@4.0
13+
aws-cli: circleci/aws-cli@5.1
1414
jobs:
1515
build-test-then-push-with-buildx:
1616
machine:

src/examples/simple_build_and_push.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ usage:
88
orbs:
99
aws-ecr: circleci/[email protected]
1010
# Importing aws-cli orb is required
11-
aws-cli: circleci/aws-cli@4.0
11+
aws-cli: circleci/aws-cli@5.1
1212

1313
executors:
1414
base:
@@ -23,7 +23,7 @@ usage:
2323
auth:
2424
# Add authentication step with OIDC using aws-cli/setup command
2525
- aws-cli/setup:
26-
profile: "OIDC-USER"
26+
profile_name: "OIDC-USER"
2727
role_arn: "arn:aws:iam::123456789012:role/VALID_OIDC_ECR_ROLE"
2828

2929
# Must use same profile configured in aws-cli/setup command

0 commit comments

Comments
 (0)