Skip to content

Commit 4b8a6b4

Browse files
Work around bug in Grafana subchart (#52)
* Pin to last known good patch versions of dependency charts * Set ENFORCE_CACHE_LABELS=off on grafana-operator grafana/grafana-operator#1971 * Add additional logging to smoke test failures
1 parent eed324a commit 4b8a6b4

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

.circleci/config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,14 @@ jobs:
248248
name: Describe Pods on failure
249249
command: kubectl describe pods & exit 1
250250
when: on_fail
251+
- run:
252+
name: Describe Prometheus on failure
253+
command: kubectl describe prometheus & exit 1
254+
when: on_fail
255+
- run:
256+
name: Describe Grafana on failure
257+
command: kubectl describe grafana & exit 1
258+
when: on_fail
251259
- run:
252260
name: Uninstall Helm chart
253261
command: helm uninstall server-monitoring-stack -n server-monitoring

Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ description: A reference Helm chart for setting up a monitoring stack for Circle
44
version: 0.1.0-alpha.3
55
dependencies:
66
- name: prometheus-operator-crds
7-
version: 19.0.*
7+
version: 19.0.0
88
repository: "https://prometheus-community.github.io/helm-charts"
99
condition: prometheusOperator.installCRDs
1010
alias: prometheusOperator
1111
- name: grafana-operator
12-
version: 5.17.*
12+
version: 5.17.1
1313
repository: "https://grafana.github.io/helm-charts"
1414
alias: grafanaoperator
1515
condition: grafanaoperator.enabled

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ A reference Helm chart for setting up a monitoring stack for CircleCI server
2424

2525
| Repository | Name | Version |
2626
|------------|------|---------|
27-
| https://grafana.github.io/helm-charts | grafanaoperator(grafana-operator) | 5.17.* |
28-
| https://prometheus-community.github.io/helm-charts | prometheusOperator(prometheus-operator-crds) | 19.0.* |
27+
| https://grafana.github.io/helm-charts | grafanaoperator(grafana-operator) | 5.17.1 |
28+
| https://prometheus-community.github.io/helm-charts | prometheusOperator(prometheus-operator-crds) | 19.0.0 |
2929

3030
### 1. Configure Server for the Monitoring Stack
3131

@@ -184,7 +184,7 @@ Dashboards are provisioned directly from CRDs, which means any manual edits will
184184
| grafana.service.annotations | object | `{}` | Metadata annotations for the service. |
185185
| grafana.service.port | int | `3000` | Port on which the Grafana service will be exposed. |
186186
| grafana.service.type | string | `"ClusterIP"` | Specifies the type of service for Grafana. Options include ClusterIP, NodePort, or LoadBalancer. Use NodePort or LoadBalancer to expose Grafana externally. Ensure that grafana.credentials are set for security purposes. |
187-
| grafanaoperator | object | `{"fullnameOverride":"server-monitoring-grafana-operator","image":{"repository":"quay.io/grafana-operator/grafana-operator","tag":"v5.17.0"}}` | Full values for the Grafana Operator chart can be obtained at: https://github.com/grafana/grafana-operator/blob/master/deploy/helm/grafana-operator/values.yaml |
187+
| grafanaoperator | object | `{"env":[{"name":"ENFORCE_CACHE_LABELS","value":"off"}],"fullnameOverride":"server-monitoring-grafana-operator","image":{"repository":"quay.io/grafana-operator/grafana-operator","tag":"v5.17.0"}}` | Full values for the Grafana Operator chart can be obtained at: https://github.com/grafana/grafana-operator/blob/master/deploy/helm/grafana-operator/values.yaml |
188188
| grafanaoperator.fullnameOverride | string | `"server-monitoring-grafana-operator"` | Overrides the fully qualified app name. |
189189
| grafanaoperator.image.repository | string | `"quay.io/grafana-operator/grafana-operator"` | Image repository for the Grafana Operator. |
190190
| grafanaoperator.image.tag | string | `"v5.17.0"` | Tag for the Grafana Operator image. |

values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ grafanaoperator:
8181
repository: quay.io/grafana-operator/grafana-operator
8282
# -- Tag for the Grafana Operator image.
8383
tag: v5.17.0
84+
env:
85+
# https://github.com/grafana/grafana-operator/issues/1971
86+
- name: ENFORCE_CACHE_LABELS
87+
value: "off"
8488

8589
grafana:
8690
enabled: "-"

0 commit comments

Comments
 (0)