add lock and unlock jobs to the Go code for validation

Author: parkuman

pkg/parser/validate/jobs.go

@@ -21,11 +21,11 @@ func (val Validate) validateSingleJob(job ast.Job) {
 
 	val.validateSteps(job.Steps, job.Name, job.Parameters)
 
-	if job.Steps != nil && (job.Type == "approval" || job.Type == "no-op" || job.Type == "release") {
+	if job.Steps != nil && job.Type != "" && job.Type != "build" {
 		val.addDiagnostic(
 			protocol.Diagnostic{
 				Range:    job.StepsRange,
-				Message:  "If job type is approval, no-op or release, then steps will be ignored.",
+				Message:  "Steps only exist in `build` jobs. Steps here will be ignored.",
 				Severity: protocol.DiagnosticSeverityWarning,
 			},
 		)

pkg/parser/validate/jobs_test.go

@@ -315,7 +315,7 @@ func TestJobTypeValidation(t *testing.T) {
 					End:   protocol.Position{Line: 2, Character: 18},
 				},
 				Severity: protocol.DiagnosticSeverityError,
-				Message:  "Invalid job type 'bad-type'. Allowed types: approval, build, no-op, release",
+				Message:  "Invalid job type 'bad-type'. Allowed types: approval, build, no-op, release, lock, unlock",
 			},
 		},
 		{
@@ -331,7 +331,7 @@ func TestJobTypeValidation(t *testing.T) {
 					End:   protocol.Position{Line: 4, Character: 16},
 				},
 				Severity: protocol.DiagnosticSeverityWarning,
-				Message:  "If job type is approval, no-op or release, then steps will be ignored.",
+				Message:  "Steps only exist in `build` jobs. Steps here will be ignored.",
 			},
 		},
 	}

pkg/utils/jobs.go

@@ -22,4 +22,6 @@ var JobTypes = []string{
 	"build", // default
 	"no-op",
 	"release",
+	"lock",
+	"unlock",
 }