Improve behavior of retries to add more information and customization (#71)

* Improve behavior of retries to add more information and customization

* Add debug option

* Update wait time between retries

* Update release test

* Remove debug and increase wait time

Author: marboledacci

.circleci/test-deploy.yml

@@ -66,13 +66,15 @@ workflows:
               executor: ["docker-x86-debian", "apple-silicon-14", "apple-silicon-15", "linuxvm-arm-ubuntu-2004", "linuxvm-x86-ubuntu-2004", "linuxvm-arm-ubuntu-2204", "linuxvm-x86-ubuntu-2204", "linuxvm-arm-ubuntu-2404", "linuxvm-x86-ubuntu-2404"]
               version: [2.27.0, 2.40.0, "latest"] # 2.27.0 is the last version that uses ".tar.gz" instead of ".zip" for macOS
       - github-cli/release:
-          tag: "test-release-$CIRCLE_SHA1"
+          tag: "test-release"
           title: Test
           prerelease: true
           files: README.md
           context: orb-developer
           token: GHI_TOKEN
           additional_args: --generate-notes
+          post-steps:
+            - run: gh release delete test-release --cleanup-tag -y
       - orb-tools/pack:
           filters: *release-filters
       - orb-tools/publish:

src/commands/install.yml

@@ -10,10 +10,16 @@ parameters:
     type: string
     default: "on_success"
     description: Specify when to run this command. Options are "on_success", "always" or "on_fail".
+  max_retries:
+    type: integer
+    default: 5
+    description: Max of retries to do when the request to github releases fails.
+
 steps:
   - run:
       environment:
         PARAM_GH_CLI_VERSION: <<parameters.version>>
+        PARAM_GH_MAX_RETRIES: <<parameters.max_retries>>
       name: Install GH CLI v<<parameters.version>>
       command: <<include(scripts/install.sh)>>
       when: <<parameters.when>>

src/scripts/install.sh

@@ -32,7 +32,7 @@ download_gh_cli() {
     local platform=$1
     local file_extension=$2
     if [ "$PARAM_GH_CLI_VERSION" = "latest" ]; then
-        max_retries=3
+        max_retries=$PARAM_GH_MAX_RETRIES
         i=0
         while (( i < max_retries )); do
             ((i++))
@@ -41,10 +41,10 @@ download_gh_cli() {
                 break
             fi
             echo "Couldn't get latest version, retrying..."
-            sleep 3
+            sleep 60
         done
         if (( i == max_retries )); then
-            echo "Erro: Max retries exceeded"
+            echo "Error: Max retries exceeded."
             exit 1
         fi