Add option to update the contents of a notification instead of posting a threaded reply to it #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat.postMessage. instead of providing ts_thread to refer to a thread in the body, ts is used to reference the specific top level message in the thread that will be updated.
…essages to a thread
… a top level message
christophe-SA
force-pushed
the
updateNotification
branch
from
e962c2e to
d29b59b
Compare
Contributor
|
I have run the tests for this, and they are passing, but I don't think it is working as expected. @christophe-SA is the test I added a good example of what this PR supports? How should the result of it be, because I'm getting a normal slack message from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SEMVER Update Type:
Description:
add
update_notificationflag tonotifyjob, which will update the top level message in the thread instead of appending a new message to the bottom of the thread. If no thread is found or no thread is specified, defaults to a regular notification posting.also added a charset to the slack api curl statement to address the
missing charsetwarning from the slack apiMotivation:
By updating the top level message instead of posting threaded replied, it is easy to update the progress of a job without sending new notifications for each update. This also allows for links or actions to be "enabled" after the job completes, such as when a deploy is successful, providing next steps and additional info in the top level message.
not dissimilar to https://github.com/CircleCI-Public/slack-orb/pull/466/files
Closes Issues:
Checklist: