mfd: clsic: tidy some trivial static analysis warnings

simontrimmer · Lucas Tanure · commit 07c0eb18f5b9 · 2019-07-31T10:08:19.000+01:00
- missing a default case (when all possible variables were included)
- function only used in that file could be static
- include file to check definitions of functions being exported

Change-Id: Id7a36421cdbe598b8f023c3b5f402f96acee634e
Signed-off-by: Simon Trimmer &lt;simont@opensource.cirrus.com&gt;
diff --git a/drivers/mfd/clsic/clsic-rassrv-irq.c b/drivers/mfd/clsic/clsic-rassrv-irq.c
@@ -240,6 +240,7 @@ void clsic_ras_irq_handler(struct clsic *clsic,
 	case CLSIC_RAS_IRQ_STATE_IDLE:
 	case CLSIC_RAS_IRQ_STATE_DISABLING:
 	case CLSIC_RAS_IRQ_STATE_DISABLED:
+	default:
 		/* Do nothing / not interested */
 		break;
 	}
diff --git a/drivers/mfd/clsic/clsic-rassrv.c b/drivers/mfd/clsic/clsic-rassrv.c
@@ -187,7 +187,7 @@ static int clsic_ras_simple_readregister(struct clsic_ras_struct *ras,
  * Not checking the return code of the message sending as the test fails safe
  * (response structure is cleared and the test depends on the bit being set)
  */
-void clsic_ras_write_fastpath_init(struct clsic_ras_struct *ras)
+static void clsic_ras_write_fastpath_init(struct clsic_ras_struct *ras)
 {
 	struct clsic *clsic;
 	union clsic_ras_msg msg_cmd;
diff --git a/drivers/mfd/clsic/clsic-tacna.c b/drivers/mfd/clsic/clsic-tacna.c
@@ -14,6 +14,7 @@
 #include <linux/mfd/core.h>
 #include <linux/mfd/tacna/core.h>
 #include <linux/module.h>
+#include <linux/mfd/clsic/clsic-tacna.h>
 
 #define CLSIC_32K_MCLK2		1
 

Original file line number	Diff line number	Diff line change
`@@ -240,6 +240,7 @@ void clsic_ras_irq_handler(struct clsic *clsic,`
`240`	`240`	`case CLSIC_RAS_IRQ_STATE_IDLE:`
`241`	`241`	`case CLSIC_RAS_IRQ_STATE_DISABLING:`
`242`	`242`	`case CLSIC_RAS_IRQ_STATE_DISABLED:`
	`243`	`+ default:`
`243`	`244`	`/* Do nothing / not interested */`
`244`	`245`	`break;`
`245`	`246`	`}`
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ static int clsic_ras_simple_readregister(struct clsic_ras_struct *ras,`
`187`	`187`	`* Not checking the return code of the message sending as the test fails safe`
`188`	`188`	`* (response structure is cleared and the test depends on the bit being set)`
`189`	`189`	`*/`
`190`		`-void clsic_ras_write_fastpath_init(struct clsic_ras_struct *ras)`
	`190`	`+static void clsic_ras_write_fastpath_init(struct clsic_ras_struct *ras)`
`191`	`191`	`{`
`192`	`192`	`struct clsic *clsic;`
`193`	`193`	`union clsic_ras_msg msg_cmd;`