@@ -547,12 +547,12 @@ struct wm_adsp_alg_xm_struct {
547547};
548548
549549struct wm_adsp_buffer {
550- __be32 X_buf_base ; /* XM base addr of first X area */
551- __be32 X_buf_size ; /* Size of 1st X area in words */
552- __be32 X_buf_base2 ; /* XM base addr of 2nd X area */
553- __be32 X_buf_brk ; /* Total X size in words */
554- __be32 Y_buf_base ; /* YM base addr of Y area */
555- __be32 wrap ; /* Total size X and Y in words */
550+ __be32 buf1_base ; /* Base addr of first buffer area */
551+ __be32 buf1_size ; /* Size of buf1 area in DSP words */
552+ __be32 buf2_base ; /* Base addr of 2nd buffer area */
553+ __be32 buf1_buf2_size ; /* Size of buf1+buf2 in DSP words */
554+ __be32 buf3_base ; /* Base addr of buf3 area */
555+ __be32 buf_total_size ; /* Size of buf1+buf2+buf3 in DSP words */
556556 __be32 high_water_mark ; /* Point at which IRQ is asserted */
557557 __be32 irq_count ; /* bits 1-31 count IRQ assertions */
558558 __be32 irq_ack ; /* acked IRQ count, bit 0 enables IRQ */
@@ -629,18 +629,18 @@ struct wm_adsp_buffer_region_def {
629629static const struct wm_adsp_buffer_region_def default_regions [] = {
630630 {
631631 .mem_type = WMFW_ADSP2_XM ,
632- .base_offset = HOST_BUFFER_FIELD (X_buf_base ),
633- .size_offset = HOST_BUFFER_FIELD (X_buf_size ),
632+ .base_offset = HOST_BUFFER_FIELD (buf1_base ),
633+ .size_offset = HOST_BUFFER_FIELD (buf1_size ),
634634 },
635635 {
636636 .mem_type = WMFW_ADSP2_XM ,
637- .base_offset = HOST_BUFFER_FIELD (X_buf_base2 ),
638- .size_offset = HOST_BUFFER_FIELD (X_buf_brk ),
637+ .base_offset = HOST_BUFFER_FIELD (buf2_base ),
638+ .size_offset = HOST_BUFFER_FIELD (buf1_buf2_size ),
639639 },
640640 {
641641 .mem_type = WMFW_ADSP2_YM ,
642- .base_offset = HOST_BUFFER_FIELD (Y_buf_base ),
643- .size_offset = HOST_BUFFER_FIELD (wrap ),
642+ .base_offset = HOST_BUFFER_FIELD (buf3_base ),
643+ .size_offset = HOST_BUFFER_FIELD (buf_total_size ),
644644 },
645645};
646646
@@ -1084,21 +1084,21 @@ static void wm_adsp2v2_show_fw_status(struct wm_adsp *dsp)
10841084
10851085static void wm_halo_show_fw_status (struct wm_adsp * dsp )
10861086{
1087- u32 scratch [4 ];
1088- int ret ;
1087+ unsigned int scratch [4 ];
1088+ unsigned int addr = dsp -> base + HALO_SCRATCH1 ;
1089+ int ret , i ;
10891090
1090- ret = regmap_raw_read (dsp -> regmap , dsp -> base + HALO_SCRATCH1 ,
1091- scratch , sizeof (scratch ));
1092- if (ret ) {
1093- adsp_err (dsp , "Failed to read SCRATCH regs: %d\n" , ret );
1094- return ;
1091+ for (i = 0 ; i < ARRAY_SIZE (scratch ); i ++ ) {
1092+ ret = regmap_read (dsp -> regmap , addr , & scratch [i ]);
1093+ addr += 8 ;
1094+ if (ret ) {
1095+ adsp_err (dsp , "Failed to read SCRATCH regs: %d\n" , ret );
1096+ return ;
1097+ }
10951098 }
10961099
10971100 adsp_dbg (dsp , "FW SCRATCH 1:0x%x 2:0x%x 3:0x%x 4:0x%x\n" ,
1098- be32_to_cpu (scratch [0 ]),
1099- be32_to_cpu (scratch [1 ]),
1100- be32_to_cpu (scratch [2 ]),
1101- be32_to_cpu (scratch [3 ]));
1101+ scratch [0 ], scratch [1 ], scratch [2 ], scratch [3 ]);
11021102}
11031103
11041104static inline struct wm_coeff_ctl * bytes_ext_to_ctl (struct soc_bytes_ext * ext )
@@ -3834,7 +3834,7 @@ int wm_adsp2_codec_probe(struct wm_adsp *dsp, struct snd_soc_codec *codec)
38343834{
38353835 char preload [32 ];
38363836
3837- if (!dsp -> no_preloader ){
3837+ if (!dsp -> no_preloader ) {
38383838 snprintf (preload , ARRAY_SIZE (preload ), "%s Preload" , dsp -> name );
38393839 snd_soc_component_disable_pin (& codec -> component , preload );
38403840 }
@@ -4346,7 +4346,7 @@ static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
43464346 region -> cumulative_size = offset ;
43474347
43484348 adsp_dbg (buf -> dsp ,
4349- "region=%d type=%d base=%04x off=%04x size=%04x \n" ,
4349+ "region=%d type=%d base=%08x off=%08x size=%08x \n" ,
43504350 i , region -> mem_type , region -> base_addr ,
43514351 region -> offset , region -> cumulative_size );
43524352 }
0 commit comments