graph updates complex foreign key fixes

Author: ChrisJollyAU

src/EFCore.Jet.Data/JetDataReader.cs

@@ -544,5 +544,17 @@ public override T GetFieldValue<T>(int ordinal)
 
             return (T)GetValue(ordinal);
         }
+
+        protected override void Dispose(bool disposing)
+        {
+            if (disposing)
+            {
+                _wrappedDataReader.Dispose();
+            }
+#if DEBUG
+            Interlocked.Decrement(ref _activeObjectsCount);
+#endif
+            base.Dispose(disposing);
+        }
     }
 }

test/EFCore.Jet.FunctionalTests/GraphUpdates/GraphUpdatesJetTestBase.cs

@@ -230,6 +230,7 @@ protected override async Task SeedAsync(PoolableDbContext context)
             await context.Database.ExecuteSqlAsync($"ALTER TABLE `OwnedOptional2` DROP CONSTRAINT `FK_OwnedOptional2_OwnedOptional1_OwnedOptional1OwnerRootId_Owne~`");
             await context.Database.ExecuteSqlAsync($"ALTER TABLE `OwnedRequired2` DROP CONSTRAINT `FK_OwnedRequired2_OwnedRequired1_OwnedRequired1OwnerRootId_Owne~`");
             await context.Database.ExecuteSqlAsync($"ALTER TABLE `RequiredComposite2` DROP CONSTRAINT `FK_RequiredComposite2_RequiredAk1_ParentId_ParentAlternateId`");
+            await context.Database.ExecuteSqlAsync($"ALTER TABLE `SharedFkParent` DROP CONSTRAINT `FK_SharedFkParent_SharedFkDependant_RootId_DependantId`");
         }
     }
 }

test/EFCore.Jet.FunctionalTests/GraphUpdates/ProxyGraphUpdatesJetTest.cs

@@ -32,10 +32,16 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con
                     modelBuilder.Entity<SharedFkParent>().Property(x => x.Id).HasColumnType("int");
                 }
 
-                protected override Task SeedAsync(DbContext context)
+                protected override async Task SeedAsync(DbContext context)
                 {
                     //context.Database.ExecuteSql($"ALTER TABLE `SharedFkDependant` DROP CONSTRAINT `AK_SharedFkDependant_RootId_Id`");
-                    return base.SeedAsync(context);
+                    await base.SeedAsync(context);
+
+                    await context.Database.ExecuteSqlAsync($"ALTER TABLE `OptionalComposite2` DROP CONSTRAINT `FK_OptionalComposite2_OptionalAk1_ParentId_ParentAlternateId`");
+                    await context.Database.ExecuteSqlAsync($"ALTER TABLE `OptionalOverlapping2` DROP CONSTRAINT `FK_OptionalOverlapping2_RequiredComposite1_ParentId_ParentAlter~`");
+                    await context.Database.ExecuteSqlAsync($"ALTER TABLE `OptionalSingleComposite2` DROP CONSTRAINT `FK_OptionalSingleComposite2_OptionalSingleAk1_BackId_ParentAlte~`");
+                    await context.Database.ExecuteSqlAsync($"ALTER TABLE `RequiredComposite2` DROP CONSTRAINT `FK_RequiredComposite2_RequiredAk1_ParentId_ParentAlternateId`");
+                    await context.Database.ExecuteSqlAsync($"ALTER TABLE `SharedFkParent` DROP CONSTRAINT `FK_SharedFkParent_SharedFkDependant_RootId_DependantId`");
                 }
             }
         }