Improve Null Semantics tests (#260)

ChrisJollyAU · github-actions · web-flow · commit f199d04cbae6 · 2024-08-29T23:15:37.000+08:00
* Add missing test overrides
Fix sql literal output from a BoolTypeMapping

* [GitHub Actions] Update green tests.

---------

Co-authored-by: github-actions &lt;github-actions@github.com&gt;
diff --git a/src/EFCore.Jet/Query/Sql/Internal/JetQuerySqlGenerator.cs b/src/EFCore.Jet/Query/Sql/Internal/JetQuerySqlGenerator.cs
@@ -608,6 +608,12 @@ protected override Expression VisitSqlConstant(SqlConstantExpression sqlConstant
                 Sql.Append(")");
                 return sqlConstantExpression;
             }
+
+            if (sqlConstantExpression.TypeMapping is BoolTypeMapping and not JetBoolTypeMapping)
+            {
+                Sql.Append((bool)sqlConstantExpression.Value! ? "TRUE" : "FALSE");
+                return sqlConstantExpression;
+            }
             return base.VisitSqlConstant(sqlConstantExpression);
         }
 
diff --git a/test/EFCore.Jet.FunctionalTests/GreenTests/ace_2010_odbc_x86.txt b/test/EFCore.Jet.FunctionalTests/GreenTests/ace_2010_odbc_x86.txt
@@ -16660,6 +16660,8 @@ EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.Bool_not
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.Bool_not_equal_nullable_int_HasValue(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_predicate(async: False)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_predicate(async: True)
+EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_projection(async: False)
+EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_projection(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_filter(async: False)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_filter(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_select(async: False)
diff --git a/test/EFCore.Jet.FunctionalTests/GreenTests/ace_2010_oledb_x86.txt b/test/EFCore.Jet.FunctionalTests/GreenTests/ace_2010_oledb_x86.txt
@@ -17968,6 +17968,8 @@ EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.Bool_not
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.Bool_not_equal_nullable_int_HasValue(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_predicate(async: False)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_predicate(async: True)
+EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_projection(async: False)
+EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseOpWhen_projection(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_filter(async: False)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_filter(async: True)
 EntityFrameworkCore.Jet.FunctionalTests.Query.NullSemanticsQueryJetTest.CaseWhen_equal_to_first_or_third_select(async: False)
diff --git a/test/EFCore.Jet.FunctionalTests/Query/NullSemanticsQueryJetTest.cs b/test/EFCore.Jet.FunctionalTests/Query/NullSemanticsQueryJetTest.cs

Original file line number	Diff line number	Diff line change
`@@ -608,6 +608,12 @@ protected override Expression VisitSqlConstant(SqlConstantExpression sqlConstant`
`608`	`608`	`Sql.Append(")");`
`609`	`609`	`return sqlConstantExpression;`
`610`	`610`	`}`
	`611`	`+`
	`612`	`+ if (sqlConstantExpression.TypeMapping is BoolTypeMapping and not JetBoolTypeMapping)`
	`613`	`+ {`
	`614`	`+ Sql.Append((bool)sqlConstantExpression.Value! ? "TRUE" : "FALSE");`
	`615`	`+ return sqlConstantExpression;`
	`616`	`+ }`
`611`	`617`	`return base.VisitSqlConstant(sqlConstantExpression);`
`612`	`618`	`}`
`613`	`619`