add support for disable_lacp_suspend_individual for non-vpc port-channels (#494)

* add support for disable_lacp_suspend_individual for non-vpc port-channels

* modifying test files

* Update test_dcnm_intf.py

Author: mkilar123

docs/cisco.dcnm.dcnm_interface_module.rst

@@ -1146,6 +1146,27 @@ Parameters
                         <div>Description of the interface</div>
                 </td>
             </tr>
+            <tr>
+                    <td class="elbow-placeholder"></td>
+                    <td class="elbow-placeholder"></td>
+                <td colspan="1">
+                    <div class="ansibleOptionAnchor" id="parameter-"></div>
+                    <b>disable_lacp_suspend_individual</b>
+                    <a class="ansibleOptionLink" href="#parameter-" title="Permalink to this option"></a>
+                    <div style="font-size: small">
+                        <span style="color: purple">boolean</span>
+                    </div>
+                </td>
+                <td>
+                        <ul style="margin: 0; padding: 0"><b>Choices:</b>
+                                    <li><div style="color: blue"><b>no</b>&nbsp;&larr;</div></li>
+                                    <li>yes</li>
+                        </ul>
+                </td>
+                <td>
+                        <div>If disabled, lacp will put the port to individual state and not suspend the port in case the port does not get LACP BPDU from the peer ports in the port-channel</div>
+                </td>
+            </tr>
             <tr>
                     <td class="elbow-placeholder"></td>
                     <td class="elbow-placeholder"></td>

plugins/modules/dcnm_interface.py

@@ -196,6 +196,12 @@
             - State of Switchport Monitor for SPAN/ERSPAN
             type: bool
             default: false
+          disable_lacp_suspend_individual:
+            description:
+            - If disabled, lacp will put the port to individual state and not suspend the port
+              in case the port does not get LACP BPDU from the peer ports in the port-channel
+            type: bool
+            default: false
           lacp_port_priority:
             description:
             - <1-65535> Set LACP port priority on member interfaces, default is 32768
@@ -2348,6 +2354,7 @@ def dcnm_intf_validate_port_channel_input(self, config):
             enable_pfc=dict(type="bool", default=False),
             duplex=dict(
                 type="str", default="auto", choices=["auto", "full", "half"]),
+            disable_lacp_suspend_individual=dict(type="bool", default=False),
             lacp_port_priority=dict(type="int", default=32768, range_min=1, range_max=65535),
             lacp_rate=dict(type="str", default="normal"),
         )
@@ -2370,6 +2377,7 @@ def dcnm_intf_validate_port_channel_input(self, config):
             enable_pfc=dict(type="bool", default=False),
             duplex=dict(
                 type="str", default="auto", choices=["auto", "full", "half"]),
+            disable_lacp_suspend_individual=dict(type="bool", default=False),
             lacp_port_priority=dict(type="int", default=32768, range_min=1, range_max=65535),
             lacp_rate=dict(type="str", default="normal"),
         )
@@ -2946,6 +2954,10 @@ def dcnm_intf_get_pc_payload(self, delem, intf, profile):
                 "ENABLE_MONITOR"] = delem[profile]["enable_monitor"]
             intf["interfaces"][0]["nvPairs"][
                 "PORT_DUPLEX_MODE"] = delem[profile]["duplex"]
+            if delem[profile].get("disable_lacp_suspend_individual"):
+                intf["interfaces"][0]["nvPairs"]["DISABLE_LACP_SUSPEND"] = delem[profile]["disable_lacp_suspend_individual"]
+            else:
+                intf["interfaces"][0]["nvPairs"]["DISABLE_LACP_SUSPEND"] = False
             if delem[profile].get("lacp_port_priority"):
                 intf["interfaces"][0]["nvPairs"]["LACP_PORT_PRIO"] = delem[profile]["lacp_port_priority"]
             else:
@@ -2987,6 +2999,10 @@ def dcnm_intf_get_pc_payload(self, delem, intf, profile):
                 "ENABLE_MONITOR"] = delem[profile]["enable_monitor"]
             intf["interfaces"][0]["nvPairs"][
                 "PORT_DUPLEX_MODE"] = delem[profile]["duplex"]
+            if delem[profile].get("disable_lacp_suspend_individual"):
+                intf["interfaces"][0]["nvPairs"]["DISABLE_LACP_SUSPEND"] = delem[profile]["disable_lacp_suspend_individual"]
+            else:
+                intf["interfaces"][0]["nvPairs"]["DISABLE_LACP_SUSPEND"] = False
             if delem[profile].get("lacp_port_priority"):
                 intf["interfaces"][0]["nvPairs"]["LACP_PORT_PRIO"] = delem[profile]["lacp_port_priority"]
             else:

tests/unit/modules/dcnm/test_dcnm_intf.py

@@ -2997,6 +2997,7 @@ def test_dcnm_intf_pc_replaced_existing(self):
             "ROUTING_TAG",
             "SPEED",
             "CONF",
+            "DISABLE_LACP_SUSPEND",
             "LACP_PORT_PRIO",
             "LACP_RATE"
         ]