Remove breakout ints for preprov devices (#509)

Author: mikewiebe

plugins/modules/dcnm_interface.py

@@ -1916,6 +1916,8 @@ def __init__(self, module):
         self.dcnm_version = dcnm_version_supported(self.module)
 
         self.inventory_data = {}
+        self.manageable = []
+        self.unmanageable = []
 
         self.paths = self.dcnm_intf_paths[self.dcnm_version]
 
@@ -3946,7 +3948,10 @@ def dcnm_intf_get_have_all_breakout_interfaces(self, sno):
         if resp and "DATA" in resp and resp["DATA"]:
             for elem in resp["DATA"]:
                 if elem.get('templateName', None) == "breakout_interface":
-                    breakout.append(elem['entityName'])
+                    # Make sure the serial number for this device is a manageable device
+                    # We cannot manage breakout interfaces for pre-provisioned devices
+                    if elem.get('serialNumber') in self.manageable.values():
+                        breakout.append(elem['entityName'])
             self.have_breakout.append({sno: breakout})
 
     def dcnm_intf_get_have_all(self, sw):
@@ -5812,22 +5817,26 @@ def dcnm_intf_update_inventory_data(self):
 
         if self.module.params["state"] != "query":
 
-            # Get all switches which are managable. Changes must be avoided to all switches which are not part of this list
-            managable_ip = [
-                (key, self.inventory_data[key]["serialNumber"])
-                for key in self.inventory_data
-                if str(self.inventory_data[key]["managable"]).lower() == "true"
-            ]
-            managable_hosts = [
-                (
-                    self.inventory_data[key]["logicalName"],
-                    self.inventory_data[key]["serialNumber"],
-                )
-                for key in self.inventory_data
-                if str(self.inventory_data[key]["managable"]).lower() == "true"
-            ]
+            # Get all switches which are manageable and unmanageable
+            manageable_ip = []
+            manageable_hosts = []
+            unmanageable_ip = []
+            unmanageable_hosts = []
+
+            for key in self.inventory_data:
+                serial_number = self.inventory_data[key]["serialNumber"]
+                logical_name = self.inventory_data[key]["logicalName"]
+                is_manageable = str(self.inventory_data[key]["managable"]).lower() == "true"
+
+                if is_manageable:
+                    manageable_ip.append((key, serial_number))
+                    manageable_hosts.append((logical_name, serial_number))
+                else:
+                    unmanageable_ip.append((key, serial_number))
+                    unmanageable_hosts.append((logical_name, serial_number))
 
-            managable = dict(managable_ip + managable_hosts)
+            self.manageable = dict(manageable_ip + manageable_hosts)
+            self.unmanageable = dict(unmanageable_ip + unmanageable_hosts)
 
             # Build a mapping of serial numbers to switch roles. This will be required to build default ethernet
             # payload during overridden state. for switch role leaf the default policy for ethernet interface must
@@ -5842,13 +5851,13 @@ def dcnm_intf_update_inventory_data(self):
                     }
                 )
 
-            # Get all switches which are managable. Deploy must be avoided to all switches which are not part of this list
+            # Get all switches which are manageable. Deploy must be avoided to all switches which are not part of this list
             ronly_sw_list = []
             for cfg in self.config:
-                # Check if there are any switches which are not managable in the config.
+                # Check if there are any switches which are not manageable in the config.
                 if cfg.get("switch", None) is not None:
                     for sw in cfg["switch"]:
-                        if sw not in managable:
+                        if sw not in self.manageable:
                             if sw not in ronly_sw_list:
                                 ronly_sw_list.append(sw)