Partial lint-changes

Author: sivakasi-cisco

playbooks/roles/dcnm_bootflash/create_files.yaml

@@ -1,5 +1,6 @@
 ---
-- gather_facts: false
+- name: Create bootflash files on switch1
+  gather_facts: false
   hosts:
     - switch1
   tasks:
@@ -13,7 +14,8 @@
           - echo 1 > bootflash: /{{ nxos_vars.switch1_file3 }}
           - echo 1 > bootflash: /{{ nxos_vars.switch1_file4 }}
 
-- gather_facts: false
+- name: Create bootflash files on switch2
+  gather_facts: false
   hosts:
     - switch2
   tasks:

tests/integration/targets/dcnm_maintenance_mode/tasks/main.yaml

@@ -1,2 +1,4 @@
 ---
-- { include_tasks: dcnm.yaml, tags: ['dcnm'] }
+- name: Include dcnm.yaml
+  ansible.builtin.include_tasks: dcnm.yaml
+  tags: ['dcnm']

tests/integration/targets/dcnm_network/tasks/main.yaml

@@ -30,6 +30,7 @@
   ansible.builtin.template:
     src: "{{ test_data_setup.vrf_conf_template }}"
     dest: "{{ test_data_setup.vrf_conf_file }}"
+    mode: "0644"
   delegate_to: localhost
   tags: always
 

tests/integration/targets/dcnm_policy/tasks/main.yaml

@@ -1,2 +1,4 @@
 ---
-- { ansible.builtin.include_tasks: dcnm.yaml, tags: ['dcnm'] }
+- name: Include dcnm.yaml
+  ansible.builtin.include_tasks: dcnm.yaml
+  tags: ['dcnm']

tests/integration/targets/dcnm_vrf/tasks/dcnm.yaml

@@ -18,11 +18,11 @@
     test_items: "{{ test_cases.files | map(attribute='path') | list }}"
   tags: sanity
 
-- name: debug
+- name: Debug test_items
   ansible.builtin.debug:
     var: test_items
 
-- name: debug
+- name: Debug testcase
   ansible.builtin.debug:
     var: testcase
 

tests/integration/targets/prepare_dcnm_intf/tasks/main.yaml

@@ -290,15 +290,15 @@
     method: POST
     path: "{{ vpc_create_path[controller_version] }}"
     json_data:
-      "{{ vpc_vxlan_data | to_json}}"
+      "{{ vpc_vxlan_data | to_json }}"
   register: result
-  when: (vxlan_vpc_create == True)
+  when: (vxlan_vpc_create | bool)
   ignore_errors: true
 
 - name: Wait for 10 secs
   ansible.builtin.wait_for:
     timeout: 10
-  when: (vxlan_vpc_create == True)
+  when: (vxlan_vpc_create | bool)
 
 ##############################################
 ##          CONFIG SAVE                     ##
@@ -309,7 +309,7 @@
     method: POST
     path: "{{ vxlan_config_save_path[controller_version] }}"
   register: result
-  when: (vxlan_vpc_create == True)
+  when: (vxlan_vpc_create | bool)
   ignore_errors: true
 
 ##############################################
@@ -324,13 +324,13 @@
   with_sequence: count=1
   loop_control:
     pause: 5
-  when: (vxlan_vpc_deploy == True)
+  when: (vxlan_vpc_deploy | bool)
   ignore_errors: true
 
 - name: Wait for 30 secs
   ansible.builtin.wait_for:
     timeout: 30
-  when: (vxlan_vpc_deploy == True)
+  when: (vxlan_vpc_deploy | bool)
 
 ##############################################
 ##          CREATE CXT VPC PAIR             ##
@@ -341,15 +341,15 @@
     method: POST
     path: "{{ vpc_create_path[controller_version] }}"
     json_data:
-      "{{ vpc_cxt_data | to_json}}"
+      "{{ vpc_cxt_data | to_json }}"
   register: result
-  when: (cxt_vpc_create == True)
+  when: (cxt_vpc_create | bool)
   ignore_errors: true
 
 - name: Wait for 20 secs
   ansible.builtin.wait_for:
     timeout: 10
-  when: (cxt_vpc_create == True)
+  when: (cxt_vpc_create | bool)
 
 ##############################################
 ##          CONFIG SAVE                     ##
@@ -360,7 +360,7 @@
     method: POST
     path: "{{ cxt_config_save_path[controller_version] }}"
   register: result
-  when: (cxt_vpc_create == True)
+  when: (cxt_vpc_create | bool)
   ignore_errors: true
 
 ##############################################
@@ -375,10 +375,10 @@
   with_sequence: count=1
   loop_control:
     pause: 5
-  when: (cxt_vpc_deploy == True)
+  when: (cxt_vpc_deploy | bool)
   ignore_errors: true
 
 - name: Wait for 30 secs
   ansible.builtin.wait_for:
     timeout: 30
-  when: (cxt_vpc_deploy == True)
+  when: (cxt_vpc_deploy | bool)

tests/integration/targets/prepare_dcnm_policy/tasks/main.yaml

@@ -55,7 +55,8 @@
   loop: '{{ result.response }}'
   tags: sanity
 
-- block:
+- name: Create and deploy templates
+  block:
 
 ##############################################
 ##                MERGE                     ##