Sanity errors

Author: prabahal

plugins/modules/dcnm_fabric_member.py

@@ -124,9 +124,9 @@
 from ..module_utils.msd.delete_child_fab import childFabricDelete
 from ..module_utils.msd.add_child_fab import childFabricAdd
 from ..module_utils.msd.fabric_associations import FabricAssociations
-from ..module_utils.fabric.verify_playbook_params import VerifyPlaybookParams
 from ..module_utils.network.dcnm.dcnm import validate_list_of_dicts
 
+
 @Properties.add_rest_send
 class childCommon():
     """
@@ -217,25 +217,19 @@ def verify_child_fabric_is_already_member(self, item) -> bool:
                 if (self.data[fabric]['fabricParent'] == item["destFabric"]):
                     return True
         return False
-    
+
     def validate_input(self):
-        if self.state != "query":
-            fab_member_spec = dict(
-                FABRIC_NAME=dict(required=True, type="str"),
-                CHILD_FABRIC_NAME=dict(required=True, type="str"),
-                DEPLOY=dict(type="bool", default=False),
-            )
-        else:
-            fab_member_spec = dict(
-                FABRIC_NAME=dict(type="str"),
-            )            
+        method_name = inspect.stack()[0][3]
+        fab_member_spec = dict(
+            FABRIC_NAME=dict(required=True, type="str"),
+            CHILD_FABRIC_NAME=dict(required=True, type="str"),
+            DEPLOY=dict(type="bool", default=False),
+        )
         fab_mem_info, invalid_params = validate_list_of_dicts(self.config, fab_member_spec, None)
         if invalid_params:
-            mesg = "Invalid parameters in playbook: {0}".format(
-            "while processing config "
-            + "\n".join(invalid_params)
-            )
-            raise ValueError(mesg)
+            msg = "Invalid parameters in playbook: {invalid_params}"
+            msg += "while processing config \n"
+            raise ValueError(msg)
         for config in self.config:
             if not isinstance(config, dict):
                 msg = f"{self.class_name}.{method_name}: "
@@ -389,7 +383,6 @@ def commit(self) -> None:
 
         msg = f"ENTERED: {self.class_name}.{method_name}"
         self.log.debug(msg)
-        
         self.validate_input()
         self.get_want()
 
@@ -482,7 +475,7 @@ def commit(self) -> None:
         msg = f"ENTERED: {self.class_name}.{method_name}"
         self.log.debug(msg)
         self.get_controller_version()
-        ### Version validation needs to be added
+        # Version validation needs to be added
         self.validate_input()
         self.get_want()
 

tests/sanity/ignore-2.15.txt

@@ -25,3 +25,4 @@ plugins/module_utils/common/sender_requests.py import-3.9 # TODO remove this if/
 plugins/module_utils/common/sender_requests.py import-3.10 # TODO remove this if/when requests is added to the standard library
 plugins/module_utils/common/sender_requests.py import-3.11 # TODO remove this if/when requests is added to the standard library
 plugins/modules/dcnm_fabric_member.py validate-modules:missing-gplv3-license # GPLv3 license header not found in the first 20 lines of the module
+plugins/action/tests/unit/ndfc_pc_members_validate.py action-plugin-docs # action plugin has no matching module to provide documentation

tests/sanity/ignore-2.16.txt

@@ -22,3 +22,4 @@ plugins/modules/dcnm_log.py validate-modules:missing-gplv3-license # GPLv3 licen
 plugins/module_utils/common/sender_requests.py import-3.10 # TODO remove this if/when requests is added to the standard library
 plugins/module_utils/common/sender_requests.py import-3.11 # TODO remove this if/when requests is added to the standard library
 plugins/modules/dcnm_fabric_member.py validate-modules:missing-gplv3-license # GPLv3 license header not found in the first 20 lines of the module
+plugins/action/tests/unit/ndfc_pc_members_validate.py action-plugin-docs # action plugin has no matching module to provide documentation