Partial ansible-lint fixes applied

  1. Schema Violations
    - Replaced deprecated include with ansible.builtin.include_tasks
    - Fixed old-style include directives
  2. Naming Violations
    - Capitalized task names that started with lowercase letters
    - Added names to plays and tasks that were missing them
    - Fixed naming issues
  3. YAML Truthy Violations
    - Converted True/False to lowercase true/false
  4. Indentation Violations
    - Corrected wrong indentation
    - Fixed expected vs found indentation mismatches
  5. YAML Formatting Issues
    - Fixed trailing spaces
    - Removed excessive empty lines
    - Corrected colon spacing
    - Fixed bracket spacing
  6. FQCN Violations
    - Added ansible.builtin prefix to core module calls
    - Applied to include_tasks, set_fact, debug, etc.
  7. Module Docstring YAML Errors
    - Fixed syntax errors
    - Removed excess blank lines in documentation strings
    - Corrected YAML formatting in EXAMPLES sections
  8. Miscellaneous Fixes
    - Fixed no-free-form violations in set_fact calls
    - Corrected var-naming pattern
    - Fixed jinja2 spacing

Author: sivakasi-cisco

galaxy.yml

@@ -1,6 +1,6 @@
 ---
 namespace: cisco
-name: dcnm
+name: Dcnm
 version: 3.9.0-dev
 readme: README.md
 authors:

playbooks/roles/dcnm_bootflash/create_files.yaml

@@ -8,10 +8,10 @@
     - name: SETUP - Create files on {{ switch1 }}
       cisco.nxos.nxos_command:
         commands:
-          - echo 1 > bootflash:/{{ nxos_vars.switch1_file1 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch1_file2 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch1_file3 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch1_file4 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch1_file1 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch1_file2 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch1_file3 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch1_file4 }}
 
 - gather_facts: false
   hosts:
@@ -22,7 +22,7 @@
     - name: SETUP - Create files on {{ switch2 }}
       cisco.nxos.nxos_command:
         commands:
-          - echo 1 > bootflash:/{{ nxos_vars.switch2_file1 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch2_file2 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch2_file3 }}
-          - echo 1 > bootflash:/{{ nxos_vars.switch2_file4 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch2_file1 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch2_file2 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch2_file3 }}
+          - echo 1 > bootflash: /{{ nxos_vars.switch2_file4 }}

playbooks/roles/dcnm_bootflash/dcnm_hosts.yaml

@@ -3,8 +3,8 @@ all:
     ansible_user: "admin"
     ansible_password: "password-secret"
     ansible_python_interpreter: python
-    ansible_httpapi_validate_certs: False
-    ansible_httpapi_use_ssl: True
+    ansible_httpapi_validate_certs: false
+    ansible_httpapi_use_ssl: true
   children:
     dcnm:
       vars:

playbooks/roles/dcnm_bootflash/dcnm_tests.yaml

@@ -8,6 +8,7 @@
 # setup and uncomment the testcase you want to run.
 #
 - hosts: dcnm
+  name: Play for dcnm
   gather_facts: false
   connection: ansible.netcommon.httpapi
 

playbooks/roles/dcnm_fabric/dcnm_hosts.yaml

@@ -3,8 +3,8 @@ all:
     ansible_user: "admin"
     ansible_password: "password-secret"
     ansible_python_interpreter: python
-    ansible_httpapi_validate_certs: False
-    ansible_httpapi_use_ssl: True
+    ansible_httpapi_validate_certs: false
+    ansible_httpapi_use_ssl: true
   children:
     dcnm:
       vars:
@@ -15,6 +15,6 @@ all:
     nxos:
       hosts:
         n9k-hosta.example.com:
-           ansible_connection: ansible.netcommon.network_cli
+          ansible_connection: ansible.netcommon.network_cli
            ansible_network_os: cisco.nxos.nxos
            ansible_ssh_port: 22

playbooks/roles/dcnm_fabric/dcnm_tests.yaml

@@ -15,6 +15,7 @@
 #    Fabric Controller -> Admin -> System Settings -> Feature Management
 #    "Fabric Builder" is checked.
 - hosts: dcnm
+  name: Play for dcnm
   gather_facts: false
   connection: ansible.netcommon.httpapi
 

playbooks/roles/dcnm_image_policy/dcnm_hosts.yaml

@@ -3,8 +3,8 @@ all:
     ansible_user: "admin"
     ansible_password: "password-secret"
     ansible_python_interpreter: python
-    ansible_httpapi_validate_certs: False
-    ansible_httpapi_use_ssl: True
+    ansible_httpapi_validate_certs: false
+    ansible_httpapi_use_ssl: true
   children:
     dcnm:
       vars:
@@ -15,6 +15,6 @@ all:
     nxos:
       hosts:
         n9k-hosta.example.com:
-           ansible_connection: ansible.netcommon.network_cli
+          ansible_connection: ansible.netcommon.network_cli
            ansible_network_os: cisco.nxos.nxos
            ansible_ssh_port: 22

playbooks/roles/dcnm_image_policy/dcnm_tests.yaml

@@ -8,6 +8,7 @@
 # setup and uncomment the testcase you want to run.
 #
 - hosts: dcnm
+  name: Play for dcnm
   gather_facts: false
   connection: ansible.netcommon.httpapi
 

playbooks/roles/dcnm_image_upgrade/dcnm_hosts.yaml

@@ -4,8 +4,8 @@ all:
     ansible_password: "password-ndfc"
     switch_password: "password-switch"
     ansible_python_interpreter: python
-    ansible_httpapi_validate_certs: False
-    ansible_httpapi_use_ssl: True
+    ansible_httpapi_validate_certs: false
+    ansible_httpapi_use_ssl: true
   children:
     ndfc:
       vars:

playbooks/roles/dcnm_image_upgrade/dcnm_tests.yaml

@@ -8,6 +8,7 @@
 # setup and uncomment the testcase you want to run.
 #
 - hosts: dcnm
+  name: Play for dcnm
   gather_facts: false
   connection: ansible.netcommon.httpapi