dcnm.py: dcnm_update_arg_specs(): implement without eval() #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite dcnm_update_arg_specs() without eval. I’ve tested this against the original function using a test script that works with all of the data passed through these functions by the unit tests for dcnm_vpc_pairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite dcnm_update_arg_specs() without eval.
dcnm_update_arg_specs() is used only by the dcnm_vpc_pairs module.
I’ve tested this against the original function using a test script that works with all of the data passed through these functions by the unit tests for dcnm_vpc_pairs.
We should probably move this function into the dcnm_vpc_pairs module since it's not used by anything else...