Cacit issue 149 (#153)

* removed desc from required resources

* removed desc

* updated rest resource

Author: nkatarmal-crest

aci/resource_aci_l3extdomp.go

@@ -82,7 +82,6 @@ func getRemoteL3DomainProfile(client *client.Client, dn string) (*models.L3Domai
 
 func setL3DomainProfileAttributes(l3extDomP *models.L3DomainProfile, d *schema.ResourceData) *schema.ResourceData {
 	d.SetId(l3extDomP.DistinguishedName)
-	d.Set("description", l3extDomP.Description)
 	l3extDomPMap, _ := l3extDomP.ToMap()
 
 	d.Set("name", l3extDomPMap["name"])
@@ -113,7 +112,6 @@ func resourceAciL3DomainProfileImport(d *schema.ResourceData, m interface{}) ([]
 func resourceAciL3DomainProfileCreate(d *schema.ResourceData, m interface{}) error {
 	log.Printf("[DEBUG] L3DomainProfile: Beginning Creation")
 	aciClient := m.(*client.Client)
-	desc := d.Get("description").(string)
 
 	name := d.Get("name").(string)
 
@@ -126,7 +124,7 @@ func resourceAciL3DomainProfileCreate(d *schema.ResourceData, m interface{}) err
 	if NameAlias, ok := d.GetOk("name_alias"); ok {
 		l3extDomPAttr.NameAlias = NameAlias.(string)
 	}
-	l3extDomP := models.NewL3DomainProfile(fmt.Sprintf("l3dom-%s", name), "uni", desc, l3extDomPAttr)
+	l3extDomP := models.NewL3DomainProfile(fmt.Sprintf("l3dom-%s", name), "uni", "", l3extDomPAttr)
 
 	err := aciClient.Save(l3extDomP)
 	if err != nil {
@@ -242,7 +240,6 @@ func resourceAciL3DomainProfileUpdate(d *schema.ResourceData, m interface{}) err
 	log.Printf("[DEBUG] L3DomainProfile: Beginning Update")
 
 	aciClient := m.(*client.Client)
-	desc := d.Get("description").(string)
 
 	name := d.Get("name").(string)
 
@@ -255,7 +252,7 @@ func resourceAciL3DomainProfileUpdate(d *schema.ResourceData, m interface{}) err
 	if NameAlias, ok := d.GetOk("name_alias"); ok {
 		l3extDomPAttr.NameAlias = NameAlias.(string)
 	}
-	l3extDomP := models.NewL3DomainProfile(fmt.Sprintf("l3dom-%s", name), "uni", desc, l3extDomPAttr)
+	l3extDomP := models.NewL3DomainProfile(fmt.Sprintf("l3dom-%s", name), "uni", "", l3extDomPAttr)
 
 	l3extDomP.Status = "modified"
 

aci/resource_aci_physdomp.go

@@ -76,7 +76,6 @@ func getRemotePhysicalDomain(client *client.Client, dn string) (*models.Physical
 
 func setPhysicalDomainAttributes(physDomP *models.PhysicalDomain, d *schema.ResourceData) *schema.ResourceData {
 	d.SetId(physDomP.DistinguishedName)
-	d.Set("description", physDomP.Description)
 	physDomPMap, _ := physDomP.ToMap()
 
 	d.Set("name", physDomPMap["name"])
@@ -107,7 +106,6 @@ func resourceAciPhysicalDomainImport(d *schema.ResourceData, m interface{}) ([]*
 func resourceAciPhysicalDomainCreate(d *schema.ResourceData, m interface{}) error {
 	log.Printf("[DEBUG] PhysicalDomain: Beginning Creation")
 	aciClient := m.(*client.Client)
-	desc := d.Get("description").(string)
 
 	name := d.Get("name").(string)
 
@@ -120,7 +118,7 @@ func resourceAciPhysicalDomainCreate(d *schema.ResourceData, m interface{}) erro
 	if NameAlias, ok := d.GetOk("name_alias"); ok {
 		physDomPAttr.NameAlias = NameAlias.(string)
 	}
-	physDomP := models.NewPhysicalDomain(fmt.Sprintf("phys-%s", name), "uni", desc, physDomPAttr)
+	physDomP := models.NewPhysicalDomain(fmt.Sprintf("phys-%s", name), "uni", "", physDomPAttr)
 
 	err := aciClient.Save(physDomP)
 	if err != nil {
@@ -216,7 +214,6 @@ func resourceAciPhysicalDomainUpdate(d *schema.ResourceData, m interface{}) erro
 	log.Printf("[DEBUG] PhysicalDomain: Beginning Update")
 
 	aciClient := m.(*client.Client)
-	desc := d.Get("description").(string)
 
 	name := d.Get("name").(string)
 
@@ -229,7 +226,7 @@ func resourceAciPhysicalDomainUpdate(d *schema.ResourceData, m interface{}) erro
 	if NameAlias, ok := d.GetOk("name_alias"); ok {
 		physDomPAttr.NameAlias = NameAlias.(string)
 	}
-	physDomP := models.NewPhysicalDomain(fmt.Sprintf("phys-%s", name), "uni", desc, physDomPAttr)
+	physDomP := models.NewPhysicalDomain(fmt.Sprintf("phys-%s", name), "uni", "", physDomPAttr)
 
 	physDomP.Status = "modified"
 

aci/resource_rest.go

@@ -59,7 +59,7 @@ func resourceAciRestCreate(d *schema.ResourceData, m interface{}) error {
 	}
 	classNameIntf := d.Get("class_name")
 	className := classNameIntf.(string)
-	dn := cont.Search(className, "attributes", "dn").String()
+	dn := models.StripQuotes(models.StripSquareBrackets(cont.Search(className, "attributes", "dn").String()))
 
 	if dn == "{}" {
 		d.SetId(GetDN(d, m))
@@ -79,7 +79,7 @@ func resourceAciRestUpdate(d *schema.ResourceData, m interface{}) error {
 	}
 	classNameIntf := d.Get("class_name")
 	className := classNameIntf.(string)
-	dn := cont.Search(className, "attributes", "dn").String()
+	dn := models.StripQuotes(models.StripSquareBrackets(cont.Search(className, "attributes", "dn").String()))
 	if dn == "{}" {
 		d.SetId(GetDN(d, m))