Made changes based on PR comments

Author: anvitha-jain

README.md

@@ -90,7 +90,7 @@ If you want to work on the provider, you'll first need [Go](http://www.golang.or
 
 To compile the provider, run `make build`. This will build the provider with sanity checks present in scripts directory and put the provider binary in `$GOPATH/bin` directory.
 
-<strong>Important: </strong>To successfully use the provider you need to use the below configuration just before setting up the provider with your cisco aci credentials.
+<strong>Important: </strong>To successfully use the provider you need to have the below configuration in your Terraform plan.
 
 ```hcl
 terraform {

examples/epg/contract.tf

@@ -3,30 +3,37 @@ resource "aci_tenant" "tenant_for_contract" {
   description = "This tenant is created by terraform ACI provider"
 }
 
+resource "aci_l4_l7_service_graph_template" "rest_abs_graph" {
+  tenant_dn                         = aci_tenant.tenant_for_contract.id
+  name                              = "testgraph"
+}
+
 resource "aci_contract" "rs_prov_contract" {
   tenant_dn                = aci_tenant.tenant_for_contract.id
   name                     = "rs_prov_contract"
   description              = "This contract is created by terraform ACI provider"
   scope                    = "context"
   target_dscp              = "VA"
   prio                     = "unspecified"
-  relation_vz_rs_graph_att = aci_rest.rest_abs_graph.id # Relation to vnsAbsGraph class. Cardinality - N_TO_ONE
+  relation_vz_rs_graph_att = aci_l4_l7_service_graph_template.rest_abs_graph.id
 }
+
 resource "aci_contract" "rs_cons_contract" {
   tenant_dn                = aci_tenant.tenant_for_contract.id
   name                     = "rs_cons_contract"
   description              = "This contract is created by terraform ACI provider"
   scope                    = "context"
   target_dscp              = "VA"
   prio                     = "unspecified"
-  relation_vz_rs_graph_att = aci_rest.rest_abs_graph.id # Relation to vnsAbsGraph class. Cardinality - N_TO_ONE
+  relation_vz_rs_graph_att = aci_l4_l7_service_graph_template.rest_abs_graph.id
 }
+
 resource "aci_contract" "intra_epg_contract" {
   tenant_dn                = aci_tenant.tenant_for_contract.id
   name                     = "intra_epg_contract"
   description              = "This contract is created by terraform ACI provider"
   scope                    = "context"
   target_dscp              = "VA"
   prio                     = "unspecified"
-  relation_vz_rs_graph_att = aci_rest.rest_abs_graph.id # Relation to vnsAbsGraph class. Cardinality - N_TO_ONE
+  relation_vz_rs_graph_att = aci_l4_l7_service_graph_template.rest_abs_graph.id
 }

examples/epg/epg.tf

@@ -29,13 +29,9 @@ resource "aci_application_epg" "demoepg" {
   prio                         = "unspecified"
   relation_fv_rs_bd            = aci_bridge_domain.bd_for_rel.id      # Relation to fvBD class. Cardinality - N_TO_ONE.
   relation_fv_rs_cust_qos_pol  = aci_rest.rest_qos_custom_pol.id      # Relation to qosCustomPol class. Cardinality - N_TO_ONE.
-  // relation_fv_rs_fc_path_att   = ["testfabric"]                            # Relation to fabricPathEp class. Cardinality - N_TO_M.
-
   relation_fv_rs_prov          = [aci_contract.rs_prov_contract.id]   # Relation to vzBrCP class. Cardinality - N_TO_M.
-
   relation_fv_rs_cons_if       = [aci_rest.rest_vz_cons_if.id]        # Relation to vzCPIf class. Cardinality - N_TO_M.
   relation_fv_rs_sec_inherited = [aci_application_epg.inherit_epg.id] # Relation to fvEPg class. Cardinality - N_TO_M.
-  // relation_fv_rs_node_att      = ["testnodeatt"]                           # Relation to fabricNode class. Cardinality - N_TO_M.
   relation_fv_rs_dpp_pol       = aci_rest.rest_qos_dpp_pol.id         # Relation to qosDppPol class. Cardinality - N_TO_ONE.ye
   relation_fv_rs_cons          = [aci_contract.rs_cons_contract.id]   # Relation to vzBrCP class. Cardinality - N_TO_M.
   relation_fv_rs_trust_ctrl    = aci_rest.rest_trust_ctrl_pol.id      # Relation to fhsTrustCtrlPol class. Cardinality - N_TO_ONE.

examples/epg/main.tf

@@ -7,9 +7,9 @@ terraform {
 }
 
 provider "aci" {
-  username = ""
-  password = ""
-  url      = ""
+  username = "" # <APIC username>
+  password = "" # <APIC pwd>
+  url      = "" # <cloud APIC URL>
   insecure = true
 }
 

examples/epg/rest.tf

@@ -56,12 +56,3 @@ resource "aci_rest" "rest_taboo_con" {
     "name" = "testcon"
   }
 }
-
-resource "aci_rest" "rest_abs_graph" {
-  path       = "api/node/mo/${aci_tenant.tenant_for_contract.id}/AbsGraph-testgraph.json"
-  class_name = "vnsAbsGraph"
-
-  content = {
-    "name" = "testgraph"
-  }
-}

website/docs/r/application_epg.html.markdown

@@ -46,37 +46,37 @@ Manages ACI Application EPG
 * `prio` - (Optional) qos priority class id. Allowed values are "unspecified", "level1", "level2", "level3", "level4", "level5" and "level6". Default is "unspecified.
 * `shutdown` - (Optional) shutdown for object application_epg. Allowed values are "yes" and "no". Default is "no".
 
-* `relation_fv_rs_bd` - (Required) Relation to Bridge domain associated with EPG (class fvBD). Cardinality - N_TO_ONE. Type - String.
-                
-* `relation_fv_rs_cust_qos_pol` - (Optional) Relation to custom Quality of Service traffic policy name (class qosCustomPol). Cardinality - N_TO_ONE. Type - String.
+* `relation_fv_rs_bd` - (Required) Relation to Bridge domain associated with EPG (Point to class fvBD). Cardinality - N_TO_ONE. Type - String.
+
+* `relation_fv_rs_cust_qos_pol` - (Optional) Relation to custom Quality of Service traffic policy name (Point to class qosCustomPol). Cardinality - N_TO_ONE. Type - String.
 <!-- tenant -> policies -> protocol -> Custom QoS -->
-                
-* `relation_fv_rs_fc_path_att` - (Optional) Relation to deploy Fibre Channel(paths) (class fabricPathEp). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_prov` - (Optional) Relation to Provided Contract(class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_cons_if` - (Optional) Relation to imported contract (class vzCPIf). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_sec_inherited` - (Optional) Relation represents that the EPg is inheriting security configuration from another EPg (class fvEPg). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_node_att` - (Optional) Relation between EPG and fabricNode (class fabricNode). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_fc_path_att` - (Optional) Relation to Fibre Channel (Paths)(Point to class fabricPathEp). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_prov` - (Optional) Relation to Provided Contract (Point to class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_cons_if` - (Optional) Relation to Imported Contract (Point to class vzCPIf). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_sec_inherited` - (Optional) Relation represents that the EPG is inheriting security configuration from another EPG (Point to class fvEPg). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_node_att` - (Optional) Relation used to define a Static Leaf binding (Point to class fabricNode). Cardinality - N_TO_M. Type - Set of String.
 <!-- tenant -> Application Profile -> EPG ->Static Leaf -->
-                
-* `relation_fv_rs_dpp_pol` - (Optional) Relation to define a Data Plane Policing policy (class qosDppPol). Cardinality - N_TO_ONE. Type - String.
+
+* `relation_fv_rs_dpp_pol` - (Optional) Relation to define a Data Plane Policing policy (Point to class qosDppPol). Cardinality - N_TO_ONE. Type - String.
 <!-- tenant -> policies -> protocol -> Data Plane Policing -->
-                
-* `relation_fv_rs_cons` - (Optional) Relation to Consumed Contract (class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_trust_ctrl` - (Optional) Relation to First Hop Security trust control (class fhsTrustCtrlPol). Cardinality - N_TO_ONE. Type - String.
+
+* `relation_fv_rs_cons` - (Optional) Relation to Consumed Contract (Point to class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_trust_ctrl` - (Optional) Relation to First Hop Security trust control (Point to class fhsTrustCtrlPol). Cardinality - N_TO_ONE. Type - String.
 <!-- tenant -> policies -> protocol -> First Hop Security -->
-                                
-* `relation_fv_rs_prot_by` - (Optional) Relation to Taboo Contract (class vzTaboo). Cardinality - N_TO_M. Type - Set of String.
-                
-* `relation_fv_rs_aepg_mon_pol` - (Optional) Relation to create a container for monitoring policies associated with the tenant. This allows you to apply tenant-specific policies (class monEPGPol). Cardinality - N_TO_ONE. Type - String.
+
+* `relation_fv_rs_prot_by` - (Optional) Relation to Taboo Contract (Point to class vzTaboo). Cardinality - N_TO_M. Type - Set of String.
+
+* `relation_fv_rs_aepg_mon_pol` - (Optional) Relation to create a container for monitoring policies associated with the tenant. This allows you to apply tenant-specific policies (Point to class monEPGPol). Cardinality - N_TO_ONE. Type - String.
 <!-- tenant -> policies -> Monitoring -->
-                
-* `relation_fv_rs_intra_epg` - (Optional) Relation to Intra EPG Contract (class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
-                
+
+* `relation_fv_rs_intra_epg` - (Optional) Relation to Intra EPG Contract (Point to class vzBrCP). Cardinality - N_TO_M. Type - Set of String.
+
 
 
 ## Attribute Reference