Add name in subnet (#159)

* added name in cldSubnet

* docs updated

Author: nkatarmal-crest

aci/data_source_aci_cloudsubnet.go

@@ -25,6 +25,12 @@ func dataSourceAciCloudSubnet() *schema.Resource {
 				Required: true,
 			},
 
+			"name": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
 			"name_alias": &schema.Schema{
 				Type:     schema.TypeString,
 				Optional: true,

aci/resource_aci_cloudsubnet.go

@@ -36,6 +36,12 @@ func resourceAciCloudSubnet() *schema.Resource {
 				ForceNew: true,
 			},
 
+			"name": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,
+				Computed: true,
+			},
+
 			"name_alias": &schema.Schema{
 				Type:     schema.TypeString,
 				Optional: true,
@@ -104,6 +110,7 @@ func setCloudSubnetAttributes(cloudSubnet *models.CloudSubnet, d *schema.Resourc
 	cloudSubnetMap, _ := cloudSubnet.ToMap()
 
 	d.Set("ip", cloudSubnetMap["ip"])
+	d.Set("name", cloudSubnetMap["name"])
 
 	d.Set("annotation", cloudSubnetMap["annotation"])
 	d.Set("ip", cloudSubnetMap["ip"])
@@ -146,6 +153,9 @@ func resourceAciCloudSubnetCreate(d *schema.ResourceData, m interface{}) error {
 	CloudCIDRPoolDn := d.Get("cloud_cidr_pool_dn").(string)
 
 	cloudSubnetAttr := models.CloudSubnetAttributes{}
+	if name, ok := d.GetOk("name"); ok {
+		cloudSubnetAttr.Name = name.(string)
+	}
 	if Annotation, ok := d.GetOk("annotation"); ok {
 		cloudSubnetAttr.Annotation = Annotation.(string)
 	} else {
@@ -231,6 +241,9 @@ func resourceAciCloudSubnetUpdate(d *schema.ResourceData, m interface{}) error {
 	CloudCIDRPoolDn := d.Get("cloud_cidr_pool_dn").(string)
 
 	cloudSubnetAttr := models.CloudSubnetAttributes{}
+	if name, ok := d.GetOk("name"); ok {
+		cloudSubnetAttr.Name = name.(string)
+	}
 	if Annotation, ok := d.GetOk("annotation"); ok {
 		cloudSubnetAttr.Annotation = Annotation.(string)
 	} else {

go.mod

@@ -3,7 +3,7 @@ module github.com/terraform-providers/terraform-provider-aci
 go 1.12
 
 require (
-	github.com/ciscoecosystem/aci-go-client v1.3.17
+	github.com/ciscoecosystem/aci-go-client v1.3.20
 	github.com/ghodss/yaml v1.0.0
 	github.com/hashicorp/terraform-plugin-sdk v1.14.0
 	github.com/hashicorp/terraform-plugin-test v1.4.3 // indirect

go.sum

@@ -200,6 +200,8 @@ github.com/ciscoecosystem/aci-go-client v1.3.16 h1:X11gUphT+CPC8/rQzNMyk82yXBiBw
 github.com/ciscoecosystem/aci-go-client v1.3.16/go.mod h1:fhY7vWysK655g3Yp5Fz4Zje/JN4+moRe8RjwiRy0amQ=
 github.com/ciscoecosystem/aci-go-client v1.3.17 h1:mCkNG8paRIA8kVAIpMw8FYpke+ChgbCPdg7BSq6js9k=
 github.com/ciscoecosystem/aci-go-client v1.3.17/go.mod h1:fhY7vWysK655g3Yp5Fz4Zje/JN4+moRe8RjwiRy0amQ=
+github.com/ciscoecosystem/aci-go-client v1.3.20 h1:AFd4MxZY//1wJlbAeDGf00GnHyUHuzySW65PieTCEpo=
+github.com/ciscoecosystem/aci-go-client v1.3.20/go.mod h1:fhY7vWysK655g3Yp5Fz4Zje/JN4+moRe8RjwiRy0amQ=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/coreos/bbolt v1.3.0/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk=
 github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE=

vendor/github.com/ciscoecosystem/aci-go-client/client/client.go

@@ -56,7 +56,7 @@ github.com/aws/aws-sdk-go/service/sts/stsiface
 github.com/bgentry/go-netrc/netrc
 # github.com/bgentry/speakeasy v0.1.0
 github.com/bgentry/speakeasy
-# github.com/ciscoecosystem/aci-go-client v1.3.17
+# github.com/ciscoecosystem/aci-go-client v1.3.20
 github.com/ciscoecosystem/aci-go-client/client
 github.com/ciscoecosystem/aci-go-client/container
 github.com/ciscoecosystem/aci-go-client/models

vendor/github.com/ciscoecosystem/aci-go-client/models/cloud_subnet.go

@@ -30,6 +30,7 @@ data "aci_cloud_subnet" "dev_subnet" {
 ## Attribute Reference
 
 * `id` - Attribute id set to the Dn of the Cloud Subnet.
+* `name` - (Optional) Name for object cloud subnet.
 * `annotation` - (Optional) annotation for object cloud_subnet.
 * `name_alias` - (Optional) name_alias for object cloud_subnet.
 * `scope` - (Optional) The domain applicable to the capability.

vendor/modules.txt

@@ -16,6 +16,7 @@ Manages ACI Cloud Subnet
 	resource "aci_cloud_subnet" "foocloud_subnet" {
 		cloud_cidr_pool_dn = "${aci_cloud_cidr_pool.example.id}"
 		description        = "sample cloud subnet"
+		name			   = "subnet1"	
 		ip                 = "14.12.0.0/28"
 		annotation         = "tag_subnet"
 		name_alias         = "alias_subnet"
@@ -29,6 +30,7 @@ Manages ACI Cloud Subnet
 ## Argument Reference ##
 * `cloud_cidr_pool_dn` - (Required) Distinguished name of parent CloudCIDRPool object.
 * `ip` - (Required) CIDR block of Object cloud_subnet.
+* `name` - (Optional) Name for object cloud subnet.
 * `annotation` - (Optional) annotation for object cloud_subnet.
 * `name_alias` - (Optional) name_alias for object cloud_subnet.
 * `scope` - (Optional) The domain applicable to the capability. Allowed values are "public", "private" and "shared". Default is "private".