Skip to content

Timer issue with copy_to_device API #89

@Tristou27

Description

@Tristou27

Hello,

I'm not sure this is the right place for that but I'll take the risk to ask.

I notice today after a few utilization of the device API copy_to_device that the function is waiting for the timer expiration to return instead of relying on the end of the copy itself. I mean, if we set a timer to 300sec (which is the default btw) and we run a copy, the function will return only after 300 seconds.

After a few investigation (but I may be mistaken), I think that this is due to the use of the Dialog here that have all its statement configured with "loop_continue=True". The Dialog is waiting indefinitely even if there is no longer questions from the device, and the function will return after the end of the timeout.

A quick fix I see is to check somehow if we got the prompt again, that should indicate that the copy operation is either finished or in error. Maybe by adding a dialog statement matching the router's prompt ? Or maybe there is another way?

What do you think?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions