Merge pull request #153 from CiscoTestAutomation/tasarath_fix_syntax_warnings

Fix syntax warning

Author: Taarini

connector/Makefile

@@ -32,6 +32,10 @@ PYTHON        = python3
 TESTCMD       = cd tests; runAll
 DISTDIR       = $(BUILDDIR)/dist
 
+DEPENDENCIES = "paramiko >= 1.15.1" "lxml >= 3.3.0, <5.0.0" \
+				"ncclient >= 0.6.6" grpcio protobuf
+
+
 .PHONY: clean package distribute distribute_staging distribute_staging_external\
         develop undevelop populate_dist_dir help docs distribute_docs test
 
@@ -85,7 +89,8 @@ develop:
 	@echo ""
 
 	@pip3 uninstall -y yang.connector || true
-	@$(PYTHON) setup.py develop -q
+	@pip install $(DEPENDENCIES)
+	@pip install -e . --no-deps
 
 	@echo "Completed building and installing: $@"
 	@echo ""
@@ -98,7 +103,7 @@ undevelop:
 	@echo "Uninstalling $(PKG_NAME) development distributable: $@"
 	@echo ""
 
-	@$(PYTHON) setup.py develop -q --uninstall
+	@pip uninstall $(PKG_NAME) -y
 
 	@echo "Completed uninstalling: $@"
 	@echo ""

connector/docs/changelog/undistributed/changelog_fix_syntax_warning_20241202082730.rst

@@ -0,0 +1,6 @@
+--------------------------------------------------------------------------------
+                                Fix
+--------------------------------------------------------------------------------
+* yang.connector
+    * Deprecated python3 setup.py
+    * Fix syntax warning

ncdiff/Makefile

@@ -32,6 +32,10 @@ PYTHON        = python3
 TESTCMD       = cd tests; runAll
 DISTDIR       = $(BUILDDIR)/dist
 
+DEPENDENCIES = "pyang >= 1.7.3" "ncclient >= 0.6.3" \
+				"requests >= 2.18.4" "xmljson >= 0.1.9" \
+				"yang.connector >= 3.0.0"
+
 .PHONY: clean package distribute distribute_staging distribute_staging_external\
         develop undevelop populate_dist_dir help docs distribute_docs test
 
@@ -84,7 +88,8 @@ develop:
 	@echo ""
 
 	@pip3 uninstall -y yang.ncdiff || true
-	@$(PYTHON) setup.py develop -q
+	@pip install $(DEPENDENCIES)
+	@pip install -e . --no-deps
 
 	@echo "Completed building and installing: $@"
 	@echo ""
@@ -97,7 +102,7 @@ undevelop:
 	@echo "Uninstalling $(PKG_NAME) development distributable: $@"
 	@echo ""
 
-	@$(PYTHON) setup.py develop -q --uninstall
+	@pip uninstall $(PKG_NAME) -y
 
 	@echo "Completed uninstalling: $@"
 	@echo ""

ncdiff/docs/changelog/undistributed/changelog_fix_syntax_warning_20241202082730.rst

@@ -0,0 +1,6 @@
+--------------------------------------------------------------------------------
+                                Fix
+--------------------------------------------------------------------------------
+* yang.ncdiff
+    * Deprecated python3 setup.py
+    * Fix syntax warning

ncdiff/src/yang/ncdiff/ref.py

@@ -362,7 +362,7 @@ def parse_square_bracket(self, to_node=None):
                             self.cut(start_idx+1, end_idx-2, tag, 2)
                         start_idx = None
                     else:
-                        if re.search('^\[[1-9][0-9]*\]$', substring):
+                        if re.search(r'^\[[1-9][0-9]*\]$', substring):
                             numbers = substring[1:-1]
                             self.cut(start_idx+1, end_idx-1, numbers, 2)
                         else: