Allow sharing datasets via a project.

Publishing, unpublishing, and pulling in project-based datasets should
still work as before, albeit with a deprecation warning.

Author: anoto-moniz

src/citrine/__version__.py

@@ -1 +1 @@
-__version__ = "3.4.0"
+__version__ = "3.4.1"

src/citrine/resources/project.py

@@ -351,14 +351,15 @@ def publish(self, *, resource: Resource):
         resource_access = resource.access_control_dict()
         resource_type = resource_access["type"]
         if resource_type == ResourceTypeEnum.DATASET:
-            warn("Datasets are now auotmatically accessible to all projects in a given team, so "
-                 "publishing is no longer necessary.",
+            warn("Newly created datasets belong to a team, making this is unncessary. If it was "
+                 "created before 3.4.0, publish will work as before. Calling publish on datasets "
+                 "will be disabled in 4.0.0, at which time all datasets will be automatically "
+                 "published.",
                  DeprecationWarning)
-        else:
-            self.session.checked_post(
-                f"{self._path()}/published-resources/{resource_type}/batch-publish",
-                version='v3',
-                json={'ids': [resource_access["id"]]})
+        self.session.checked_post(
+            f"{self._path()}/published-resources/{resource_type}/batch-publish",
+            version='v3',
+            json={'ids': [resource_access["id"]]})
         return True
 
     def un_publish(self, *, resource: Resource):
@@ -379,14 +380,15 @@ def un_publish(self, *, resource: Resource):
         resource_access = resource.access_control_dict()
         resource_type = resource_access["type"]
         if resource_type == ResourceTypeEnum.DATASET:
-            warn("Datasets are now auotmatically accessible to all projects in a given team, so "
-                 "unpublishing doesn't do anything.",
+            warn("Newly created datasets belong to a team, making un_publish a no-op. If it was "
+                 "created before 3.4.0, un_publish will work as before. Calling un_publish on "
+                 "datasets will be disabled in 4.0.0, at which time all datasets will be "
+                 "automatically published.",
                  DeprecationWarning)
-        else:
-            self.session.checked_post(
-                f"{self._path()}/published-resources/{resource_type}/batch-un-publish",
-                version='v3',
-                json={'ids': [resource_access["id"]]})
+        self.session.checked_post(
+            f"{self._path()}/published-resources/{resource_type}/batch-un-publish",
+            version='v3',
+            json={'ids': [resource_access["id"]]})
         return True
 
     def pull_in_resource(self, *, resource: Resource):
@@ -407,15 +409,16 @@ def pull_in_resource(self, *, resource: Resource):
         resource_access = resource.access_control_dict()
         resource_type = resource_access["type"]
         if resource_type == ResourceTypeEnum.DATASET:
-            warn("Datasets are now auotmatically accessible to all projects in a given team, so "
-                 "pulling them in is unnecessary.",
+            warn("Newly created datasets belong to a team, making pull_in_resource a no-op. If it "
+                 "was created before 3.4.0, pull_in_resource will work as before. Calling "
+                 "pull_in_resource on datasets will be disabled in 4.0.0, at which time all "
+                 "datasets will be automatically published.",
                  DeprecationWarning)
-        else:
-            base_url = f'/teams/{self.team_id}{self._path()}'
-            self.session.checked_post(
-                f'{base_url}/outside-resources/{resource_type}/batch-pull-in',
-                version='v3',
-                json={'ids': [resource_access["id"]]})
+        base_url = f'/teams/{self.team_id}{self._path()}'
+        self.session.checked_post(
+            f'{base_url}/outside-resources/{resource_type}/batch-pull-in',
+            version='v3',
+            json={'ids': [resource_access["id"]]})
         return True
 
     def owned_dataset_ids(self) -> List[str]:

tests/resources/test_project.py

@@ -96,7 +96,15 @@ def test_publish_resource_deprecated(project, datasets, session):
     with pytest.deprecated_call():
         assert project.publish(resource=dataset)
 
-    assert 0 == session.num_calls
+    assert 1 == session.num_calls
+    expected_call = FakeCall(
+        method='POST',
+        path=f'/projects/{project.uid}/published-resources/DATASET/batch-publish',
+        json={
+            'ids': [str(dataset.uid)]
+        }
+    )
+    assert expected_call == session.last_call
 
 
 def test_pull_in_resource(project, datasets, session):
@@ -124,7 +132,15 @@ def test_pull_in_resource_deprecated(project, datasets, session):
     with pytest.deprecated_call():
         assert project.pull_in_resource(resource=dataset)
 
-    assert 0 == session.num_calls
+    assert 1 == session.num_calls
+    expected_call = FakeCall(
+        method='POST',
+        path=f'/teams/{project.team_id}/projects/{project.uid}/outside-resources/DATASET/batch-pull-in',
+        json={
+            'ids': [str(dataset.uid)]
+        }
+    )
+    assert expected_call == session.last_call
 
 
 def test_un_publish_resource(project, datasets, session):
@@ -152,7 +168,15 @@ def test_un_publish_resource_deprecated(project, datasets, session):
     with pytest.deprecated_call():
         assert project.un_publish(resource=dataset)
 
-    assert 0 == session.num_calls
+    assert 1 == session.num_calls
+    expected_call = FakeCall(
+        method='POST',
+        path=f'/projects/{project.uid}/published-resources/DATASET/batch-un-publish',
+        json={
+            'ids': [str(dataset.uid)]
+        }
+    )
+    assert expected_call == session.last_call
 
 
 def test_datasets_get_project_id(project):